⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Changeset 283370 in webkit


Ignore:
Timestamp:
Oct 1, 2021, 8:35:47 AM (5 years ago)
Author:
Russell Epstein
Message:

Revert "Enable RTCRtpScriptTransform by default"

This reverts commit r282523.

Location:
branches/safari-613.1.3-branch
Files:
15 edited

Legend:

Unmodified
Added
Removed

  • branches/safari-613.1.3-branch/LayoutTests/ChangeLog

    r283290 r283370  
    20022002        * platform/wpe/fast/text/font-weight-parse-expected.txt:
    20032003        * svg/css/getComputedStyle-basic-expected.txt:
    2004 
    2005 2021-09-16  Youenn Fablet  <youenn@apple.com>
    2006 
    2007         Enable RTCRtpScriptTransform by default
    2008         https://bugs.webkit.org/show_bug.cgi?id=230220
    2009         <rdar://problem/83090247>
    2010 
    2011         Reviewed by Eric Carlson.
    2012 
    2013         * http/wpt/webrtc/no-webrtc-transform.html:
    2014         Migrate to new internal setting.
    20152004
    201620052021-09-16  Cameron McCormack  <heycam@apple.com>

  • branches/safari-613.1.3-branch/LayoutTests/http/wpt/webrtc/no-webrtc-transform.html

    r282523 r283370  
    1010promise_test(async (test) => {
    1111    if (window.internals)
    12         internals.settings.setWebRTCEncodedTransformEnabled(true);
     12        internals.settings.setWebRTCInsertableStreamsEnabled(true);
    1313
    1414    const worker = new Worker('no-transform.js');
    … …  
    1919promise_test(async (test) => {
    2020    if (window.internals)
    21         internals.settings.setWebRTCEncodedTransformEnabled(false);
     21        internals.settings.setWebRTCInsertableStreamsEnabled(false);
    2222
    2323    const worker = new Worker('no-transform.js');

  • branches/safari-613.1.3-branch/Source/WTF/ChangeLog

    r283083 r283370  
    420420        Stop using __has_include in favor of version checks, now that
    421421        the header has been around for a while.
    422 
    423 2021-09-16  Youenn Fablet  <youenn@apple.com>
    424 
    425         Enable RTCRtpScriptTransform by default
    426         https://bugs.webkit.org/show_bug.cgi?id=230220
    427 
    428         Reviewed by Eric Carlson.
    429 
    430         Splitting  WebRTCInsertableStreamsEnabled to WebRTCEncodedTransformEnabled and WebRTCSFrameTransformEnabled.
    431         Keeping WebRTCSFrameTransformEnabled as off by default until SFrame solidifies and mark WebRTCEncodedTransformEnabled as on by default.
    432 
    433         * Scripts/Preferences/WebPreferencesExperimental.yaml:
    434422
    4354232021-09-16  Cameron McCormack  <heycam@apple.com>

  • branches/safari-613.1.3-branch/Source/WTF/Scripts/Preferences/WebPreferencesExperimental.yaml

    r282881 r283370  
    14281428      default: WebKit::defaultWebMParserEnabled()
    14291429
    1430 WebRTCEncodedTransformEnabled:
    1431   type: bool
    1432   condition: ENABLE(WEB_RTC)
    1433   humanReadableName: "WebRTC Encoded Transform API"
    1434   humanReadableDescription: "Enable WebRTC Encoded Transform API"
    1435   defaultValue:
    1436     WebKitLegacy:
    1437       default: false
    1438     WebKit:
    1439       default: true
    1440     WebCore:
    1441       default: true
    1442 
    14431430# FIXME: Is this implemented for WebKitLegacy? If not, this should be excluded from WebKitLegacy entirely.
    14441431WebRTCH264LowLatencyEncoderEnabled:
    … …  
    14671454      default: false
    14681455
     1456WebRTCInsertableStreamsEnabled:
     1457  type: bool
     1458  condition: ENABLE(WEB_RTC)
     1459  humanReadableName: "WebRTC Insertable Streams API"
     1460  humanReadableDescription: "Enable WebRTC Insertable Streams API"
     1461  defaultValue:
     1462    WebKitLegacy:
     1463      default: false
     1464    WebKit:
     1465      default: false
     1466    WebCore:
     1467      default: false
     1468
    14691469# FIXME: This is not relevent for WebKitLegacy, so should be excluded from WebKitLegacy entirely.
    14701470WebRTCPlatformCodecsInGPUProcessEnabled:
    … …  
    15011501      default: true
    15021502
    1503 WebRTCSFrameTransformEnabled:
    1504   type: bool
    1505   condition: ENABLE(WEB_RTC)
    1506   humanReadableName: "WebRTC SFrame Transform API"
    1507   humanReadableDescription: "Enable WebRTC SFrame Transform API"
    1508   defaultValue:
    1509     WebKitLegacy:
    1510       default: false
    1511     WebKit:
    1512       default: false
    1513     WebCore:
    1514       default: false
    1515 
    15161503WebRTCSocketsProxyingEnabled:
    15171504  type: bool

  • branches/safari-613.1.3-branch/Source/WebCore/ChangeLog

    r283290 r283370  
    74707470        * Sources.txt:
    74717471        * WebCore.xcodeproj/project.pbxproj:
    7472 
    7473 2021-09-16  Youenn Fablet  <youenn@apple.com>
    7474 
    7475         Enable RTCRtpScriptTransform by default
    7476         https://bugs.webkit.org/show_bug.cgi?id=230220
    7477 
    7478         Reviewed by Eric Carlson.
    7479 
    7480         No change of behavior, renaming WebRTCInsertableStreamsEnabled to WebRTCEncodedTransformEnabled
    7481         and WebRTCSFrameTransformEnabled.
    7482 
    7483         * Modules/mediastream/RTCEncodedAudioFrame.idl:
    7484         * Modules/mediastream/RTCEncodedVideoFrame.idl:
    7485         * Modules/mediastream/RTCRtpReceiver+Transform.idl:
    7486         * Modules/mediastream/RTCRtpSFrameTransform.idl:
    7487         * Modules/mediastream/RTCRtpSFrameTransformErrorEvent.idl:
    7488         * Modules/mediastream/RTCRtpScriptTransform.idl:
    7489         * Modules/mediastream/RTCRtpScriptTransformer.idl:
    7490         * Modules/mediastream/RTCRtpSender+Transform.idl:
    7491         * Modules/mediastream/RTCTransformEvent.idl:
    7492         * workers/DedicatedWorkerGlobalScope.idl:
    74937472
    749474732021-09-16  Cameron McCormack  <heycam@apple.com>

  • branches/safari-613.1.3-branch/Source/WebCore/Modules/mediastream/RTCEncodedAudioFrame.idl

    r282523 r283370  
    3535[
    3636    Conditional=WEB_RTC,
    37     EnabledBySetting=WebRTCEncodedTransform,
     37    EnabledBySetting=WebRTCInsertableStreams,
    3838    Exposed=DedicatedWorker,
    3939    ImplementationLacksVTable,

  • branches/safari-613.1.3-branch/Source/WebCore/Modules/mediastream/RTCEncodedVideoFrame.idl

    r282523 r283370  
    4444[
    4545    Conditional=WEB_RTC,
    46     EnabledBySetting=WebRTCEncodedTransform,
     46    EnabledBySetting=WebRTCInsertableStreams,
    4747    Exposed=DedicatedWorker,
    4848    ImplementationLacksVTable,

  • branches/safari-613.1.3-branch/Source/WebCore/Modules/mediastream/RTCRtpReceiver+Transform.idl

    r282523 r283370  
    2828[
    2929    Conditional=WEB_RTC,
    30     EnabledBySetting=WebRTCEncodedTransform,
     30    EnabledBySetting=WebRTCInsertableStreams,
    3131    Exposed=Window,
    3232    ImplementedBy=RTCRtpReceiverWithTransform,

  • branches/safari-613.1.3-branch/Source/WebCore/Modules/mediastream/RTCRtpSFrameTransform.idl

    r282523 r283370  
    4444    ActiveDOMObject,
    4545    Conditional=WEB_RTC,
    46     EnabledBySetting=WebRTCSFrameTransform,
     46    EnabledBySetting=WebRTCInsertableStreams,
    4747    ExportMacro=WEBCORE_EXPORT,
    4848    Exposed=(Window,DedicatedWorker),

  • branches/safari-613.1.3-branch/Source/WebCore/Modules/mediastream/RTCRtpSFrameTransformErrorEvent.idl

    r282523 r283370  
    3737[
    3838    Conditional=WEB_RTC,
    39     EnabledBySetting=WebRTCSFrameTransform,
     39    EnabledBySetting=WebRTCInsertableStreams,
    4040    Exposed=(Window,DedicatedWorker),
    4141    InterfaceName=SFrameTransformErrorEvent

  • branches/safari-613.1.3-branch/Source/WebCore/Modules/mediastream/RTCRtpScriptTransform.idl

    r282523 r283370  
    2727    ActiveDOMObject,
    2828    Conditional=WEB_RTC,
    29     EnabledBySetting=WebRTCEncodedTransform,
     29    EnabledBySetting=WebRTCInsertableStreams,
    3030    Exposed=Window,
    3131    JSGenerateToNativeObject,

  • branches/safari-613.1.3-branch/Source/WebCore/Modules/mediastream/RTCRtpScriptTransformer.idl

    r282523 r283370  
    2727    ActiveDOMObject,
    2828    Conditional=WEB_RTC,
    29     EnabledBySetting=WebRTCEncodedTransform,
     29    EnabledBySetting=WebRTCInsertableStreams,
    3030    Exposed=DedicatedWorker,
    3131    JSGenerateToNativeObject,

  • branches/safari-613.1.3-branch/Source/WebCore/Modules/mediastream/RTCRtpSender+Transform.idl

    r282523 r283370  
    2828[
    2929    Conditional=WEB_RTC,
    30     EnabledBySetting=WebRTCEncodedTransform,
     30    EnabledBySetting=WebRTCInsertableStreams,
    3131    Exposed=Window,
    3232    ImplementedBy=RTCRtpSenderWithTransform,

  • branches/safari-613.1.3-branch/Source/WebCore/Modules/mediastream/RTCTransformEvent.idl

    r282523 r283370  
    2525[
    2626    Conditional=WEB_RTC,
    27     EnabledBySetting=WebRTCEncodedTransform,
     27    EnabledBySetting=WebRTCInsertableStreams,
    2828    Exposed=Worker,
    2929    InterfaceName=RTCTransformEvent,

  • branches/safari-613.1.3-branch/Source/WebCore/workers/DedicatedWorkerGlobalScope.idl

    r282523 r283370  
    4747
    4848[Conditional=OFFSCREEN_CANVAS_IN_WORKERS, EnabledAtRuntime=OffscreenCanvasInWorkers] DedicatedWorkerGlobalScope includes AnimationFrameProvider;
    49 [Conditional=WEB_RTC, EnabledBySetting=WebRTCEncodedTransform] DedicatedWorkerGlobalScope includes RTCRtpScriptTransformProvider;
     49[Conditional=WEB_RTC, EnabledBySetting=WebRTCInsertableStreams] DedicatedWorkerGlobalScope includes RTCRtpScriptTransformProvider;
Note: See TracChangeset for help on using the changeset viewer.