Changeset 283478 in webkit

Timestamp:

Oct 3, 2021, 2:02:20 PM (5 years ago)

Author:

basuke.suzuki@sony.com

Message:

[PlayStation] Pass logging channel parameter to WebProcess from environment variable
​https://bugs.webkit.org/show_bug.cgi?id=230726
<rdar://problem/83740947>

Reviewed by Fujii Hironori.

Added release log configuration environment variables to PlayStation port.

• UIProcess/playstation/WebProcessPoolPlayStation.cpp:

(WebKit::WebProcessPool::platformInitializeWebProcess):

• WebProcess/playstation/WebProcessPlayStation.cpp:

(WebKit::WebProcess::platformInitializeWebProcess):

Location:

trunk/Source/WebKit

Files:

• ChangeLog (modified) (1 diff)
• UIProcess/playstation/WebProcessPoolPlayStation.cpp (modified) (2 diffs)
• WebProcess/playstation/WebProcessPlayStation.cpp (modified) (1 diff)

trunk/Source/WebKit/ChangeLog

@@ +1 @@
+2021-10-03  Basuke Suzuki  <basuke.suzuki@sony.com>
+
+        [PlayStation] Pass logging channel parameter to WebProcess from environment variable
+        https://bugs.webkit.org/show_bug.cgi?id=230726
+        <rdar://problem/83740947>
+
+        Reviewed by Fujii Hironori.
+
+        Added release log configuration environment variables to PlayStation port.
+
+        * UIProcess/playstation/WebProcessPoolPlayStation.cpp:
+        (WebKit::WebProcessPool::platformInitializeWebProcess):
+        * WebProcess/playstation/WebProcessPlayStation.cpp:
+        (WebKit::WebProcess::platformInitializeWebProcess):
+
 2021-10-03  David Kilzer  <ddkilzer@apple.com>
 

trunk/Source/WebKit/UIProcess/playstation/WebProcessPoolPlayStation.cpp

@@ -27 +27 @@
 #include "WebProcessPool.h"
 
+#include "WebProcessCreationParameters.h"
+
 namespace WebKit {
 
@@ -39 +41 @@
 }
 
-void WebProcessPool::platformInitializeWebProcess(const WebProcessProxy&, WebProcessCreationParameters&)
+void WebProcessPool::platformInitializeWebProcess(const WebProcessProxy&, WebProcessCreationParameters& parameters)
 {
-    notImplemented();
+#if !LOG_DISABLED || !RELEASE_LOG_DISABLED
+    char buf[2048];
+    if (getenv_np("WTFLogging", buf, sizeof(buf)))
+        parameters.wtfLoggingChannels = buf;
+    if (getenv_np("WebCoreLogging", buf, sizeof(buf)))
+        parameters.webCoreLoggingChannels = buf;
+    if (getenv_np("WebKitLogging", buf, sizeof(buf)))
+        parameters.webKitLoggingChannels = buf;
+#else
+    UNUSED_PARAM(parameters);
+#endif
 }
 

trunk/Source/WebKit/WebProcess/playstation/WebProcessPlayStation.cpp

@@ -27 +27 @@
 #include "WebProcess.h"
 
+#include "LogInitialization.h"
+#include <WebCore/LogInitialization.h>
+#include <wtf/LogInitialization.h>
+
 namespace WebKit {
 
-void WebProcess::platformInitializeWebProcess(WebProcessCreationParameters&)
+void WebProcess::platformInitializeWebProcess(WebProcessCreationParameters& parameters)
 {
+#if !LOG_DISABLED || !RELEASE_LOG_DISABLED
+    WTF::logChannels().initializeLogChannelsIfNecessary(parameters.wtfLoggingChannels);
+    WebCore::logChannels().initializeLogChannelsIfNecessary(parameters.webCoreLoggingChannels);
+    WebKit::logChannels().initializeLogChannelsIfNecessary(parameters.webKitLoggingChannels);
+#else
+    UNUSED_PARAM(parameters);
+#endif
 }