Changeset 283484 in webkit

Timestamp:

Oct 3, 2021, 4:09:02 PM (5 years ago)

Author:

weinig@apple.com

Message:

WebXRSession's m_environmentBlendMode and m_interactionMode are never initialized
​https://bugs.webkit.org/show_bug.cgi?id=231144

Reviewed by Dean Jackson.

The m_environmentBlendMode and m_interactionMode members of WebXRSession were
not being initialized to anything and therefor were giving random data. This
is not really testable, as the result is just that the tests no longer flake.

• Modules/webxr/WebXRSession.h:

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• Modules/webxr/WebXRSession.h (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2021-10-03  Sam Weinig  <weinig@apple.com>
+
+        WebXRSession's m_environmentBlendMode and m_interactionMode are never initialized
+        https://bugs.webkit.org/show_bug.cgi?id=231144
+
+        Reviewed by Dean Jackson.
+
+        The m_environmentBlendMode and m_interactionMode members of WebXRSession were
+        not being initialized to anything and therefor were giving random data. This
+        is not really testable, as the result is just that the tests no longer flake.
+
+        * Modules/webxr/WebXRSession.h:
+
 2021-10-03  David Kilzer  <ddkilzer@apple.com>
 

trunk/Source/WebCore/Modules/webxr/WebXRSession.h

@@ -127 +127 @@
     void applyPendingRenderState();
 
-    XREnvironmentBlendMode m_environmentBlendMode;
-    XRInteractionMode m_interactionMode;
+    XREnvironmentBlendMode m_environmentBlendMode { XREnvironmentBlendMode::Opaque };
+    XRInteractionMode m_interactionMode { XRInteractionMode::WorldSpace };
     XRVisibilityState m_visibilityState { XRVisibilityState::Visible };
     UniqueRef<WebXRInputSourceArray> m_inputSources;