Changeset 283487 in webkit

Timestamp:

Oct 3, 2021, 10:37:08 PM (5 years ago)

Author:

Lauro Moura

Message:

[GTK] REGRESSION(r283304): All GTK4 layout tests are aborting
​https://bugs.webkit.org/show_bug.cgi?id=231153

Reviewed by Alexey Proskuryakov.

Revert back to the previous NOP behavior of bindAccessibilityTree()
for GTK4, leaving the assert for the debug mode with an informative
message in the log.

Covered by existing tests.

• UIProcess/gtk/WebPageProxyGtk.cpp:

(WebKit::WebPageProxy::bindAccessibilityTree):

Location:

trunk/Source/WebKit

Files:

• ChangeLog (modified) (1 diff)
• UIProcess/gtk/WebPageProxyGtk.cpp (modified) (1 diff)

trunk/Source/WebKit/ChangeLog

@@ +1 @@
+2021-10-03  Lauro Moura  <lmoura@igalia.com>
+
+        [GTK] REGRESSION(r283304): All GTK4 layout tests are aborting
+        https://bugs.webkit.org/show_bug.cgi?id=231153
+
+        Reviewed by Alexey Proskuryakov.
+
+        Revert back to the previous NOP behavior of bindAccessibilityTree()
+        for GTK4, leaving the assert for the debug mode with an informative
+        message in the log.
+
+        Covered by existing tests.
+
+        * UIProcess/gtk/WebPageProxyGtk.cpp:
+        (WebKit::WebPageProxy::bindAccessibilityTree):
+
 2021-10-03  Don Olmstead  <don.olmstead@sony.com>
 

trunk/Source/WebKit/UIProcess/gtk/WebPageProxyGtk.cpp

@@ -54 +54 @@
 #if USE(GTK4)
     // FIXME: We need a way to override accessible interface of WebView and send the atspi reference to the web process.
-    RELEASE_ASSERT_NOT_REACHED();
+    ASSERT_NOT_IMPLEMENTED_YET();
 #else
     auto* accessible = gtk_widget_get_accessible(viewWidget());