Changeset 283600 in webkit

Timestamp:

Oct 5, 2021, 10:20:07 PM (5 years ago)

Author:

sbarati@apple.com

Message:

Don't pass DontBuildStrings to next token after parsing an empty parameter list
​https://bugs.webkit.org/show_bug.cgi?id=225094
<rdar://problem/77231778>

Reviewed by Yusuke Suzuki.

JSTests:

• stress/dont-pass-DontBuildStrings-when-building-empty-arguments-list.js: Added.

(main.a.prototype.g.toString.string_appeared_here):
(main.a):
(main):

Source/JavaScriptCore:

We might need the string, it turns out!

• parser/Parser.cpp:

(JSC::Parser<LexerType>::parseArguments):

Location:

trunk

Files:

• JSTests/ChangeLog (modified) (1 diff)
• JSTests/stress/dont-pass-DontBuildStrings-when-building-empty-arguments-list.js (added)
• Source/JavaScriptCore/ChangeLog (modified) (1 diff)
• Source/JavaScriptCore/parser/Parser.cpp (modified) (1 diff)

trunk/JSTests/ChangeLog

@@ +1 @@
+2021-10-05  Saam Barati  <sbarati@apple.com>
+
+        Don't pass DontBuildStrings to next token after parsing an empty parameter list
+        https://bugs.webkit.org/show_bug.cgi?id=225094
+        <rdar://problem/77231778>
+
+        Reviewed by Yusuke Suzuki.
+
+        * stress/dont-pass-DontBuildStrings-when-building-empty-arguments-list.js: Added.
+        (main.a.prototype.g.toString.string_appeared_here):
+        (main.a):
+        (main):
+
 2021-10-05  Mark Lam  <mark.lam@apple.com>
 

trunk/Source/JavaScriptCore/ChangeLog

@@ +1 @@
+2021-10-05  Saam Barati  <sbarati@apple.com>
+
+        Don't pass DontBuildStrings to next token after parsing an empty parameter list
+        https://bugs.webkit.org/show_bug.cgi?id=225094
+        <rdar://problem/77231778>
+
+        Reviewed by Yusuke Suzuki.
+
+        We might need the string, it turns out!
+
+        * parser/Parser.cpp:
+        (JSC::Parser<LexerType>::parseArguments):
+
 2021-10-05  Patrick Angle  <pangle@apple.com>
 

trunk/Source/JavaScriptCore/parser/Parser.cpp

@@ -4981 +4981 @@
     JSTokenLocation location(tokenLocation());
     if (match(CLOSEPAREN)) {
-        next(TreeBuilder::DontBuildStrings);
+        next();
         return context.createArguments();
     }