Changeset 284247 in webkit

Timestamp:

Oct 15, 2021, 8:25:57 AM (5 years ago)

Author:

Simon Fraser

Message:

REGRESSION (r276370): Elements with animated transform property might not properly rendered
​https://bugs.webkit.org/show_bug.cgi?id=230753

Reviewed by Myles C. Maxfield.

Source/WebCore:

The change in r276370 was incorrect, resulting in the geometry map being used when
an element had a transform and transform-style: preserves-3d.

Fix by going back to testing for the presence of the various transform properties which
affect geometry. hasTransformRelatedProperty() is still useful as a fast bit-check.

Test: fast/repaint/transform-preserve-3d-repaint.html

• rendering/RenderGeometryMap.cpp:

(WebCore::canMapBetweenRenderersViaLayers):

LayoutTests:

• fast/repaint/transform-preserve-3d-repaint-expected.txt: Added.
• fast/repaint/transform-preserve-3d-repaint.html: Added.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/fast/repaint/transform-preserve-3d-repaint-expected.txt (added)
• LayoutTests/fast/repaint/transform-preserve-3d-repaint.html (added)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/rendering/RenderGeometryMap.cpp (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2021-10-15  Simon Fraser  <simon.fraser@apple.com>
+
+        REGRESSION (r276370): Elements with animated transform property might not properly rendered
+        https://bugs.webkit.org/show_bug.cgi?id=230753
+
+        Reviewed by Myles C. Maxfield.
+
+        * fast/repaint/transform-preserve-3d-repaint-expected.txt: Added.
+        * fast/repaint/transform-preserve-3d-repaint.html: Added.
+
 2021-10-15  Tyler Wilcock  <tyler_w@apple.com>
 

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2021-10-15  Simon Fraser  <simon.fraser@apple.com>
+
+        REGRESSION (r276370): Elements with animated transform property might not properly rendered
+        https://bugs.webkit.org/show_bug.cgi?id=230753
+
+        Reviewed by Myles C. Maxfield.
+
+        The change in r276370 was incorrect, resulting in the geometry map being used when
+        an element had a transform and `transform-style: preserves-3d`.
+
+        Fix by going back to testing for the presence of the various transform properties which
+        affect geometry. hasTransformRelatedProperty() is still useful as a fast bit-check.
+
+        Test: fast/repaint/transform-preserve-3d-repaint.html
+
+        * rendering/RenderGeometryMap.cpp:
+        (WebCore::canMapBetweenRenderersViaLayers):
+
 2021-10-15  Tyler Wilcock  <tyler_w@apple.com>
 

trunk/Source/WebCore/rendering/RenderGeometryMap.cpp

@@ -151 +151 @@
             return false;
 
-        if (current->hasTransformRelatedProperty() && !current->style().preserves3D())
+        if (current->hasTransformRelatedProperty() && (style.hasTransform() || style.translate() || style.scale() || style.rotate() || style.hasPerspective()))
             return false;