Changeset 284294 in webkit

Timestamp:

Oct 15, 2021, 5:00:09 PM (5 years ago)

Author:

jer.noble@apple.com

Message:

[iOS] Screen Sharing doesn't switch to AirPlay when <video> enters fullscreen mode
​https://bugs.webkit.org/show_bug.cgi?id=231807
<rdar://82995799>

Reviewed by Eric Carlson.

WebKit will allow AVPlayer to switch to AirPlay Video mode from Screen Sharing when a
<video> element is in fullscreen mode. However, the fullscreen state this code depends on
is not stored in the GPU process.

Implement RemoteMediaPlayerProxy::mediaPlayerFullscreenMode()
and ::mediaPlayerIsVideoFullscreenStandby().

• GPUProcess/media/RemoteMediaPlayerProxy.cpp:

(WebKit::RemoteMediaPlayerProxy::setVideoFullscreenMode):
(WebKit::RemoteMediaPlayerProxy::videoFullscreenStandbyChanged):
(WebKit::RemoteMediaPlayerProxy::mediaPlayerFullscreenMode const):
(WebKit::RemoteMediaPlayerProxy::mediaPlayerIsVideoFullscreenStandby const):

• GPUProcess/media/RemoteMediaPlayerProxy.h:
• GPUProcess/media/RemoteMediaPlayerProxy.messages.in:
• WebProcess/GPU/media/MediaPlayerPrivateRemote.cpp:

(WebKit::MediaPlayerPrivateRemote::videoFullscreenStandbyChanged):

Location:

trunk/Source/WebKit

Files:

• ChangeLog (modified) (1 diff)
• GPUProcess/media/RemoteMediaPlayerProxy.cpp (modified) (2 diffs)
• GPUProcess/media/RemoteMediaPlayerProxy.h (modified) (2 diffs)
• GPUProcess/media/RemoteMediaPlayerProxy.messages.in (modified) (1 diff)
• WebProcess/GPU/media/MediaPlayerPrivateRemote.cpp (modified) (1 diff)

trunk/Source/WebKit/ChangeLog

@@ +1 @@
+2021-10-15  Jer Noble  <jer.noble@apple.com>
+
+        [iOS] Screen Sharing doesn't switch to AirPlay when <video> enters fullscreen mode
+        https://bugs.webkit.org/show_bug.cgi?id=231807
+        <rdar://82995799>
+
+        Reviewed by Eric Carlson.
+
+        WebKit will allow AVPlayer to switch to AirPlay Video mode from Screen Sharing when a
+        <video> element is in fullscreen mode. However, the fullscreen state this code depends on
+        is not stored in the GPU process.
+
+        Implement RemoteMediaPlayerProxy::mediaPlayerFullscreenMode()
+        and ::mediaPlayerIsVideoFullscreenStandby().
+
+        * GPUProcess/media/RemoteMediaPlayerProxy.cpp:
+        (WebKit::RemoteMediaPlayerProxy::setVideoFullscreenMode):
+        (WebKit::RemoteMediaPlayerProxy::videoFullscreenStandbyChanged):
+        (WebKit::RemoteMediaPlayerProxy::mediaPlayerFullscreenMode const):
+        (WebKit::RemoteMediaPlayerProxy::mediaPlayerIsVideoFullscreenStandby const):
+        * GPUProcess/media/RemoteMediaPlayerProxy.h:
+        * GPUProcess/media/RemoteMediaPlayerProxy.messages.in:
+        * WebProcess/GPU/media/MediaPlayerPrivateRemote.cpp:
+        (WebKit::MediaPlayerPrivateRemote::videoFullscreenStandbyChanged):
+
 2021-10-15  Per Arne Vollan  <pvollan@apple.com>
 

trunk/Source/WebKit/GPUProcess/media/RemoteMediaPlayerProxy.cpp

@@ -322 +322 @@
 void RemoteMediaPlayerProxy::setVideoFullscreenMode(MediaPlayer::VideoFullscreenMode mode)
 {
+    m_fullscreenMode = mode;
     m_player->setVideoFullscreenMode(mode);
-
-}
-
-void RemoteMediaPlayerProxy::videoFullscreenStandbyChanged()
-{
+}
+
+void RemoteMediaPlayerProxy::videoFullscreenStandbyChanged(bool standby)
+{
+    m_videoFullscreenStandby = standby;
     m_player->videoFullscreenStandbyChanged();
 }
@@ -820 +821 @@
 MediaPlayerEnums::VideoFullscreenMode RemoteMediaPlayerProxy::mediaPlayerFullscreenMode() const
 {
-    notImplemented();
-    return MediaPlayerEnums::VideoFullscreenModeNone;
+    return m_fullscreenMode;
 }
 
 bool RemoteMediaPlayerProxy::mediaPlayerIsVideoFullscreenStandby() const
 {
-    notImplemented();
-    return false;
+    return m_videoFullscreenStandby;
 }
 #endif

trunk/Source/WebKit/GPUProcess/media/RemoteMediaPlayerProxy.h

@@ -107 +107 @@
     void updateVideoFullscreenInlineImage();
     void setVideoFullscreenMode(WebCore::MediaPlayer::VideoFullscreenMode);
-    void videoFullscreenStandbyChanged();
+    void videoFullscreenStandbyChanged(bool);
 #endif
 
@@ -358 +358 @@
     bool m_bufferedChanged { true };
     bool m_renderingCanBeAccelerated { false };
+    WebCore::MediaPlayer::VideoFullscreenMode m_fullscreenMode { WebCore::MediaPlayer::VideoFullscreenModeNone };
+    bool m_videoFullscreenStandby { false };
 
 #if ENABLE(LEGACY_ENCRYPTED_MEDIA) && ENABLE(ENCRYPTED_MEDIA)

trunk/Source/WebKit/GPUProcess/media/RemoteMediaPlayerProxy.messages.in

@@ -61 +61 @@
     SetVideoFullscreenMode(WebCore::MediaPlayer::VideoFullscreenMode mode)
     SetVideoFullscreenGravity(enum:uint8_t WebCore::MediaPlayerEnums::VideoGravity gravity)
-    VideoFullscreenStandbyChanged()
+    VideoFullscreenStandbyChanged(bool standby)
 #endif
 

trunk/Source/WebKit/WebProcess/GPU/media/MediaPlayerPrivateRemote.cpp

@@ -852 +852 @@
 void MediaPlayerPrivateRemote::videoFullscreenStandbyChanged()
 {
-    connection().send(Messages::RemoteMediaPlayerProxy::VideoFullscreenStandbyChanged(), m_id);
+    RefPtr player = m_player.get();
+    if (!player)
+        return;
+
+    connection().send(Messages::RemoteMediaPlayerProxy::VideoFullscreenStandbyChanged(player->isVideoFullscreenStandby()), m_id);
 }
 #endif