Changeset 284456 in webkit

Timestamp:

Oct 19, 2021 9:00:19 AM (3 years ago)

Author:

fpizlo@apple.com

Message:

StringBuffer should really know that strings might be 8-bit
​https://bugs.webkit.org/show_bug.cgi?id=231937

Reviewed by Yusuke Suzuki.

We somehow forgot to change this to use CharType instead of UChar.

• wtf/text/StringBuffer.h:

(WTF::StringBuffer::resize):

Location:

trunk/Source/WTF

Files:

• ChangeLog (modified) (1 diff)
• wtf/text/StringBuffer.h (modified) (1 diff)

trunk/Source/WTF/ChangeLog

@@ +1 @@
+2021-10-18  Filip Pizlo  <fpizlo@apple.com>
+
+        StringBuffer should really know that strings might be 8-bit
+        https://bugs.webkit.org/show_bug.cgi?id=231937
+
+        Reviewed by Yusuke Suzuki.
+
+        We somehow forgot to change this to use CharType instead of UChar.
+
+        * wtf/text/StringBuffer.h:
+        (WTF::StringBuffer::resize):
+
 2021-10-19  Cameron McCormack  <heycam@apple.com>
 

trunk/Source/WTF/wtf/text/StringBuffer.h

@@ -64 +64 @@
     void resize(unsigned newLength)
     {
-        if (newLength > m_length) {
-            if (newLength > std::numeric_limits<unsigned>::max() / sizeof(UChar))
-                CRASH();
-            m_data = static_cast<UChar*>(StringBufferMalloc::realloc(m_data, newLength * sizeof(UChar)));
-        }
+        if (newLength > m_length)
+            m_data = static_cast<CharType*>(StringBufferMalloc::realloc(m_data, Checked<size_t>(newLength) * sizeof(CharType)));
         m_length = newLength;
     }