Changeset 284467 in webkit

Timestamp:

Oct 19, 2021, 10:36:49 AM (5 years ago)

Author:

ysuzuki@apple.com

Message:

Wasm Table can take arbitrary default value
​https://bugs.webkit.org/show_bug.cgi?id=231933
rdar://84327812

Reviewed by Robin Morisset.

• wasm/WasmTable.cpp:

(JSC::Wasm::Table::grow):

Location:

trunk/Source/JavaScriptCore

Files:

• ChangeLog (modified) (1 diff)
• wasm/WasmTable.cpp (modified) (1 diff)

trunk/Source/JavaScriptCore/ChangeLog

@@ +1 @@
+2021-10-18  Yusuke Suzuki  <ysuzuki@apple.com>
+
+        Wasm Table can take arbitrary default value
+        https://bugs.webkit.org/show_bug.cgi?id=231933
+        rdar://84327812
+
+        Reviewed by Robin Morisset.
+
+        * wasm/WasmTable.cpp:
+        (JSC::Wasm::Table::grow):
+
 2021-10-19  Chris Dumez  <cdumez@apple.com>
 

trunk/Source/JavaScriptCore/wasm/WasmTable.cpp

@@ -116 +116 @@
 
     if (auto* funcRefTable = asFuncrefTable()) {
-        if (!checkedGrow(funcRefTable->m_importableFunctions, [] (auto&) { }))
+        if (!checkedGrow(funcRefTable->m_importableFunctions, [](auto&) { }))
             return std::nullopt;
-        if (!checkedGrow(funcRefTable->m_instances, [] (auto&) { }))
+        if (!checkedGrow(funcRefTable->m_instances, [](auto&) { }))
             return std::nullopt;
     }
 
-    if (!checkedGrow(m_jsValues, [defaultValue] (WriteBarrier<Unknown>& slot) { slot.setStartingValue(defaultValue); }))
+    VM& vm = m_owner->vm();
+    if (!checkedGrow(m_jsValues, [&](WriteBarrier<Unknown>& slot) { slot.set(vm, m_owner, defaultValue); }))
         return std::nullopt;