Changeset 284623 in webkit

Timestamp:

Oct 21, 2021, 10:54:48 AM (5 years ago)

Author:

msaboff@apple.com

Message:

Add missing overflow check to DFGIntegerRangeOptimizationPhase::filterConstant()
​https://bugs.webkit.org/show_bug.cgi?id=232058

Reviewed by Robin Morisset.

Added overflow check.

• dfg/DFGIntegerRangeOptimizationPhase.cpp:

Location:

trunk/Source/JavaScriptCore

Files:

• ChangeLog (modified) (1 diff)
• dfg/DFGIntegerRangeOptimizationPhase.cpp (modified) (1 diff)

trunk/Source/JavaScriptCore/ChangeLog

@@ +1 @@
+2021-10-21  Michael Saboff  <msaboff@apple.com>
+
+        Add missing overflow check to DFGIntegerRangeOptimizationPhase::filterConstant()
+        https://bugs.webkit.org/show_bug.cgi?id=232058
+
+        Reviewed by Robin Morisset.
+
+        Added overflow check.
+
+        * dfg/DFGIntegerRangeOptimizationPhase.cpp:
+
 2021-10-20  Yusuke Suzuki  <ysuzuki@apple.com>
 

trunk/Source/JavaScriptCore/dfg/DFGIntegerRangeOptimizationPhase.cpp

@@ -569 +569 @@
         switch (other.m_kind) {
         case Equal:
+            if (differenceOverflows<int>(otherEffectiveRight, thisRight))
+                return *this;
+
             // Return a version of *this that is Equal to other's constant.
             return Relationship(m_left, m_right, Equal, otherEffectiveRight - thisRight);