Changeset 284694 in webkit

Timestamp:

Oct 22, 2021, 11:03:34 AM (5 years ago)

Author:

commit-queue@webkit.org

Message:

Remove release assertion in MediaResourceClient::responseReceived
​https://bugs.webkit.org/show_bug.cgi?id=232121

Patch by Alex Christensen <​achristensen@webkit.org> on 2021-10-22
Reviewed by David Kilzer.

I tried and was unable to reproduce this, even with multipart responses which can call didReceiveResponse multiple times in the same load.
In any case, it's clear where the crash is and that this assertion can be hit. Not continuing with the response is better than crashing.
Keep the debug assertion because if it is hit, we want to notice.

• platform/network/cocoa/RangeResponseGenerator.mm:

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• platform/network/cocoa/RangeResponseGenerator.mm (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2021-10-22  Alex Christensen  <achristensen@webkit.org>
+
+        Remove release assertion in MediaResourceClient::responseReceived
+        https://bugs.webkit.org/show_bug.cgi?id=232121
+
+        Reviewed by David Kilzer.
+
+        I tried and was unable to reproduce this, even with multipart responses which can call didReceiveResponse multiple times in the same load.
+        In any case, it's clear where the crash is and that this assertion can be hit.  Not continuing with the response is better than crashing.
+        Keep the debug assertion because if it is hit, we want to notice.
+
+        * platform/network/cocoa/RangeResponseGenerator.mm:
+
 2021-10-22  Antti Koivisto  <antti@apple.com>
 

trunk/Source/WebCore/platform/network/cocoa/RangeResponseGenerator.mm

@@ -214 +214 @@
     void responseReceived(PlatformMediaResource&, const ResourceResponse&, CompletionHandler<void(ShouldContinuePolicyCheck)>&& completionHandler) final
     {
-        RELEASE_ASSERT_NOT_REACHED();
+        ASSERT_NOT_REACHED();
         completionHandler(ShouldContinuePolicyCheck::No);
     }