Changeset 284723 in webkit

Timestamp:

Oct 22, 2021, 3:53:43 PM (5 years ago)

Author:

Chris Dumez

Message:

Regression (r284610): [ iOS BigSur wk2 ] http/tests/security/window-opened-from-sandboxed-iframe-should-inherit-sandbox.html is failing
​https://bugs.webkit.org/show_bug.cgi?id=232151
<rdar://problem/84552682>

Reviewed by Ryan Haddad.

The test expects a CONSOLE message to get logged to indicate that a load was blocked.
Rely on internals.setConsoleMessageListener to wait for this CONSOLE message instead
of using a timer in order the address the flakiness.

• http/tests/security/window-opened-from-sandboxed-iframe-should-inherit-sandbox.html:
• platform/ios-wk2/TestExpectations:
• platform/mac-wk2/TestExpectations:

Location:

trunk/LayoutTests

Files:

• ChangeLog (modified) (1 diff)
• http/tests/security/window-opened-from-sandboxed-iframe-should-inherit-sandbox.html (modified) (1 diff)
• platform/ios-wk2/TestExpectations (modified) (1 diff)
• platform/mac-wk2/TestExpectations (modified) (2 diffs)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2021-10-22  Chris Dumez  <cdumez@apple.com>
+
+        Regression (r284610): [ iOS BigSur wk2 ] http/tests/security/window-opened-from-sandboxed-iframe-should-inherit-sandbox.html is failing
+        https://bugs.webkit.org/show_bug.cgi?id=232151
+        <rdar://problem/84552682>
+
+        Reviewed by Ryan Haddad.
+
+        The test expects a CONSOLE message to get logged to indicate that a load was blocked.
+        Rely on `internals.setConsoleMessageListener` to wait for this CONSOLE message instead
+        of using a timer in order the address the flakiness.
+
+        * http/tests/security/window-opened-from-sandboxed-iframe-should-inherit-sandbox.html:
+        * platform/ios-wk2/TestExpectations:
+        * platform/mac-wk2/TestExpectations:
+
 2021-10-22  Ryan Haddad  <ryanhaddad@apple.com>
 

trunk/LayoutTests/http/tests/security/window-opened-from-sandboxed-iframe-should-inherit-sandbox.html

@@ -26 +26 @@
         theLink.dispatchEvent(clickEvent);
 
-        setTimeout(wrapUp, 500);
+        var iframeContentWindow = document.getElementById("theIframe").contentWindow;
+        if (iframeContentWindow.internals) {
+            iframeContentWindow.internals.setConsoleMessageListener((msg) => {
+                setTimeout(wrapUp, 0);
+            });
+        } else
+            setTimeout(wrapUp, 1000);
     }
 </script>

trunk/LayoutTests/platform/ios-wk2/TestExpectations

@@ -2232 +2232 @@
 webkit.org/b/232120 imported/w3c/web-platform-tests/content-security-policy/script-src/script-src-multiple-policies-multiple-hashing-algorithms.html [ Pass Failure DumpJSConsoleLogInStdErr ]
 
-webkit.org/b/232151 http/tests/security/window-opened-from-sandboxed-iframe-should-inherit-sandbox.html [ Failure ]
-
 webkit.org/b/225528 http/wpt/fetch/fetch-response-body-stop-in-worker.html [ Pass Crash ]

trunk/LayoutTests/platform/mac-wk2/TestExpectations

@@ -1172 +1172 @@
 [ Mojave ] tiled-drawing/scrolling/fast-scroll-mainframe-zoom.html [ Pass Failure ]
 
-# <rdar://problem/61833992> REGRESSION: (20A267) http/tests/security/window-opened-from-sandboxed-iframe-should-inherit-sandbox.html
-[ BigSur+ ] http/tests/security/window-opened-from-sandboxed-iframe-should-inherit-sandbox.html [ Pass Failure ]
-
 # <rdar://problem/63626512> REGRESSION(20A279-20A291a): webrtc/simulcast-h264.html is a constant timeout
 webrtc/simulcast-h264.html [ Pass Timeout ]
@@ -1690 +1687 @@
 webkit.org/b/231780 [ Debug ] imported/w3c/web-platform-tests/webrtc/simulcast/basic.https.html [ Pass Failure ]
 
-webkit.org/b/232151 [ BigSur Debug ] http/tests/security/window-opened-from-sandboxed-iframe-should-inherit-sandbox.html [ Failure ]