Changeset 284730 in webkit

Timestamp:

Oct 22, 2021, 5:19:28 PM (5 years ago)

Author:

Chris Dumez

Message:

Preconnect to link's target on click
​https://bugs.webkit.org/show_bug.cgi?id=232147

Reviewed by Alex Christensen.

Preconnect to link's target on click, for reduced page load time. This is a confirmed
progression on some of our page load time benchmarks.

• html/HTMLAnchorElement.cpp:

(WebCore::HTMLAnchorElement::handleClick):

Location:

trunk/Source

Files:

• WebCore/ChangeLog (modified) (1 diff)
• WebCore/html/HTMLAnchorElement.cpp (modified) (2 diffs)
• WebKit/WebProcess/Network/WebLoaderStrategy.cpp (modified) (2 diffs)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2021-10-22  Chris Dumez  <cdumez@apple.com>
+
+        Preconnect to link's target on click
+        https://bugs.webkit.org/show_bug.cgi?id=232147
+
+        Reviewed by Alex Christensen.
+
+        Preconnect to link's target on click, for reduced page load time. This is a confirmed
+        progression on some of our page load time benchmarks.
+
+        * html/HTMLAnchorElement.cpp:
+        (WebCore::HTMLAnchorElement::handleClick):
+
 2021-10-22  Commit Queue  <commit-queue@webkit.org>
 

trunk/Source/WebCore/html/HTMLAnchorElement.cpp

@@ -41 +41 @@
 #include "HTMLPictureElement.h"
 #include "KeyboardEvent.h"
+#include "LoaderStrategy.h"
 #include "MouseEvent.h"
 #include "PingLoader.h"
 #include "PlatformMouseEvent.h"
+#include "PlatformStrategies.h"
 #include "PrivateClickMeasurement.h"
 #include "RegistrableDomain.h"
@@ -538 +540 @@
 
     sendPings(completedURL);
+
+    // Preconnect to the link's target for improved page load time.
+    if (completedURL.protocolIsInHTTPFamily()) {
+        auto storageCredentialsPolicy = frame->page() && frame->page()->canUseCredentialStorage() ? StoredCredentialsPolicy::Use : StoredCredentialsPolicy::DoNotUse;
+        platformStrategies()->loaderStrategy()->preconnectTo(frame->loader(), completedURL, storageCredentialsPolicy, nullptr);
+    }
 }
 

trunk/Source/WebKit/WebProcess/Network/WebLoaderStrategy.cpp

@@ -769 +769 @@
 void WebLoaderStrategy::preconnectTo(FrameLoader& frameLoader, const URL& url, StoredCredentialsPolicy storedCredentialsPolicy, PreconnectCompletionHandler&& completionHandler)
 {
-    ASSERT(completionHandler);
     auto* webFrameLoaderClient = toWebFrameLoaderClient(frameLoader.client());
     if (!webFrameLoaderClient) {
-        completionHandler(internalError(url));
+        if (completionHandler)
+            completionHandler(internalError(url));
         return;
     }
@@ -778 +778 @@
     auto* webPage = webFrame.page();
     if (!webPage) {
-        completionHandler(internalError(url));
+        if (completionHandler)
+            completionHandler(internalError(url));
         return;
     }