Changeset 284770 in webkit

Timestamp:

Oct 24, 2021, 5:04:12 PM (5 years ago)

Author:

Jean-Yves Avenard

Message:

Fix typo in MediaPlayerPrivateAVFoundationObjC::updateVideoTracks()
​https://bugs.webkit.org/show_bug.cgi?id=232194

Reviewed by Darin Adler.

Reset video tracks' properties when video tracks are changing rather
than the audio ones.

There should be no observable changes, resetting the audio track properties
would have been a no-op as AudioTrackPrivateAVFObjC is just a wrapper around
AVPlayerItemTrack and properties are kept in sync thorough playback.
Not calling resetPropertiesFromTrack on the video track wouldn't have mattered
as the operation is called when the track is constructed above in the
determineChangedTracksFromNewTracksAndOldItems method.
So this code only improves readability, and could be removed entirely.

• platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:

(WebCore::MediaPlayerPrivateAVFoundationObjC::updateVideoTracks):

• platform/graphics/avfoundation/objc/VideoTrackPrivateAVFObjC.h:

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm (modified) (1 diff)
• platform/graphics/avfoundation/objc/VideoTrackPrivateAVFObjC.h (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2021-10-24  Jean-Yves Avenard  <jya@apple.com>
+
+        Fix typo in MediaPlayerPrivateAVFoundationObjC::updateVideoTracks()
+        https://bugs.webkit.org/show_bug.cgi?id=232194
+
+        Reviewed by Darin Adler.
+
+        Reset video tracks' properties when video tracks are changing rather
+        than the audio ones.
+
+        There should be no observable changes, resetting the audio track properties
+        would have been a no-op as AudioTrackPrivateAVFObjC is just a wrapper around
+        AVPlayerItemTrack and properties are kept in sync thorough playback.
+        Not calling resetPropertiesFromTrack on the video track wouldn't have mattered
+        as the operation is called when the track is constructed above in the
+        determineChangedTracksFromNewTracksAndOldItems method.
+        So this code only improves readability, and could be removed entirely.
+
+        * platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
+        (WebCore::MediaPlayerPrivateAVFoundationObjC::updateVideoTracks):
+        * platform/graphics/avfoundation/objc/VideoTrackPrivateAVFObjC.h:
+
 2021-10-24  Tyler Wilcock  <tyler_w@apple.com>
 

trunk/Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm

@@ -2377 +2377 @@
         determineChangedTracksFromNewTracksAndOldItems(m_visualGroup.get(), m_videoTracks, Vector<String>(), &VideoTrackPrivateAVFObjC::create, player(), &MediaPlayer::removeVideoTrack, &MediaPlayer::addVideoTrack);
 
-    for (auto& track : m_audioTracks)
+    for (auto& track : m_videoTracks)
         track->resetPropertiesFromTrack();
 

trunk/Source/WebCore/platform/graphics/avfoundation/objc/VideoTrackPrivateAVFObjC.h

@@ -72 +72 @@
 
 private:
+    friend class MediaPlayerPrivateAVFoundationObjC;
     explicit VideoTrackPrivateAVFObjC(AVPlayerItemTrack*);
     explicit VideoTrackPrivateAVFObjC(AVAssetTrack*);