Changeset 284775 in webkit
- Timestamp:
- Oct 25, 2021, 4:07:20 AM (5 years ago)
- Location:
- trunk
- Files:
-
- 25 edited
-
Source/WebKit/ChangeLog (modified) (1 diff)
-
Source/WebKit/Scripts/webkit/messages_unittest.py (modified) (1 diff)
-
Source/WebKit/Scripts/webkit/model_unittest.py (modified) (3 diffs)
-
Source/WebKit/Scripts/webkit/parser_unittest.py (modified) (1 diff)
-
Tools/ChangeLog (modified) (1 diff)
-
Tools/Scripts/libraries/webkitcorepy/webkitcorepy/tests/task_pool_unittest.py (modified) (1 diff)
-
Tools/Scripts/webkitpy/common/attribute_saver_unittest.py (modified) (1 diff)
-
Tools/Scripts/webkitpy/common/checkout/scm/stub_repository_unittest.py (modified) (1 diff)
-
Tools/Scripts/webkitpy/layout_tests/models/test_configuration_unittest.py (modified) (1 diff)
-
Tools/Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py (modified) (1 diff)
-
Tools/Scripts/webkitpy/layout_tests/models/test_run_results_unittest.py (modified) (3 diffs)
-
Tools/Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py (modified) (1 diff)
-
Tools/Scripts/webkitpy/layout_tests/servers/http_server_unittest.py (modified) (1 diff)
-
Tools/Scripts/webkitpy/port/driver_unittest.py (modified) (2 diffs)
-
Tools/Scripts/webkitpy/port/gtk_unittest.py (modified) (3 diffs)
-
Tools/Scripts/webkitpy/style/checkers/test_expectations_unittest.py (modified) (1 diff)
-
Tools/Scripts/webkitpy/tool/steps/preparechangelog_unittest.py (modified) (1 diff)
-
Tools/Scripts/webkitpy/w3c/test_converter_unittest.py (modified) (1 diff)
-
Tools/Scripts/webkitpy/w3c/test_exporter_unittest.py (modified) (3 diffs)
-
Tools/Scripts/webkitpy/w3c/test_importer_unittest.py (modified) (1 diff)
-
Tools/Scripts/webkitpy/w3c/test_parser_unittest.py (modified) (1 diff)
-
Tools/Scripts/webkitpy/w3c/wpt_runner_unittest.py (modified) (3 diffs)
-
Tools/Scripts/webkitpy/xcode/device_type_unittest.py (modified) (1 diff)
-
Tools/Scripts/webkitpy/xcode/sdk_unittest.py (modified) (1 diff)
-
Tools/Scripts/webkitpy/xcode/simulated_device_unittest.py (modified) (6 diffs)
Legend:
- Unmodified
- Added
- Removed
-
trunk/Source/WebKit/ChangeLog
r284768 r284775 1 2021-10-25 Sam Sneddon <gsnedders@apple.com> 2 3 [Python] rename assertEquals/assertNotEquals 4 https://bugs.webkit.org/show_bug.cgi?id=232214 5 6 Reviewed by Alexey Proskuryakov. 7 8 This is assert(Not)?Equals -> assert(\1)Equal 9 10 Python 3.11 (currently CPython main branch) removes the deprecated 11 aliases assertEquals/assertNotEquals. These have long been deprecated, 12 and the modern names exist all the way back to Python 2.7, hence there's 13 no reason not to switch. 14 15 * Scripts/webkit/messages_unittest.py: 16 (GeneratedFileContentsTest.assertGeneratedFileContentsEqual): 17 * Scripts/webkit/model_unittest.py: 18 * Scripts/webkit/parser_unittest.py: 19 (ParsingTest.check_message): 20 (ParsingTest.test_receiver): 21 1 22 2021-10-24 Wenson Hsieh <wenson_hsieh@apple.com> 2 23 -
trunk/Source/WebKit/Scripts/webkit/messages_unittest.py
r284096 r284775 85 85 86 86 for index, actual_line in enumerate(actual_line_list): 87 self.assertEqual s(actual_line, expected_line_list[index])87 self.assertEqual(actual_line, expected_line_list[index]) 88 88 89 self.assertEqual s(len(actual_line_list), len(expected_line_list))89 self.assertEqual(len(actual_line_list), len(expected_line_list)) 90 90 except Exception: 91 91 sys.stderr.write('In expected file %s\n' % expected_file_name) -
trunk/Source/WebKit/Scripts/webkit/model_unittest.py
r284096 r284775 47 47 }""" 48 48 receiver = parser.parse(StringIO(contents)) 49 self.assertEqual s(receiver.name, 'WebPage')50 self.assertEqual s(receiver.messages[0].name, 'LoadURL')49 self.assertEqual(receiver.name, 'WebPage') 50 self.assertEqual(receiver.messages[0].name, 'LoadURL') 51 51 52 52 other_contents = """ … … 57 57 58 58 other_receiver = parser.parse(StringIO(other_contents)) 59 self.assertEqual s(other_receiver.name, 'WebPage')60 self.assertEqual s(other_receiver.messages[0].name, 'LoadURL')61 self.assertEqual s(other_receiver.messages[1].name, 'LoadURL2')59 self.assertEqual(other_receiver.name, 'WebPage') 60 self.assertEqual(other_receiver.messages[0].name, 'LoadURL') 61 self.assertEqual(other_receiver.messages[1].name, 'LoadURL2') 62 62 errors = model.check_global_model_inputs([receiver, other_receiver]) 63 self.assertEqual s(len(errors), 1)63 self.assertEqual(len(errors), 1) 64 64 self.assertTrue("Duplicate" in errors[0]) 65 65 … … 75 75 }""" 76 76 receiver = parser.parse(StringIO(contents)) 77 self.assertEqual s(receiver.name, 'WebPage')78 self.assertEqual s(receiver.messages[0].name, 'LoadURL')77 self.assertEqual(receiver.name, 'WebPage') 78 self.assertEqual(receiver.messages[0].name, 'LoadURL') 79 79 errors = model.check_global_model_inputs([receiver]) 80 self.assertEqual s(len(errors), 1)80 self.assertEqual(len(errors), 1) 81 81 self.assertTrue("attribute mismatch" in errors[0]) 82 82 -
trunk/Source/WebKit/Scripts/webkit/parser_unittest.py
r284096 r284775 317 317 318 318 def check_message(self, message, expected_message): 319 self.assertEqual s(message.name, expected_message['name'])320 self.assertEqual s(len(message.parameters), len(expected_message['parameters']))319 self.assertEqual(message.name, expected_message['name']) 320 self.assertEqual(len(message.parameters), len(expected_message['parameters'])) 321 321 for index, parameter in enumerate(message.parameters): 322 322 expected_parameter = expected_message['parameters'][index] 323 self.assertEqual s(parameter.type, expected_parameter[0])324 self.assertEqual s(parameter.name, expected_parameter[1])323 self.assertEqual(parameter.type, expected_parameter[0]) 324 self.assertEqual(parameter.name, expected_parameter[1]) 325 325 if len(expected_parameter) > 2: 326 self.assertEqual s(parameter.attributes, frozenset(expected_parameter[2]))326 self.assertEqual(parameter.attributes, frozenset(expected_parameter[2])) 327 327 for attribute in expected_parameter[2]: 328 328 self.assertTrue(parameter.has_attribute(attribute)) 329 329 else: 330 self.assertEqual s(parameter.attributes, frozenset())330 self.assertEqual(parameter.attributes, frozenset()) 331 331 if message.reply_parameters is not None: 332 332 for index, parameter in enumerate(message.reply_parameters): 333 self.assertEqual s(parameter.type, expected_message['reply_parameters'][index][0])334 self.assertEqual s(parameter.name, expected_message['reply_parameters'][index][1])333 self.assertEqual(parameter.type, expected_message['reply_parameters'][index][0]) 334 self.assertEqual(parameter.name, expected_message['reply_parameters'][index][1]) 335 335 else: 336 336 self.assertFalse('reply_parameters' in expected_message) 337 self.assertEqual s(message.condition, expected_message['conditions'])337 self.assertEqual(message.condition, expected_message['conditions']) 338 338 339 339 def test_receiver(self): 340 340 """Receiver should be parsed as expected""" 341 341 for receiver, expected_model in zip(self.receivers, _parsing_test_cases): 342 self.assertEqual s(receiver.name, expected_model['name'])343 self.assertEqual s(receiver.condition, expected_model['conditions'])344 self.assertEqual s(len(receiver.messages), len(expected_model['messages']))342 self.assertEqual(receiver.name, expected_model['name']) 343 self.assertEqual(receiver.condition, expected_model['conditions']) 344 self.assertEqual(len(receiver.messages), len(expected_model['messages'])) 345 345 for index, message in enumerate(receiver.messages): 346 346 self.check_message(message, expected_model['messages'][index]) -
trunk/Tools/ChangeLog
r284765 r284775 1 2021-10-25 Sam Sneddon <gsnedders@apple.com> 2 3 [Python] rename assertEquals/assertNotEquals 4 https://bugs.webkit.org/show_bug.cgi?id=232214 5 6 Reviewed by Alexey Proskuryakov. 7 8 This is assert(Not)?Equals -> assert(\1)Equal 9 10 Python 3.11 (currently CPython main branch) removes the deprecated 11 aliases assertEquals/assertNotEquals. These have long been deprecated, 12 and the modern names exist all the way back to Python 2.7, hence there's 13 no reason not to switch. 14 15 * Scripts/libraries/webkitcorepy/webkitcorepy/tests/task_pool_unittest.py: 16 (TaskPoolUnittest.test_multiple): 17 * Scripts/webkitpy/common/attribute_saver_unittest.py: 18 (AttributeSaverTest.test_class): 19 (AttributeSaverTest.test_normal_default): 20 (AttributeSaverTest.test_normal_value): 21 (AttributeSaverTest.test_normal_value_on_exception): 22 (AttributeSaverTest.test_normal_value_on_normal_exit): 23 (AttributeSaverTest.test_normal_value_with_finally_on_exception): 24 (AttributeSaverTest.test_normal_value_with_finally_on_normal_exit): 25 (AttributeSaverTest.test_normal_value_with_else_on_exception): 26 (AttributeSaverTest.test_normal_value_with_else_on_normal_exit): 27 * Scripts/webkitpy/common/checkout/scm/stub_repository_unittest.py: 28 (StubRepositoryTest.test_find_checkout_root): 29 * Scripts/webkitpy/layout_tests/models/test_configuration_unittest.py: 30 (TestConfigurationTest.test_eq): 31 * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py: 32 (MiscTests.test_parse_warnings_are_logged_if_not_in_lint_mode): 33 * Scripts/webkitpy/layout_tests/models/test_run_results_unittest.py: 34 (SummarizedResultsTest.test_svn_revision_exists): 35 (SummarizedResultsTest.test_svn_revision): 36 (SummarizedResultsTest.test_svn_revision_git): 37 * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py: 38 (RunTest.test_tests_options): 39 * Scripts/webkitpy/layout_tests/servers/http_server_unittest.py: 40 (TestHttpServer.test_win32_start_and_stop): 41 * Scripts/webkitpy/port/driver_unittest.py: 42 * Scripts/webkitpy/port/gtk_unittest.py: 43 (GtkPortTest.test_gtk4_expectations_binary_only): 44 (GtkPortTest.test_gtk3_expectations_binary_only): 45 (GtkPortTest.test_gtk_expectations_both_binaries): 46 * Scripts/webkitpy/style/checkers/test_expectations_unittest.py: 47 (TestExpectationsTestCase.assert_lines_lint): 48 * Scripts/webkitpy/tool/steps/preparechangelog_unittest.py: 49 * Scripts/webkitpy/w3c/test_converter_unittest.py: 50 (verify_test_harness_paths): 51 * Scripts/webkitpy/w3c/test_exporter_unittest.py: 52 (TestExporterTest.test_export): 53 (TestExporterTest.test_export_with_specific_branch): 54 * Scripts/webkitpy/w3c/test_importer_unittest.py: 55 * Scripts/webkitpy/w3c/test_parser_unittest.py: 56 * Scripts/webkitpy/w3c/wpt_runner_unittest.py: 57 (WPTRunnerTest.MockSpawnWPT.__call__): 58 (WPTRunnerTest.test_prepare_wpt_checkout): 59 (WPTRunnerTest.test_prepare_wpt_checkout_specified_path): 60 * Scripts/webkitpy/xcode/device_type_unittest.py: 61 (DeviceTypeTest.test_iphone_initialization): 62 (DeviceTypeTest.test_ipad_initialization): 63 (DeviceTypeTest.test_generic_ios_device): 64 (DeviceTypeTest.test_watch_initialization): 65 (DeviceTypeTest.test_tv_initialization): 66 * Scripts/webkitpy/xcode/sdk_unittest.py: 67 (SDKTest.test_iphoneos): 68 (SDKTest.test_iphonesim): 69 (SDKTest.test_macos): 70 (SDKTest.test_appletvos): 71 (SDKTest.test_appletvsim): 72 (SDKTest.test_watchos): 73 (SDKTest.test_watchsimulator): 74 (SDKTest.test_prodos): 75 * Scripts/webkitpy/xcode/simulated_device_unittest.py: 76 1 77 2021-10-24 Arcady Goldmints-Orlov <agoldmints@igalia.com> 2 78 -
trunk/Tools/Scripts/libraries/webkitcorepy/webkitcorepy/tests/task_pool_unittest.py
r281448 r284775 111 111 112 112 lines = captured.stdout.getvalue().splitlines() 113 self.assertEqual s(sorted(lines), ['action({})'.format(character) for character in self.alphabet])113 self.assertEqual(sorted(lines), ['action({})'.format(character) for character in self.alphabet]) 114 114 self.assertEqual( 115 115 sorted(captured.webkitcorepy.log.getvalue().splitlines()), -
trunk/Tools/Scripts/webkitpy/common/attribute_saver_unittest.py
r245364 r284775 39 39 def test_class(self): 40 40 obj = self.SimpleTestClass() 41 self.assertEqual s(obj.value, 0)41 self.assertEqual(obj.value, 0) 42 42 43 43 def test_normal_default(self): 44 44 obj = self.SimpleTestClass() 45 self.assertEqual s(obj.value, 0)45 self.assertEqual(obj.value, 0) 46 46 with AttributeSaver(obj, "value"): 47 self.assertEqual s(obj.value, None)48 self.assertEqual s(obj.value, 0)47 self.assertEqual(obj.value, None) 48 self.assertEqual(obj.value, 0) 49 49 50 50 def test_normal_value(self): 51 51 obj = self.SimpleTestClass() 52 self.assertEqual s(obj.value, 0)52 self.assertEqual(obj.value, 0) 53 53 with AttributeSaver(obj, "value", 1): 54 self.assertEqual s(obj.value, 1)55 self.assertEqual s(obj.value, 0)54 self.assertEqual(obj.value, 1) 55 self.assertEqual(obj.value, 0) 56 56 57 57 def test_normal_value_on_exception(self): 58 58 with self.assertRaises(RuntimeError): 59 59 obj = self.SimpleTestClass() 60 self.assertEqual s(obj.value, 0)60 self.assertEqual(obj.value, 0) 61 61 try: 62 62 with AttributeSaver(obj, "value", 1): 63 self.assertEqual s(obj.value, 1)63 self.assertEqual(obj.value, 1) 64 64 raise RuntimeError() 65 65 except: 66 self.assertEqual s(obj.value, 0)66 self.assertEqual(obj.value, 0) 67 67 raise 68 self.assertEqual s(obj.value, 0)68 self.assertEqual(obj.value, 0) 69 69 70 70 def test_normal_value_on_normal_exit(self): 71 71 obj = self.SimpleTestClass() 72 self.assertEqual s(obj.value, 0)72 self.assertEqual(obj.value, 0) 73 73 try: 74 74 with AttributeSaver(obj, "value", 1): 75 self.assertEqual s(obj.value, 1)75 self.assertEqual(obj.value, 1) 76 76 except: 77 self.assertEqual s(obj.value, 0)77 self.assertEqual(obj.value, 0) 78 78 raise 79 self.assertEqual s(obj.value, 0)79 self.assertEqual(obj.value, 0) 80 80 81 81 def test_normal_value_with_finally_on_exception(self): 82 82 with self.assertRaises(RuntimeError): 83 83 obj = self.SimpleTestClass() 84 self.assertEqual s(obj.value, 0)84 self.assertEqual(obj.value, 0) 85 85 try: 86 86 with AttributeSaver(obj, "value", 1): 87 self.assertEqual s(obj.value, 1)87 self.assertEqual(obj.value, 1) 88 88 raise RuntimeError() 89 89 finally: 90 self.assertEqual s(obj.value, 0)91 self.assertEqual s(obj.value, 0)90 self.assertEqual(obj.value, 0) 91 self.assertEqual(obj.value, 0) 92 92 93 93 def test_normal_value_with_finally_on_normal_exit(self): 94 94 obj = self.SimpleTestClass() 95 self.assertEqual s(obj.value, 0)95 self.assertEqual(obj.value, 0) 96 96 try: 97 97 with AttributeSaver(obj, "value", 1): 98 self.assertEqual s(obj.value, 1)98 self.assertEqual(obj.value, 1) 99 99 finally: 100 self.assertEqual s(obj.value, 0)101 self.assertEqual s(obj.value, 0)100 self.assertEqual(obj.value, 0) 101 self.assertEqual(obj.value, 0) 102 102 103 103 def test_normal_value_with_else_on_exception(self): 104 104 with self.assertRaises(RuntimeError): 105 105 obj = self.SimpleTestClass() 106 self.assertEqual s(obj.value, 0)106 self.assertEqual(obj.value, 0) 107 107 try: 108 108 with AttributeSaver(obj, "value", 1): 109 self.assertEqual s(obj.value, 1)109 self.assertEqual(obj.value, 1) 110 110 raise RuntimeError() 111 111 except IOError: 112 112 self.assertFalse(True) 113 113 else: 114 self.assertEqual s(obj.value, 0)115 self.assertEqual s(obj.value, 0)114 self.assertEqual(obj.value, 0) 115 self.assertEqual(obj.value, 0) 116 116 117 117 def test_normal_value_with_else_on_normal_exit(self): 118 118 obj = self.SimpleTestClass() 119 self.assertEqual s(obj.value, 0)119 self.assertEqual(obj.value, 0) 120 120 try: 121 121 with AttributeSaver(obj, "value", 1): 122 self.assertEqual s(obj.value, 1)122 self.assertEqual(obj.value, 1) 123 123 except IOError: 124 124 self.assertFalse(True) 125 125 else: 126 self.assertEqual s(obj.value, 0)127 self.assertEqual s(obj.value, 0)126 self.assertEqual(obj.value, 0) 127 self.assertEqual(obj.value, 0) -
trunk/Tools/Scripts/webkitpy/common/checkout/scm/stub_repository_unittest.py
r257796 r284775 68 68 host = StubRepositoryTest.mock_host_for_stub_repository() 69 69 repository = StubRepository(cwd=host.filesystem.getcwd(), filesystem=host.filesystem, executive=host.executive) 70 self.assertEqual s(repository.find_checkout_root(path=host.filesystem.join('TestDirectory', 'TestDirectory2', 'TestDirectory3')), host.filesystem.join(host.filesystem.getcwd(), 'TestDirectory', 'TestDirectory2'))70 self.assertEqual(repository.find_checkout_root(path=host.filesystem.join('TestDirectory', 'TestDirectory2', 'TestDirectory3')), host.filesystem.join(host.filesystem.getcwd(), 'TestDirectory', 'TestDirectory2')) 71 71 72 72 def test_find_checkout_root_failure(self): -
trunk/Tools/Scripts/webkitpy/layout_tests/models/test_configuration_unittest.py
r174136 r284775 87 87 def test_eq(self): 88 88 self.assertEqual(TestConfiguration('xp', 'x86', 'release'), TestConfiguration('xp', 'x86', 'release')) 89 self.assertNotEqual s(TestConfiguration('xp', 'x86', 'release'), TestConfiguration('xp', 'x86', 'debug'))89 self.assertNotEqual(TestConfiguration('xp', 'x86', 'release'), TestConfiguration('xp', 'x86', 'debug')) 90 90 91 91 def test_values(self): -
trunk/Tools/Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py
r265883 r284775 200 200 with OutputCapture() as captured: 201 201 self.parse_exp('-- this should be a syntax error', is_lint_mode=False) 202 self.assertNotEqual s(captured.root.log.getvalue(), '')202 self.assertNotEqual(captured.root.log.getvalue(), '') 203 203 204 204 def test_error_on_different_platform(self): -
trunk/Tools/Scripts/webkitpy/layout_tests/models/test_run_results_unittest.py
r279445 r284775 159 159 self.port._options.builder_name = 'dummy builder' 160 160 summary = summarized_results(self.port, expected=False, passing=False, flaky=False) 161 self.assertNotEqual s(summary['revision'], '')161 self.assertNotEqual(summary['revision'], '') 162 162 163 163 def test_svn_revision(self): … … 165 165 self.port._options.builder_name = 'dummy builder' 166 166 summary = summarized_results(self.port, expected=False, passing=False, flaky=False) 167 self.assertEqual s(summary['revision'], '6')167 self.assertEqual(summary['revision'], '6') 168 168 169 169 def test_svn_revision_git(self): … … 171 171 self.port._options.builder_name = 'dummy builder' 172 172 summary = summarized_results(self.port, expected=False, passing=False, flaky=False) 173 self.assertEqual s(summary['revision'], '9')173 self.assertEqual(summary['revision'], '9') 174 174 175 175 def test_summarized_results_wontfix(self): -
trunk/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py
r281340 r284775 823 823 'failures/unexpected/timeout.html'], 824 824 host=host) 825 self.assertEqual s(details.initial_results.slow_tests,825 self.assertEqual(details.initial_results.slow_tests, 826 826 {'failures/unexpected/timeout.html'}) 827 self.assertEqual s(details.retry_results.slow_tests,827 self.assertEqual(details.retry_results.slow_tests, 828 828 {'failures/unexpected/timeout.html'}) 829 829 -
trunk/Tools/Scripts/webkitpy/layout_tests/servers/http_server_unittest.py
r214558 r284775 89 89 90 90 server.start() 91 self.assertNotEqual s(host.executive.calls, [])91 self.assertNotEqual(host.executive.calls, []) 92 92 93 93 def wait_for_action(action): -
trunk/Tools/Scripts/webkitpy/port/driver_unittest.py
r276559 r284775 299 299 driver.start(True, []) 300 300 last_tmpdir = port._filesystem.last_tmpdir 301 self.assertNotEqual s(last_tmpdir, None)301 self.assertNotEqual(last_tmpdir, None) 302 302 driver.stop() 303 303 self.assertFalse(port._filesystem.isdir(last_tmpdir)) … … 402 402 driver.start(True, []) 403 403 environ_driver = driver._setup_environ_for_test() 404 self.assertNotEqual s(environ_driver['HOME'], environ_user['HOME'])404 self.assertNotEqual(environ_driver['HOME'], environ_user['HOME']) 405 405 self.assertIn(str(driver._driver_tempdir), environ_driver['HOME']) 406 406 self.assertNotIn(str(driver._driver_tempdir), environ_user['HOME']) -
trunk/Tools/Scripts/webkitpy/port/gtk_unittest.py
r275513 r284775 102 102 }) 103 103 with OutputCapture() as _: 104 self.assertEqual s(port.expectations_files(),104 self.assertEqual(port.expectations_files(), 105 105 ['/mock-checkout/LayoutTests/TestExpectations', 106 106 '/mock-checkout/LayoutTests/platform/wk2/TestExpectations', … … 116 116 117 117 with OutputCapture() as _: 118 self.assertEqual s(port.expectations_files(),118 self.assertEqual(port.expectations_files(), 119 119 ['/mock-checkout/LayoutTests/TestExpectations', 120 120 '/mock-checkout/LayoutTests/platform/wk2/TestExpectations', … … 130 130 131 131 with OutputCapture() as captured: 132 self.assertEqual s(port.expectations_files(),132 self.assertEqual(port.expectations_files(), 133 133 ['/mock-checkout/LayoutTests/TestExpectations', 134 134 '/mock-checkout/LayoutTests/platform/wk2/TestExpectations', 135 135 '/mock-checkout/LayoutTests/platform/glib/TestExpectations', 136 136 '/mock-checkout/LayoutTests/platform/gtk/TestExpectations']) 137 self.assertEqual s(captured.root.log.getvalue(), 'Multiple WebKit2GTK libraries found. Skipping GTK4 detection.\n')137 self.assertEqual(captured.root.log.getvalue(), 'Multiple WebKit2GTK libraries found. Skipping GTK4 detection.\n') -
trunk/Tools/Scripts/webkitpy/style/checkers/test_expectations_unittest.py
r277490 r284775 96 96 self.assertEqual(expected_output, self._error_collector.get_errors()) 97 97 else: 98 self.assertNotEqual s('', self._error_collector.get_errors())98 self.assertNotEqual('', self._error_collector.get_errors()) 99 99 100 100 # Note that a patch might change a line that introduces errors elsewhere, but we -
trunk/Tools/Scripts/webkitpy/tool/steps/preparechangelog_unittest.py
r265883 r284775 116 116 step._resolve_existing_entry(path) 117 117 actual_output = step._tool.filesystem.read_text_file(path) 118 self.assertEqual s(actual_output, end_file)118 self.assertEqual(actual_output, end_file) 119 119 120 120 def test_ensure_bug_url(self): -
trunk/Tools/Scripts/webkitpy/w3c/test_converter_unittest.py
r276128 r284775 369 369 # Verify the original paths are gone, and the new paths are present. 370 370 orig_path_pattern = re.compile('\"/resources/testharness') 371 self.assertEqual s(len(converted.findAll(src=orig_path_pattern)), 0, 'testharness src path was not converted')372 self.assertEqual s(len(converted.findAll(href=orig_path_pattern)), 0, 'testharness href path was not converted')371 self.assertEqual(len(converted.findAll(src=orig_path_pattern)), 0, 'testharness src path was not converted') 372 self.assertEqual(len(converted.findAll(href=orig_path_pattern)), 0, 'testharness href path was not converted') 373 373 374 374 new_relpath = os.path.relpath(resources_dir, test_path).replace(os.sep, '/') 375 375 relpath_pattern = re.compile(new_relpath) 376 self.assertEqual s(len(converted.findAll(src=relpath_pattern)), num_src_paths, 'testharness src relative path not correct')377 self.assertEqual s(len(converted.findAll(href=relpath_pattern)), num_href_paths, 'testharness href relative path not correct')376 self.assertEqual(len(converted.findAll(src=relpath_pattern)), num_src_paths, 'testharness src relative path not correct') 377 self.assertEqual(len(converted.findAll(href=relpath_pattern)), num_href_paths, 'testharness href relative path not correct') 378 378 379 379 def verify_prefixed_properties(self, converted, test_properties): -
trunk/Tools/Scripts/webkitpy/w3c/test_exporter_unittest.py
r253587 r284775 131 131 exporter = WebPlatformTestExporter(host, options, TestExporterTest.MockGit, TestExporterTest.MockBugzilla, MockWPTGitHub, TestExporterTest.MockWPTLinter) 132 132 exporter.do_export() 133 self.assertEqual s(exporter._github.calls, ['create_pr', 'add_label "webkit-export"'])133 self.assertEqual(exporter._github.calls, ['create_pr', 'add_label "webkit-export"']) 134 134 self.assertTrue('WebKit export' in exporter._github.pull_requests_created[0][1]) 135 self.assertEqual s(exporter._git.calls, [135 self.assertEqual(exporter._git.calls, [ 136 136 '/mock-checkout/WebKitBuild/w3c-tests/web-platform-tests', 137 137 'fetch', … … 149 149 'checkout master', 150 150 'reset hard origin/master']) 151 self.assertEqual s(exporter._bugzilla.calls, [151 self.assertEqual(exporter._bugzilla.calls, [ 152 152 'fetch bug 1234', 153 153 'Append https://github.com/web-platform-tests/wpt/pull/5678 to see also list', 154 154 'post comment to bug 1234 : Submitted web-platform-tests pull request: https://github.com/web-platform-tests/wpt/pull/5678']) 155 self.assertEqual s(mock_linter.calls, ['/mock-checkout/WebKitBuild/w3c-tests/web-platform-tests', 'lint'])155 self.assertEqual(mock_linter.calls, ['/mock-checkout/WebKitBuild/w3c-tests/web-platform-tests', 'lint']) 156 156 157 157 def test_export_with_specific_branch(self): … … 161 161 exporter = WebPlatformTestExporter(host, options, TestExporterTest.MockGit, TestExporterTest.MockBugzilla, MockWPTGitHub, TestExporterTest.MockWPTLinter) 162 162 exporter.do_export() 163 self.assertEqual s(exporter._git.calls, [163 self.assertEqual(exporter._git.calls, [ 164 164 '/mock-checkout/WebKitBuild/w3c-tests/web-platform-tests', 165 165 'fetch', -
trunk/Tools/Scripts/webkitpy/w3c/test_importer_unittest.py
r283230 r284775 346 346 fs = self.import_downloaded_tests(['--no-fetch', '--import-all', '-d', 'w3c'], FAKE_FILES) 347 347 self.assertFalse(fs.exists('/mock-checkout/LayoutTests/w3c/web-platform-tests/t/new-manual.html')) 348 self.assertEqual s(tests_options, fs.read_text_file('/mock-checkout/LayoutTests/tests-options.json'))348 self.assertEqual(tests_options, fs.read_text_file('/mock-checkout/LayoutTests/tests-options.json')) 349 349 350 350 def test_webkit_test_runner_options(self): -
trunk/Tools/Scripts/webkitpy/w3c/test_parser_unittest.py
r276434 r284775 134 134 self.assertTrue(test_info['reference'].startswith(test_path), 'reference path is not correct') 135 135 self.assertTrue('reference_support_info' in test_info.keys(), 'there should be reference_support_info for this test') 136 self.assertEqual s(len(test_info['reference_support_info']['files']), 4, 'there should be 4 support files in this reference')136 self.assertEqual(len(test_info['reference_support_info']['files']), 4, 'there should be 4 support files in this reference') 137 137 self.assertFalse('jstest' in test_info.keys(), 'test should not have been analyzed as a jstest') 138 138 -
trunk/Tools/Scripts/webkitpy/w3c/wpt_runner_unittest.py
r250286 r284775 128 128 129 129 def __call__(self, script_name, wpt_checkout, wpt_args): 130 self._test_case.assertEqual s(script_name, "wptrunner_unittest")131 self._test_case.assertEqual s(wpt_checkout, self._expected_wpt_checkout)132 self._test_case.assertEqual s(wpt_args, self._expected_wpt_args)130 self._test_case.assertEqual(script_name, "wptrunner_unittest") 131 self._test_case.assertEqual(wpt_checkout, self._expected_wpt_checkout) 132 self._test_case.assertEqual(wpt_args, self._expected_wpt_args) 133 133 134 134 class TestInstance(object): … … 155 155 156 156 expected_wpt_checkout = "/mock-checkout/WebKitBuild/w3c-tests/web-platform-tests" 157 self.assertEqual s(instance.runner._options.wpt_checkout, expected_wpt_checkout)157 self.assertEqual(instance.runner._options.wpt_checkout, expected_wpt_checkout) 158 158 self.assertTrue(instance.host.filesystem.isdir(expected_wpt_checkout)) 159 159 … … 167 167 168 168 self.assertTrue(instance.runner.prepare_wpt_checkout()) 169 self.assertEqual s(instance.runner._options.wpt_checkout, specified_wpt_checkout)169 self.assertEqual(instance.runner._options.wpt_checkout, specified_wpt_checkout) 170 170 171 171 def test_run(self): -
trunk/Tools/Scripts/webkitpy/xcode/device_type_unittest.py
r279496 r284775 32 32 def test_iphone_initialization(self): 33 33 type = DeviceType(hardware_family='iPhone') 34 self.assertEqual s('iPhone', type.hardware_family)35 self.assertEqual s(None, type.hardware_type)36 self.assertEqual s('iOS', type.software_variant)37 self.assertEqual s(None, type.software_version)34 self.assertEqual('iPhone', type.hardware_family) 35 self.assertEqual(None, type.hardware_type) 36 self.assertEqual('iOS', type.software_variant) 37 self.assertEqual(None, type.software_version) 38 38 self.assertEqual('iPhone running iOS', str(type)) 39 39 40 40 type = DeviceType('iPhone', '6s', Version(11)) 41 self.assertEqual s('iPhone', type.hardware_family)42 self.assertEqual s('6s', type.hardware_type)43 self.assertEqual s('iOS', type.software_variant)44 self.assertEqual s(Version(11), type.software_version)41 self.assertEqual('iPhone', type.hardware_family) 42 self.assertEqual('6s', type.hardware_type) 43 self.assertEqual('iOS', type.software_variant) 44 self.assertEqual(Version(11), type.software_version) 45 45 self.assertEqual('iPhone 6s running iOS 11', str(type)) 46 46 47 47 def test_ipad_initialization(self): 48 48 type = DeviceType(hardware_family='iPad') 49 self.assertEqual s('iPad', type.hardware_family)50 self.assertEqual s(None, type.hardware_type)51 self.assertEqual s('iOS', type.software_variant)52 self.assertEqual s(None, type.software_version)49 self.assertEqual('iPad', type.hardware_family) 50 self.assertEqual(None, type.hardware_type) 51 self.assertEqual('iOS', type.software_variant) 52 self.assertEqual(None, type.software_version) 53 53 self.assertEqual('iPad running iOS', str(type)) 54 54 55 55 type = DeviceType('iPad', 'Air 2', Version(11)) 56 self.assertEqual s('iPad', type.hardware_family)57 self.assertEqual s('Air 2', type.hardware_type)58 self.assertEqual s('iOS', type.software_variant)59 self.assertEqual s(Version(11), type.software_version)56 self.assertEqual('iPad', type.hardware_family) 57 self.assertEqual('Air 2', type.hardware_type) 58 self.assertEqual('iOS', type.software_variant) 59 self.assertEqual(Version(11), type.software_version) 60 60 self.assertEqual('iPad Air 2 running iOS 11', str(type)) 61 61 62 62 def test_generic_ios_device(self): 63 63 type = DeviceType(software_variant='iOS') 64 self.assertEqual s(None, type.hardware_family)65 self.assertEqual s(None, type.hardware_type)66 self.assertEqual s('iOS', type.software_variant)67 self.assertEqual s(None, type.software_version)64 self.assertEqual(None, type.hardware_family) 65 self.assertEqual(None, type.hardware_type) 66 self.assertEqual('iOS', type.software_variant) 67 self.assertEqual(None, type.software_version) 68 68 self.assertEqual('Device running iOS', str(type)) 69 69 70 70 def test_watch_initialization(self): 71 71 type = DeviceType(hardware_family='Watch') 72 self.assertEqual s('Apple Watch', type.hardware_family)73 self.assertEqual s(None, type.hardware_type)74 self.assertEqual s('watchOS', type.software_variant)75 self.assertEqual s(None, type.software_version)72 self.assertEqual('Apple Watch', type.hardware_family) 73 self.assertEqual(None, type.hardware_type) 74 self.assertEqual('watchOS', type.software_variant) 75 self.assertEqual(None, type.software_version) 76 76 self.assertEqual('Apple Watch running watchOS', str(type)) 77 77 78 78 type = DeviceType('Apple Watch', 'Series 2 - 42mm', Version(4)) 79 self.assertEqual s('Apple Watch', type.hardware_family)80 self.assertEqual s('Series 2 - 42mm', type.hardware_type)81 self.assertEqual s('watchOS', type.software_variant)82 self.assertEqual s(Version(4), type.software_version)79 self.assertEqual('Apple Watch', type.hardware_family) 80 self.assertEqual('Series 2 - 42mm', type.hardware_type) 81 self.assertEqual('watchOS', type.software_variant) 82 self.assertEqual(Version(4), type.software_version) 83 83 self.assertEqual('Apple Watch Series 2 - 42mm running watchOS 4', str(type)) 84 84 85 85 def test_tv_initialization(self): 86 86 type = DeviceType(hardware_family='TV') 87 self.assertEqual s('Apple TV', type.hardware_family)88 self.assertEqual s(None, type.hardware_type)89 self.assertEqual s('tvOS', type.software_variant)90 self.assertEqual s(None, type.software_version)87 self.assertEqual('Apple TV', type.hardware_family) 88 self.assertEqual(None, type.hardware_type) 89 self.assertEqual('tvOS', type.software_variant) 90 self.assertEqual(None, type.software_version) 91 91 self.assertEqual('Apple TV running tvOS', str(type)) 92 92 93 93 type = DeviceType('Apple TV', '4K', Version(11)) 94 self.assertEqual s('Apple TV', type.hardware_family)95 self.assertEqual s('4K', type.hardware_type)96 self.assertEqual s('tvOS', type.software_variant)97 self.assertEqual s(Version(11), type.software_version)94 self.assertEqual('Apple TV', type.hardware_family) 95 self.assertEqual('4K', type.hardware_type) 96 self.assertEqual('tvOS', type.software_variant) 97 self.assertEqual(Version(11), type.software_version) 98 98 self.assertEqual('Apple TV 4K running tvOS 11', str(type)) 99 99 -
trunk/Tools/Scripts/webkitpy/xcode/sdk_unittest.py
r245364 r284775 73 73 def test_iphoneos(self): 74 74 preferred_sdk = sdk.SDK.get_preferred_sdk_for_platform("iphoneos", self.executive) 75 self.assertEqual s("iphoneos", preferred_sdk.platform)76 self.assertEqual s("12.0", preferred_sdk.version)75 self.assertEqual("iphoneos", preferred_sdk.platform) 76 self.assertEqual("12.0", preferred_sdk.version) 77 77 self.assertTrue(preferred_sdk.internal) 78 78 79 79 def test_iphonesim(self): 80 80 preferred_sdk = sdk.SDK.get_preferred_sdk_for_platform("iphonesimulator", self.executive) 81 self.assertEqual s("iphonesimulator", preferred_sdk.platform)82 self.assertEqual s("12.0", preferred_sdk.version)81 self.assertEqual("iphonesimulator", preferred_sdk.platform) 82 self.assertEqual("12.0", preferred_sdk.version) 83 83 self.assertFalse(preferred_sdk.internal) 84 84 85 85 def test_macos(self): 86 86 preferred_sdk = sdk.SDK.get_preferred_sdk_for_platform("macosx", self.executive) 87 self.assertEqual s("macosx", preferred_sdk.platform)88 self.assertEqual s("10.14", preferred_sdk.version)87 self.assertEqual("macosx", preferred_sdk.platform) 88 self.assertEqual("10.14", preferred_sdk.version) 89 89 self.assertTrue(preferred_sdk.internal) 90 90 91 91 def test_appletvos(self): 92 92 preferred_sdk = sdk.SDK.get_preferred_sdk_for_platform("appletvos", self.executive) 93 self.assertEqual s("appletvos", preferred_sdk.platform)94 self.assertEqual s("12.0", preferred_sdk.version)93 self.assertEqual("appletvos", preferred_sdk.platform) 94 self.assertEqual("12.0", preferred_sdk.version) 95 95 self.assertTrue(preferred_sdk.internal) 96 96 97 97 def test_appletvsim(self): 98 98 preferred_sdk = sdk.SDK.get_preferred_sdk_for_platform("appletvsimulator", self.executive) 99 self.assertEqual s("appletvsimulator", preferred_sdk.platform)100 self.assertEqual s("12.0", preferred_sdk.version)99 self.assertEqual("appletvsimulator", preferred_sdk.platform) 100 self.assertEqual("12.0", preferred_sdk.version) 101 101 self.assertFalse(preferred_sdk.internal) 102 102 103 103 def test_watchos(self): 104 104 preferred_sdk = sdk.SDK.get_preferred_sdk_for_platform("watchos", self.executive) 105 self.assertEqual s("watchos", preferred_sdk.platform)106 self.assertEqual s("4.0", preferred_sdk.version)105 self.assertEqual("watchos", preferred_sdk.platform) 106 self.assertEqual("4.0", preferred_sdk.version) 107 107 self.assertTrue(preferred_sdk.internal) 108 108 109 109 def test_watchsimulator(self): 110 110 preferred_sdk = sdk.SDK.get_preferred_sdk_for_platform("watchsimulator", self.executive) 111 self.assertEqual s("watchsimulator", preferred_sdk.platform)112 self.assertEqual s("4.0", preferred_sdk.version)111 self.assertEqual("watchsimulator", preferred_sdk.platform) 112 self.assertEqual("4.0", preferred_sdk.version) 113 113 self.assertFalse(preferred_sdk.internal) 114 114 115 115 def test_prodos(self): 116 116 preferred_sdk = sdk.SDK.get_preferred_sdk_for_platform("prodos", self.executive) 117 self.assertEqual s("prodos", preferred_sdk.platform)118 self.assertEqual s(None, preferred_sdk.version)119 self.assertEqual s(None, preferred_sdk.internal)117 self.assertEqual("prodos", preferred_sdk.platform) 118 self.assertEqual(None, preferred_sdk.version) 119 self.assertEqual(None, preferred_sdk.internal) -
trunk/Tools/Scripts/webkitpy/xcode/simulated_device_unittest.py
r280882 r284775 569 569 570 570 # There should only be 1 iPhone X, iPhone 8 and iPhone SE 571 self.assertEqual s(1, len(SimulatedDeviceManager.device_by_filter(lambda device: device.device_type == DeviceType.from_string('iPhone X'), host)))572 self.assertEqual s(1, len(SimulatedDeviceManager.device_by_filter(lambda device: device.device_type == DeviceType.from_string('iPhone 8'), host)))571 self.assertEqual(1, len(SimulatedDeviceManager.device_by_filter(lambda device: device.device_type == DeviceType.from_string('iPhone X'), host))) 572 self.assertEqual(1, len(SimulatedDeviceManager.device_by_filter(lambda device: device.device_type == DeviceType.from_string('iPhone 8'), host))) 573 573 574 574 # There should be 2 5s and 6s 575 self.assertEqual s(2, len(SimulatedDeviceManager.device_by_filter(lambda device: device.device_type == DeviceType.from_string('iPhone 5s'), host)))576 self.assertEqual s(2, len(SimulatedDeviceManager.device_by_filter(lambda device: device.device_type == DeviceType.from_string('iPhone 6s'), host)))575 self.assertEqual(2, len(SimulatedDeviceManager.device_by_filter(lambda device: device.device_type == DeviceType.from_string('iPhone 5s'), host))) 576 self.assertEqual(2, len(SimulatedDeviceManager.device_by_filter(lambda device: device.device_type == DeviceType.from_string('iPhone 6s'), host))) 577 577 578 578 # 19 iPhones 579 self.assertEqual s(19, len(SimulatedDeviceManager.device_by_filter(lambda device: device.device_type == DeviceType.from_string('iPhone'), host)))579 self.assertEqual(19, len(SimulatedDeviceManager.device_by_filter(lambda device: device.device_type == DeviceType.from_string('iPhone'), host))) 580 580 581 581 # 11 iPads 582 self.assertEqual s(11, len(SimulatedDeviceManager.device_by_filter(lambda device: device.device_type == DeviceType.from_string('iPad'), host)))582 self.assertEqual(11, len(SimulatedDeviceManager.device_by_filter(lambda device: device.device_type == DeviceType.from_string('iPad'), host))) 583 583 584 584 # 18 Apple watches 585 self.assertEqual s(6, len(SimulatedDeviceManager.device_by_filter(lambda device: device.device_type == DeviceType.from_string('Apple Watch'), host)))585 self.assertEqual(6, len(SimulatedDeviceManager.device_by_filter(lambda device: device.device_type == DeviceType.from_string('Apple Watch'), host))) 586 586 587 587 # 3 Apple TVs 588 self.assertEqual s(3, len(SimulatedDeviceManager.device_by_filter(lambda device: device.device_type == DeviceType.from_string('Apple TV'), host)))588 self.assertEqual(3, len(SimulatedDeviceManager.device_by_filter(lambda device: device.device_type == DeviceType.from_string('Apple TV'), host))) 589 589 590 590 # 18 devices running iOS 11.0 591 self.assertEqual s(18, len(SimulatedDeviceManager.device_by_filter(lambda device: device.device_type == DeviceType(software_variant='iOS', software_version=Version(11, 0, 1)), host)))591 self.assertEqual(18, len(SimulatedDeviceManager.device_by_filter(lambda device: device.device_type == DeviceType(software_variant='iOS', software_version=Version(11, 0, 1)), host))) 592 592 593 593 # 11 iPhones running iOS 11.0 594 self.assertEqual s(11, len(SimulatedDeviceManager.device_by_filter(lambda device: device.device_type == DeviceType(hardware_family='iPhone', software_version=Version(11, 0, 1)), host)))594 self.assertEqual(11, len(SimulatedDeviceManager.device_by_filter(lambda device: device.device_type == DeviceType(hardware_family='iPhone', software_version=Version(11, 0, 1)), host))) 595 595 596 596 # 1 device running iOS 12 597 self.assertEqual s(1, len(SimulatedDeviceManager.device_by_filter(lambda device: device.device_type == DeviceType(software_variant='iOS', software_version=Version(12, 0, 0)), host)))597 self.assertEqual(1, len(SimulatedDeviceManager.device_by_filter(lambda device: device.device_type == DeviceType(software_variant='iOS', software_version=Version(12, 0, 0)), host))) 598 598 599 599 def test_existing_simulator(self): … … 604 604 SimulatedDeviceManager.initialize_devices(DeviceRequest(DeviceType.from_string('iPhone', Version(11))), host=host) 605 605 606 self.assertEqual s(1, len(SimulatedDeviceManager.INITIALIZED_DEVICES))607 self.assertEqual s('34FB476C-6FA0-43C8-8945-1BD7A4EBF0DE', SimulatedDeviceManager.INITIALIZED_DEVICES[0].udid)608 self.assertEqual s('15A8401', SimulatedDeviceManager.INITIALIZED_DEVICES[0].build_version)609 self.assertEqual s(SimulatedDevice.DeviceState.BOOTED, SimulatedDeviceManager.INITIALIZED_DEVICES[0].platform_device.state())606 self.assertEqual(1, len(SimulatedDeviceManager.INITIALIZED_DEVICES)) 607 self.assertEqual('34FB476C-6FA0-43C8-8945-1BD7A4EBF0DE', SimulatedDeviceManager.INITIALIZED_DEVICES[0].udid) 608 self.assertEqual('15A8401', SimulatedDeviceManager.INITIALIZED_DEVICES[0].build_version) 609 self.assertEqual(SimulatedDevice.DeviceState.BOOTED, SimulatedDeviceManager.INITIALIZED_DEVICES[0].platform_device.state()) 610 610 611 611 SimulatedDeviceManager.tear_down(host) … … 619 619 SimulatedDeviceManager.initialize_devices(DeviceRequest(DeviceType.from_string('iphone 5s', Version(11))), host=host) 620 620 621 self.assertEqual s(1, len(SimulatedDeviceManager.INITIALIZED_DEVICES))622 self.assertEqual s('34FB476C-6FA0-43C8-8945-1BD7A4EBF0DE', SimulatedDeviceManager.INITIALIZED_DEVICES[0].udid)623 self.assertEqual s(SimulatedDevice.DeviceState.BOOTED, SimulatedDeviceManager.INITIALIZED_DEVICES[0].platform_device.state())621 self.assertEqual(1, len(SimulatedDeviceManager.INITIALIZED_DEVICES)) 622 self.assertEqual('34FB476C-6FA0-43C8-8945-1BD7A4EBF0DE', SimulatedDeviceManager.INITIALIZED_DEVICES[0].udid) 623 self.assertEqual(SimulatedDevice.DeviceState.BOOTED, SimulatedDeviceManager.INITIALIZED_DEVICES[0].platform_device.state()) 624 624 625 625 SimulatedDeviceManager.tear_down(host) … … 632 632 633 633 runtime = SimulatedDeviceManager.get_runtime_for_device_type(DeviceType.from_string('iphone 5s', Version(9, 2))) 634 self.assertEqual s(runtime.os_variant, 'iOS')635 self.assertEqual s(runtime.version, Version(9, 3))634 self.assertEqual(runtime.os_variant, 'iOS') 635 self.assertEqual(runtime.version, Version(9, 3)) 636 636 637 637 def test_matching_up_failure(self): … … 641 641 642 642 runtime = SimulatedDeviceManager.get_runtime_for_device_type(DeviceType.from_string('iphone 5s', Version(9, 4))) 643 self.assertEqual s(runtime, None)643 self.assertEqual(runtime, None) 644 644 645 645 def test_no_state_files(self): … … 650 650 651 651 for device in devices: 652 self.assertEqual s(SimulatedDevice.DeviceState.SHUT_DOWN, device.state(force_update=True))652 self.assertEqual(SimulatedDevice.DeviceState.SHUT_DOWN, device.state(force_update=True))
Note:
See TracChangeset
for help on using the changeset viewer.