Changeset 284778 in webkit

Timestamp:

Oct 25, 2021, 5:35:28 AM (5 years ago)

Author:

Chris Lord

Message:

[GTK][WPE] REGRESSION(r284596): Scrolling sometimes jumps to the top of the page during smooth mouse-wheel scrolling
​https://bugs.webkit.org/show_bug.cgi?id=232229

Reviewed by Carlos Garcia Campos.

Source/WebCore:

Make sure that retargeting a smooth scroll animation before a frame
callback is called works correctly.

Test: fast/scrolling/gtk/repeated-mouse-wheel-smooth.html

• platform/ScrollAnimationSmooth.cpp:

(WebCore::ScrollAnimationSmooth::startAnimatedScrollToDestination):

LayoutTests:

Add test to make sure that retargeted smooth scrolling doesn't jump to
the top of the page unexpectedly.

• fast/scrolling/gtk/repeated-mouse-wheel-smooth-expected.txt: Added.
• fast/scrolling/gtk/repeated-mouse-wheel-smooth.html: Added.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/fast/scrolling/gtk/repeated-mouse-wheel-smooth-expected.txt (added)
• LayoutTests/fast/scrolling/gtk/repeated-mouse-wheel-smooth.html (added)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/platform/ScrollAnimationSmooth.cpp (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2021-10-25  Chris Lord  <clord@igalia.com>
+
+        [GTK][WPE] REGRESSION(r284596): Scrolling sometimes jumps to the top of the page during smooth mouse-wheel scrolling
+        https://bugs.webkit.org/show_bug.cgi?id=232229
+
+        Reviewed by Carlos Garcia Campos.
+
+        Add test to make sure that retargeted smooth scrolling doesn't jump to
+        the top of the page unexpectedly.
+
+        * fast/scrolling/gtk/repeated-mouse-wheel-smooth-expected.txt: Added.
+        * fast/scrolling/gtk/repeated-mouse-wheel-smooth.html: Added.
+
 2021-10-25  Arcady Goldmints-Orlov  <agoldmints@igalia.com>
 

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2021-10-25  Chris Lord  <clord@igalia.com>
+
+        [GTK][WPE] REGRESSION(r284596): Scrolling sometimes jumps to the top of the page during smooth mouse-wheel scrolling
+        https://bugs.webkit.org/show_bug.cgi?id=232229
+
+        Reviewed by Carlos Garcia Campos.
+
+        Make sure that retargeting a smooth scroll animation before a frame
+        callback is called works correctly.
+
+        Test: fast/scrolling/gtk/repeated-mouse-wheel-smooth.html
+
+        * platform/ScrollAnimationSmooth.cpp:
+        (WebCore::ScrollAnimationSmooth::startAnimatedScrollToDestination):
+
 2021-10-25  Ziran Sun  <zsun@igalia.com>
 

trunk/Source/WebCore/platform/ScrollAnimationSmooth.cpp

@@ -56 +56 @@
 
     m_startTime = MonotonicTime::now();
-    m_startOffset = fromOffset;
+    m_currentOffset = m_startOffset = fromOffset;
     m_destinationOffset = destinationOffset.constrainedBetween(extents.minimumScrollOffset(), extents.maximumScrollOffset());
     m_duration = durationFromDistance(m_destinationOffset - m_startOffset);