Changeset 284810 in webkit

Timestamp:

Oct 25, 2021, 12:10:06 PM (5 years ago)

Author:

Alan Coon

Message:

Cherry-pick r284623. rdar://problem/84375007

Add missing overflow check to DFGIntegerRangeOptimizationPhase::filterConstant()
​https://bugs.webkit.org/show_bug.cgi?id=232058

Reviewed by Robin Morisset.

Added overflow check.

• dfg/DFGIntegerRangeOptimizationPhase.cpp:

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@284623 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Location:

branches/safari-612-branch/Source/JavaScriptCore

Files:

• ChangeLog (modified) (1 diff)
• dfg/DFGIntegerRangeOptimizationPhase.cpp (modified) (1 diff)

branches/safari-612-branch/Source/JavaScriptCore/ChangeLog

@@ +1 @@
+2021-10-25  Null  <null@apple.com>
+
+        Cherry-pick r284623. rdar://problem/84375007
+
+    Add missing overflow check to DFGIntegerRangeOptimizationPhase::filterConstant()
+    https://bugs.webkit.org/show_bug.cgi?id=232058
+    
+    Reviewed by Robin Morisset.
+    
+    Added overflow check.
+    
+    * dfg/DFGIntegerRangeOptimizationPhase.cpp:
+    
+    
+    git-svn-id: https://svn.webkit.org/repository/webkit/trunk@284623 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+    2021-10-21  Michael Saboff  <msaboff@apple.com>
+
+            Add missing overflow check to DFGIntegerRangeOptimizationPhase::filterConstant()
+            https://bugs.webkit.org/show_bug.cgi?id=232058
+
+            Reviewed by Robin Morisset.
+
+            Added overflow check.
+
+            * dfg/DFGIntegerRangeOptimizationPhase.cpp:
+
 2021-10-25  Null  <null@apple.com>
 

branches/safari-612-branch/Source/JavaScriptCore/dfg/DFGIntegerRangeOptimizationPhase.cpp

@@ -569 +569 @@
         switch (other.m_kind) {
         case Equal:
+            if (differenceOverflows<int>(otherEffectiveRight, thisRight))
+                return *this;
+
             // Return a version of *this that is Equal to other's constant.
             return Relationship(m_left, m_right, Equal, otherEffectiveRight - thisRight);