Changeset 284813 in webkit

Timestamp:

Oct 25, 2021, 12:10:17 PM (5 years ago)

Author:

Alan Coon

Message:

Cherry-pick r284712. rdar://problem/81586485

AX: Inform AX when the injected bundle sends a synchronous message
​https://bugs.webkit.org/show_bug.cgi?id=232159

Reviewed by Andres Gonzalez.

When an injected bundle sends a synchronous message we need to inform accessibility clients, so they don't get
stuck trying to message the WebContent process. This is already handled for synchronous messages
generated from the WebPage.

• WebProcess/InjectedBundle/InjectedBundle.cpp: (WebKit::InjectedBundle::postSynchronousMessage):

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@284712 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Location:

branches/safari-612-branch/Source/WebKit

Files:

• ChangeLog (modified) (1 diff)
• WebProcess/InjectedBundle/InjectedBundle.cpp (modified) (1 diff)

branches/safari-612-branch/Source/WebKit/ChangeLog

@@ +1 @@
+2021-10-25  Null  <null@apple.com>
+
+        Cherry-pick r284712. rdar://problem/81586485
+
+    AX: Inform AX when the injected bundle sends a synchronous message
+    https://bugs.webkit.org/show_bug.cgi?id=232159
+    
+    Reviewed by Andres Gonzalez.
+    
+    When an injected bundle sends a synchronous message we need to inform accessibility clients, so they don't get
+    stuck trying to message the WebContent process. This is already handled for synchronous messages
+    generated from the WebPage.
+    
+    * WebProcess/InjectedBundle/InjectedBundle.cpp:
+    (WebKit::InjectedBundle::postSynchronousMessage):
+    
+    
+    git-svn-id: https://svn.webkit.org/repository/webkit/trunk@284712 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+    2021-10-22  Chris Fleizach  <cfleizach@apple.com>
+
+            AX: Inform AX when the injected bundle sends a synchronous message
+            https://bugs.webkit.org/show_bug.cgi?id=232159
+
+            Reviewed by Andres Gonzalez.
+
+            When an injected bundle sends a synchronous message we need to inform accessibility clients, so they don't get
+            stuck trying to message the WebContent process. This is already handled for synchronous messages
+            generated from the WebPage.
+
+            * WebProcess/InjectedBundle/InjectedBundle.cpp:
+            (WebKit::InjectedBundle::postSynchronousMessage):
+
 2021-10-25  Null  <null@apple.com>
 

branches/safari-612-branch/Source/WebKit/WebProcess/InjectedBundle/InjectedBundle.cpp

@@ -143 +143 @@
     auto& webProcess = WebProcess::singleton();
     if (!webProcess.parentProcessConnection()->sendSync(Messages::WebProcessPool::HandleSynchronousMessage(messageName, UserData(webProcess.transformObjectsToHandles(messageBody))),
-        Messages::WebProcessPool::HandleSynchronousMessage::Reply(returnUserData), 0))
+        Messages::WebProcessPool::HandleSynchronousMessage::Reply(returnUserData), 0, IPC::Timeout::infinity(), IPC::SendSyncOption::InformPlatformProcessWillSuspend))
         returnData = nullptr;
     else