⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Changeset 284825 in webkit


Ignore:
Timestamp:
Oct 25, 2021, 2:50:39 PM (5 years ago)
Author:
Alan Coon
Message:

Cherry-pick r281547. rdar://problem/84629691

ANGLE Metal infinities and NaNs generated with incorrect syntax
​https://bugs.webkit.org/show_bug.cgi?id=229439
<rdar://81033366>

Patch by Kimmo Kinnunen <​kkinnunen@apple.com> on 2021-08-24
Reviewed by Dean Jackson.

Source/ThirdParty/ANGLE:

Generate NaN and infinity constant values correctly.
An else was missing from if-block, causing double processing.

  • src/compiler/translator/TranslatorMetalDirect/EmitMetal.cpp: (GenMetalTraverser::emitSingleConstant):
  • src/libANGLE/renderer/metal/mtl_utils.mm: (rx::mtl::CreateShaderLibrary):

LayoutTests:

Add tests that test some aspects of NaN and -+inf that the GLSL ES 3.00 spec
talks about.

  • webgl/pending/conformance2/glsl3/float-constant-expressions-expected.txt: Added.
  • webgl/pending/conformance2/glsl3/float-constant-expressions.html: Added.
  • webgl/pending/resources/webgl_test_files/conformance2/glsl3/float-constant-expressions.html: Added.
  • webgl/pending/resources/webgl_test_files/js/glsl-conformance-test.js: Added.

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@281547 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Location:
branches/safari-612-branch
Files:
8 added
3 edited

Legend:

Unmodified
Added
Removed

  • branches/safari-612-branch/LayoutTests/ChangeLog

    r284815 r284825  
     12021-10-25  Null  <null@apple.com>
     2
     3        Cherry-pick r281547. rdar://problem/84629691
     4
     5    ANGLE Metal infinities and NaNs generated with incorrect syntax
     6    https://bugs.webkit.org/show_bug.cgi?id=229439
     7    <rdar://81033366>
     8   
     9    Patch by Kimmo Kinnunen <kkinnunen@apple.com> on 2021-08-24
     10    Reviewed by Dean Jackson.
     11   
     12    Source/ThirdParty/ANGLE:
     13   
     14    Generate NaN and infinity constant values correctly.
     15    An else was missing from if-block, causing double processing.
     16   
     17    * src/compiler/translator/TranslatorMetalDirect/EmitMetal.cpp:
     18    (GenMetalTraverser::emitSingleConstant):
     19    * src/libANGLE/renderer/metal/mtl_utils.mm:
     20    (rx::mtl::CreateShaderLibrary):
     21   
     22    LayoutTests:
     23   
     24    Add tests that test some aspects of NaN and -+inf that the GLSL ES 3.00 spec
     25    talks about.
     26   
     27    * webgl/pending/conformance2/glsl3/float-constant-expressions-expected.txt: Added.
     28    * webgl/pending/conformance2/glsl3/float-constant-expressions.html: Added.
     29    * webgl/pending/resources/webgl_test_files/conformance2/glsl3/float-constant-expressions.html: Added.
     30    * webgl/pending/resources/webgl_test_files/js/glsl-conformance-test.js: Added.
     31   
     32    git-svn-id: https://svn.webkit.org/repository/webkit/trunk@281547 268f45cc-cd09-0410-ab3c-d52691b4dbfc
     33
     34    2021-08-24  Kimmo Kinnunen  <kkinnunen@apple.com>
     35
     36            ANGLE Metal infinities and NaNs generated with incorrect syntax
     37            https://bugs.webkit.org/show_bug.cgi?id=229439
     38            <rdar://81033366>
     39
     40            Reviewed by Dean Jackson.
     41
     42            Add tests that test some aspects of NaN and -+inf that the GLSL ES 3.00 spec
     43            talks about.
     44
     45            * webgl/pending/conformance2/glsl3/float-constant-expressions-expected.txt: Added.
     46            * webgl/pending/conformance2/glsl3/float-constant-expressions.html: Added.
     47            * webgl/pending/resources/webgl_test_files/conformance2/glsl3/float-constant-expressions.html: Added.
     48            * webgl/pending/resources/webgl_test_files/js/glsl-conformance-test.js: Added.
     49
    1502021-10-25  Null  <null@apple.com>
    251

  • branches/safari-612-branch/Source/ThirdParty/ANGLE/ChangeLog

    r283784 r284825  
     12021-10-25  Null  <null@apple.com>
     2
     3        Cherry-pick r281547. rdar://problem/84629691
     4
     5    ANGLE Metal infinities and NaNs generated with incorrect syntax
     6    https://bugs.webkit.org/show_bug.cgi?id=229439
     7    <rdar://81033366>
     8   
     9    Patch by Kimmo Kinnunen <kkinnunen@apple.com> on 2021-08-24
     10    Reviewed by Dean Jackson.
     11   
     12    Source/ThirdParty/ANGLE:
     13   
     14    Generate NaN and infinity constant values correctly.
     15    An else was missing from if-block, causing double processing.
     16   
     17    * src/compiler/translator/TranslatorMetalDirect/EmitMetal.cpp:
     18    (GenMetalTraverser::emitSingleConstant):
     19    * src/libANGLE/renderer/metal/mtl_utils.mm:
     20    (rx::mtl::CreateShaderLibrary):
     21   
     22    LayoutTests:
     23   
     24    Add tests that test some aspects of NaN and -+inf that the GLSL ES 3.00 spec
     25    talks about.
     26   
     27    * webgl/pending/conformance2/glsl3/float-constant-expressions-expected.txt: Added.
     28    * webgl/pending/conformance2/glsl3/float-constant-expressions.html: Added.
     29    * webgl/pending/resources/webgl_test_files/conformance2/glsl3/float-constant-expressions.html: Added.
     30    * webgl/pending/resources/webgl_test_files/js/glsl-conformance-test.js: Added.
     31   
     32    git-svn-id: https://svn.webkit.org/repository/webkit/trunk@281547 268f45cc-cd09-0410-ab3c-d52691b4dbfc
     33
     34    2021-08-24  Kimmo Kinnunen  <kkinnunen@apple.com>
     35
     36            ANGLE Metal infinities and NaNs generated with incorrect syntax
     37            https://bugs.webkit.org/show_bug.cgi?id=229439
     38            <rdar://81033366>
     39
     40            Reviewed by Dean Jackson.
     41
     42            Generate NaN and infinity constant values correctly.
     43            An else was missing from if-block, causing double processing.
     44
     45            * src/compiler/translator/TranslatorMetalDirect/EmitMetal.cpp:
     46            (GenMetalTraverser::emitSingleConstant):
     47            * src/libANGLE/renderer/metal/mtl_utils.mm:
     48            (rx::mtl::CreateShaderLibrary):
     49
    1502021-10-07  Alan Coon  <alancoon@apple.com>
    251

  • branches/safari-612-branch/Source/ThirdParty/ANGLE/src/compiler/translator/TranslatorMetalDirect/EmitMetal.cpp

    r279606 r284825  
    15021502                mOut << "NAN";
    15031503            }
    1504             if (ANGLE_UNLIKELY(isinf(constUnion->getFConst())))
     1504            else if (ANGLE_UNLIKELY(isinf(constUnion->getFConst())))
    15051505            {
    15061506                if(constUnion->getFConst() < 0)
Note: See TracChangeset for help on using the changeset viewer.