Changeset 284830 in webkit

Timestamp:

Oct 25, 2021, 2:50:57 PM (5 years ago)

Author:

Alan Coon

Message:

Cherry-pick r283600. rdar://problem/84625586

Don't pass DontBuildStrings to next token after parsing an empty parameter list
​https://bugs.webkit.org/show_bug.cgi?id=225094
<rdar://problem/77231778>

Reviewed by Yusuke Suzuki.

JSTests:

• stress/dont-pass-DontBuildStrings-when-building-empty-arguments-list.js: Added. (main.a.prototype.g.toString.string_appeared_here): (main.a): (main):

Source/JavaScriptCore:

We might need the string, it turns out!

• parser/Parser.cpp: (JSC::Parser<LexerType>::parseArguments):

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@283600 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Location:

branches/safari-612-branch

Files:

• JSTests/ChangeLog (modified) (1 diff)
• JSTests/stress/dont-pass-DontBuildStrings-when-building-empty-arguments-list.js (added)
• Source/JavaScriptCore/ChangeLog (modified) (1 diff)
• Source/JavaScriptCore/parser/Parser.cpp (modified) (1 diff)

branches/safari-612-branch/JSTests/ChangeLog

@@ +1 @@
+2021-10-25  Null  <null@apple.com>
+
+        Cherry-pick r283600. rdar://problem/84625586
+
+    Don't pass DontBuildStrings to next token after parsing an empty parameter list
+    https://bugs.webkit.org/show_bug.cgi?id=225094
+    <rdar://problem/77231778>
+    
+    Reviewed by Yusuke Suzuki.
+    
+    JSTests:
+    
+    * stress/dont-pass-DontBuildStrings-when-building-empty-arguments-list.js: Added.
+    (main.a.prototype.g.toString.string_appeared_here):
+    (main.a):
+    (main):
+    
+    Source/JavaScriptCore:
+    
+    We might need the string, it turns out!
+    
+    * parser/Parser.cpp:
+    (JSC::Parser<LexerType>::parseArguments):
+    
+    
+    git-svn-id: https://svn.webkit.org/repository/webkit/trunk@283600 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+    2021-10-05  Saam Barati  <sbarati@apple.com>
+
+            Don't pass DontBuildStrings to next token after parsing an empty parameter list
+            https://bugs.webkit.org/show_bug.cgi?id=225094
+            <rdar://problem/77231778>
+
+            Reviewed by Yusuke Suzuki.
+
+            * stress/dont-pass-DontBuildStrings-when-building-empty-arguments-list.js: Added.
+            (main.a.prototype.g.toString.string_appeared_here):
+            (main.a):
+            (main):
+
 2021-10-18  Russell Epstein  <repstein@apple.com>
 

branches/safari-612-branch/Source/JavaScriptCore/ChangeLog

@@ +1 @@
+2021-10-25  Null  <null@apple.com>
+
+        Cherry-pick r283600. rdar://problem/84625586
+
+    Don't pass DontBuildStrings to next token after parsing an empty parameter list
+    https://bugs.webkit.org/show_bug.cgi?id=225094
+    <rdar://problem/77231778>
+    
+    Reviewed by Yusuke Suzuki.
+    
+    JSTests:
+    
+    * stress/dont-pass-DontBuildStrings-when-building-empty-arguments-list.js: Added.
+    (main.a.prototype.g.toString.string_appeared_here):
+    (main.a):
+    (main):
+    
+    Source/JavaScriptCore:
+    
+    We might need the string, it turns out!
+    
+    * parser/Parser.cpp:
+    (JSC::Parser<LexerType>::parseArguments):
+    
+    
+    git-svn-id: https://svn.webkit.org/repository/webkit/trunk@283600 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+    2021-10-05  Saam Barati  <sbarati@apple.com>
+
+            Don't pass DontBuildStrings to next token after parsing an empty parameter list
+            https://bugs.webkit.org/show_bug.cgi?id=225094
+            <rdar://problem/77231778>
+
+            Reviewed by Yusuke Suzuki.
+
+            We might need the string, it turns out!
+
+            * parser/Parser.cpp:
+            (JSC::Parser<LexerType>::parseArguments):
+
 2021-10-25  Null  <null@apple.com>
 

branches/safari-612-branch/Source/JavaScriptCore/parser/Parser.cpp

@@ -4982 +4982 @@
     JSTokenLocation location(tokenLocation());
     if (match(CLOSEPAREN)) {
-        next(TreeBuilder::DontBuildStrings);
+        next();
         return context.createArguments();
     }