Changeset 284833 in webkit

Timestamp:

Oct 25, 2021, 2:51:06 PM (5 years ago)

Author:

Alan Coon

Message:

Cherry-pick r284007. rdar://problem/84630339

Cocoa GraphicsContextGLOpenGL uses depth and stencil for pbuffers on ANGLE Metal
​https://bugs.webkit.org/show_bug.cgi?id=231424

Patch by Kimmo Kinnunen <​kkinnunen@apple.com> on 2021-10-12
Reviewed by Dean Jackson.

ANGLE Metal allocates depth and stencil buffers when a pbuffer is bound to
a texture via eglBindTexImage.
To side-step this performance issue, allocate the gl context with EGLConfig
that disables depth and stencil. The config is used for the video texture
upload context, video texture upload pbuffers as well as other pbuffers.

• platform/graphics/cocoa/GraphicsContextGLOpenGLCocoa.mm: (WebCore::GraphicsContextGLOpenGL::GraphicsContextGLOpenGL):

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@284007 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Location:

branches/safari-612-branch/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• platform/graphics/cocoa/GraphicsContextGLOpenGLCocoa.mm (modified) (1 diff)

branches/safari-612-branch/Source/WebCore/ChangeLog

@@ +1 @@
+2021-10-25  Null  <null@apple.com>
+
+        Cherry-pick r284007. rdar://problem/84630339
+
+    Cocoa GraphicsContextGLOpenGL uses depth and stencil for pbuffers on ANGLE Metal
+    https://bugs.webkit.org/show_bug.cgi?id=231424
+    
+    Patch by Kimmo Kinnunen <kkinnunen@apple.com> on 2021-10-12
+    Reviewed by Dean Jackson.
+    
+    ANGLE Metal allocates depth and stencil buffers when a pbuffer is bound to
+    a texture via eglBindTexImage.
+    To side-step this performance issue, allocate the gl context with EGLConfig
+    that disables depth and stencil. The config is used for the video texture
+    upload context, video texture upload pbuffers as well as other pbuffers.
+    
+    * platform/graphics/cocoa/GraphicsContextGLOpenGLCocoa.mm:
+    (WebCore::GraphicsContextGLOpenGL::GraphicsContextGLOpenGL):
+    
+    git-svn-id: https://svn.webkit.org/repository/webkit/trunk@284007 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+    2021-10-12  Kimmo Kinnunen  <kkinnunen@apple.com>
+
+            Cocoa GraphicsContextGLOpenGL uses depth and stencil for pbuffers on ANGLE Metal
+            https://bugs.webkit.org/show_bug.cgi?id=231424
+
+            Reviewed by Dean Jackson.
+
+            ANGLE Metal allocates depth and stencil buffers when a pbuffer is bound to
+            a texture via eglBindTexImage.
+            To side-step this performance issue, allocate the gl context with EGLConfig
+            that disables depth and stencil. The config is used for the video texture
+            upload context, video texture upload pbuffers as well as other pbuffers.
+
+            * platform/graphics/cocoa/GraphicsContextGLOpenGLCocoa.mm:
+            (WebCore::GraphicsContextGLOpenGL::GraphicsContextGLOpenGL):
+
 2021-10-25  Null  <null@apple.com>
 

branches/safari-612-branch/Source/WebCore/platform/graphics/cocoa/GraphicsContextGLOpenGLCocoa.mm

@@ -267 +267 @@
         EGL_BLUE_SIZE, 8,
         EGL_ALPHA_SIZE, 8,
+        EGL_DEPTH_SIZE, 0,
+        EGL_STENCIL_SIZE, 0,
         EGL_NONE
     };