⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Changeset 284836 in webkit


Ignore:
Timestamp:
Oct 25, 2021, 2:51:17 PM (5 years ago)
Author:
Alan Coon
Message:

Cherry-pick r284247. rdar://problem/84629726

REGRESSION (r276370): Elements with animated transform property might not properly rendered
​https://bugs.webkit.org/show_bug.cgi?id=230753

Reviewed by Myles C. Maxfield.

Source/WebCore:

The change in r276370 was incorrect, resulting in the geometry map being used when
an element had a transform and transform-style: preserves-3d.

Fix by going back to testing for the presence of the various transform properties which
affect geometry. hasTransformRelatedProperty() is still useful as a fast bit-check.

Test: fast/repaint/transform-preserve-3d-repaint.html

  • rendering/RenderGeometryMap.cpp: (WebCore::canMapBetweenRenderersViaLayers):

LayoutTests:

  • fast/repaint/transform-preserve-3d-repaint-expected.txt: Added.
  • fast/repaint/transform-preserve-3d-repaint.html: Added.

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@284247 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Location:
branches/safari-612-branch
Files:
2 added
3 edited

Legend:

Unmodified
Added
Removed

  • branches/safari-612-branch/LayoutTests/ChangeLog

    r284832 r284836  
     12021-10-25  Null  <null@apple.com>
     2
     3        Cherry-pick r284247. rdar://problem/84629726
     4
     5    REGRESSION (r276370): Elements with animated transform property might not properly rendered
     6    https://bugs.webkit.org/show_bug.cgi?id=230753
     7   
     8    Reviewed by Myles C. Maxfield.
     9   
     10    Source/WebCore:
     11   
     12    The change in r276370 was incorrect, resulting in the geometry map being used when
     13    an element had a transform and `transform-style: preserves-3d`.
     14   
     15    Fix by going back to testing for the presence of the various transform properties which
     16    affect geometry. hasTransformRelatedProperty() is still useful as a fast bit-check.
     17   
     18    Test: fast/repaint/transform-preserve-3d-repaint.html
     19   
     20    * rendering/RenderGeometryMap.cpp:
     21    (WebCore::canMapBetweenRenderersViaLayers):
     22   
     23    LayoutTests:
     24   
     25    * fast/repaint/transform-preserve-3d-repaint-expected.txt: Added.
     26    * fast/repaint/transform-preserve-3d-repaint.html: Added.
     27   
     28   
     29    git-svn-id: https://svn.webkit.org/repository/webkit/trunk@284247 268f45cc-cd09-0410-ab3c-d52691b4dbfc
     30
     31    2021-10-15  Simon Fraser  <simon.fraser@apple.com>
     32
     33            REGRESSION (r276370): Elements with animated transform property might not properly rendered
     34            https://bugs.webkit.org/show_bug.cgi?id=230753
     35
     36            Reviewed by Myles C. Maxfield.
     37
     38            * fast/repaint/transform-preserve-3d-repaint-expected.txt: Added.
     39            * fast/repaint/transform-preserve-3d-repaint.html: Added.
     40
    1412021-10-25  Null  <null@apple.com>
    242

  • branches/safari-612-branch/Source/WebCore/ChangeLog

    r284833 r284836  
     12021-10-25  Null  <null@apple.com>
     2
     3        Cherry-pick r284247. rdar://problem/84629726
     4
     5    REGRESSION (r276370): Elements with animated transform property might not properly rendered
     6    https://bugs.webkit.org/show_bug.cgi?id=230753
     7   
     8    Reviewed by Myles C. Maxfield.
     9   
     10    Source/WebCore:
     11   
     12    The change in r276370 was incorrect, resulting in the geometry map being used when
     13    an element had a transform and `transform-style: preserves-3d`.
     14   
     15    Fix by going back to testing for the presence of the various transform properties which
     16    affect geometry. hasTransformRelatedProperty() is still useful as a fast bit-check.
     17   
     18    Test: fast/repaint/transform-preserve-3d-repaint.html
     19   
     20    * rendering/RenderGeometryMap.cpp:
     21    (WebCore::canMapBetweenRenderersViaLayers):
     22   
     23    LayoutTests:
     24   
     25    * fast/repaint/transform-preserve-3d-repaint-expected.txt: Added.
     26    * fast/repaint/transform-preserve-3d-repaint.html: Added.
     27   
     28   
     29    git-svn-id: https://svn.webkit.org/repository/webkit/trunk@284247 268f45cc-cd09-0410-ab3c-d52691b4dbfc
     30
     31    2021-10-15  Simon Fraser  <simon.fraser@apple.com>
     32
     33            REGRESSION (r276370): Elements with animated transform property might not properly rendered
     34            https://bugs.webkit.org/show_bug.cgi?id=230753
     35
     36            Reviewed by Myles C. Maxfield.
     37
     38            The change in r276370 was incorrect, resulting in the geometry map being used when
     39            an element had a transform and `transform-style: preserves-3d`.
     40
     41            Fix by going back to testing for the presence of the various transform properties which
     42            affect geometry. hasTransformRelatedProperty() is still useful as a fast bit-check.
     43
     44            Test: fast/repaint/transform-preserve-3d-repaint.html
     45
     46            * rendering/RenderGeometryMap.cpp:
     47            (WebCore::canMapBetweenRenderersViaLayers):
     48
    1492021-10-25  Null  <null@apple.com>
    250

  • branches/safari-612-branch/Source/WebCore/rendering/RenderGeometryMap.cpp

    r276629 r284836  
    155155            return false;
    156156
    157         if (current->hasTransformRelatedProperty() && !current->style().preserves3D())
     157        if (current->hasTransformRelatedProperty() && (style.hasTransform() || style.translate() || style.scale() || style.rotate() || style.hasPerspective()))
    158158            return false;
    159159       
Note: See TracChangeset for help on using the changeset viewer.