Changeset 284844 in webkit

Timestamp:

Oct 25, 2021, 4:20:28 PM (5 years ago)

Author:

Chris Fleizach

Message:

WebKit should use img@title as label even if img@alt is exlicitly empty
​https://bugs.webkit.org/show_bug.cgi?id=173870
<rdar://problem/33010427>

Reviewed by Andres Gonzalez.

Source/WebCore:

alt="" usually means to ignore an image. However, when it also carries other
descriptive attributes, that is probably the wrong decision.
Other browsers are not ignoring these images, WebKit should follow suit.

This issue has been raised with
​https://github.com/w3c/accname/issues/27

Test: accessibility/img-no-alt-not-ignored-with-title.html

• accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::computeAccessibilityIsIgnored const):

LayoutTests:

• accessibility/img-no-alt-not-ignored-with-title-expected.txt: Added.
• accessibility/img-no-alt-not-ignored-with-title.html: Added.
• platform/ios-simulator/TestExpectations:
• platform/win/TestExpectations:

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/accessibility/img-no-alt-not-ignored-with-title-expected.txt (added)
• LayoutTests/accessibility/img-no-alt-not-ignored-with-title.html (added)
• LayoutTests/platform/ios-simulator/TestExpectations (modified) (1 diff)
• LayoutTests/platform/win/TestExpectations (modified) (1 diff)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/accessibility/AccessibilityRenderObject.cpp (modified) (2 diffs)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2021-10-25  Chris Fleizach  <cfleizach@apple.com>
+
+        WebKit should use img@title as label even if img@alt is exlicitly empty
+        https://bugs.webkit.org/show_bug.cgi?id=173870
+        <rdar://problem/33010427>
+
+        Reviewed by Andres Gonzalez.
+
+        * accessibility/img-no-alt-not-ignored-with-title-expected.txt: Added.
+        * accessibility/img-no-alt-not-ignored-with-title.html: Added.
+        * platform/ios-simulator/TestExpectations:
+        * platform/win/TestExpectations:
+
 2021-10-25  Eric Hutchison  <ehutchison@apple.com>
 

trunk/LayoutTests/platform/ios-simulator/TestExpectations

@@ -4 +4 @@
 #
 
+accessibility/img-no-alt-not-ignored-with-title.html [ Pass ]
 accessibility/insert-newline.html [ Pass ]
 accessibility/url-test.html [ Pass ]

trunk/LayoutTests/platform/win/TestExpectations

@@ -275 +275 @@
 accessibility/listbox-clear-selection.html [ Skip ]
 accessibility/embedded-image-description.html [ Skip ]
+accessibility/img-no-alt-not-ignored-with-title.html [ Skip ]
 
 # TODO Conic gradients

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2021-10-25  Chris Fleizach  <cfleizach@apple.com>
+
+        WebKit should use img@title as label even if img@alt is exlicitly empty
+        https://bugs.webkit.org/show_bug.cgi?id=173870
+        <rdar://problem/33010427>
+
+        Reviewed by Andres Gonzalez.
+
+        alt="" usually means to ignore an image. However, when it also carries other
+        descriptive attributes, that is probably the wrong decision.
+        Other browsers are not ignoring these images, WebKit should follow suit.
+        
+        This issue has been raised with
+        https://github.com/w3c/accname/issues/27
+
+        Test: accessibility/img-no-alt-not-ignored-with-title.html
+
+        * accessibility/AccessibilityRenderObject.cpp:
+        (WebCore::AccessibilityRenderObject::computeAccessibilityIsIgnored const):
+
 2021-10-25  Ayumi Kojima  <ayumi_kojima@apple.com>
 

trunk/Source/WebCore/accessibility/AccessibilityRenderObject.cpp

@@ -1444 +1444 @@
             return false;
 
+        // webkit.org/b/173870 - If an image has other alternative text, don't ignore it if alt text is empty.
+        // This means we should process title and aria-label first.
+        
+        // If an image has the title or label attributes, accessibility should be lenient and allow it to appear in the hierarchy (according to WAI-ARIA).
+        if (!getAttribute(titleAttr).isEmpty() || !getAttribute(aria_labelAttr).isEmpty())
+            return false;
+
         // First check the RenderImage's altText (which can be set through a style sheet, or come from the Element).
         // However, if this is not a native image, fallback to the attribute on the Element.
@@ -1456 +1463 @@
             return true;
         if (altTextInclusion == AccessibilityObjectInclusion::IncludeObject)
-            return false;
-
-        // If an image has the title or label attributes, accessibility should be lenient and allow it to appear in the hierarchy (according to WAI-ARIA).
-        if (!getAttribute(titleAttr).isEmpty() || !getAttribute(aria_labelAttr).isEmpty())
             return false;