⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Changeset 284848 in webkit


Ignore:
Timestamp:
Oct 25, 2021, 4:39:50 PM (5 years ago)
Author:
wilander@apple.com
Message:

Remove assert failure expectations after r284846 landed
​https://bugs.webkit.org/show_bug.cgi?id=232048
<rdar://problem/84479642>
​https://bugs.webkit.org/show_bug.cgi?id=232102
<rdar://problem/84521189>
​https://bugs.webkit.org/show_bug.cgi?id=231255
<rdar://problem/83903881>
​https://bugs.webkit.org/show_bug.cgi?id=231431
<rdar://problem/84029425>

Unreviewed test gardening.

Depends on this fix: ​https://trac.webkit.org/changeset/284846/webkit

Source/WebKit:

  • NetworkProcess/NetworkSession.cpp:

(WebKit::NetworkSession::setPrivateClickMeasurementAppBundleIDForTesting):

Removed comment with Bugzilla reference.
I decided to keep the logging since it was so useful in finding the root
cause of the assertion crashes. Logging is only triggered when we will
fail the assertion.

LayoutTests:

  • platform/ios-wk2/TestExpectations:

Removed crash expectations now that the app bundle ID setting for InAppBrowserPrivacy
API tests is being cleared after each test.

Location:
trunk
Files:
4 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r284847 r284848  
     12021-10-25  John Wilander  <wilander@apple.com>
     2
     3        Remove assert failure expectations after r284846 landed
     4        https://bugs.webkit.org/show_bug.cgi?id=232048
     5        <rdar://problem/84479642>
     6        https://bugs.webkit.org/show_bug.cgi?id=232102
     7        <rdar://problem/84521189>
     8        https://bugs.webkit.org/show_bug.cgi?id=231255
     9        <rdar://problem/83903881>
     10        https://bugs.webkit.org/show_bug.cgi?id=231431
     11        <rdar://problem/84029425>
     12
     13        Unreviewed test gardening.
     14
     15        Depends on this fix: https://trac.webkit.org/changeset/284846/webkit
     16
     17        * platform/ios-wk2/TestExpectations:
     18            Removed crash expectations now that the app bundle ID setting for InAppBrowserPrivacy
     19            API tests is being cleared after each test.
     20
    1212021-10-25  Eric Hutchison  <ehutchison@apple.com>
    222

  • trunk/LayoutTests/platform/ios-wk2/TestExpectations

    r284800 r284848  
    21512151webkit.org/b/222563 [ Release ] http/tests/loading/basic-auth-load-URL-with-consecutive-slashes.html [ Pass Failure ]
    21522152
    2153 webkit.org/b/231255 http/tests/privateClickMeasurement/attribution-conversion-through-cross-site-image-redirect.html [ Pass Crash ]
    2154 
    2155 webkit.org/b/231431 http/tests/privateClickMeasurement/attribution-conversion-through-fetch-keepalive.html [ Pass Crash ]
    2156 
    2157 webkit.org/b/231748 http/tests/privateClickMeasurement/attribution-conversion-through-image-redirect-ephemeral.html [ Pass Crash ]
    2158 
    21592153webkit.org/b/229563 imported/w3c/web-platform-tests/css/css-display/display-contents-blockify-dynamic.html [ Pass Timeout ]
    21602154
    … …  
    22292223webkit.org/b/232099 imported/w3c/web-platform-tests/websockets/Close-1000.any.html [ Pass Crash ]
    22302224
    2231 webkit.org/b/232102 http/tests/privateClickMeasurement/attribution-conversion-through-image-redirect-with-priority.html [ Pass Crash ]
    2232 
    22332225webkit.org/b/232120 imported/w3c/web-platform-tests/content-security-policy/script-src/script-src-multiple-policies-multiple-hashing-algorithms.html [ Pass Failure DumpJSConsoleLogInStdErr ]
    22342226

  • trunk/Source/WebKit/ChangeLog

    r284843 r284848  
     12021-10-25  John Wilander  <wilander@apple.com>
     2
     3        Remove assert failure expectations after r284846 landed
     4        https://bugs.webkit.org/show_bug.cgi?id=232048
     5        <rdar://problem/84479642>
     6        https://bugs.webkit.org/show_bug.cgi?id=232102
     7        <rdar://problem/84521189>
     8        https://bugs.webkit.org/show_bug.cgi?id=231255
     9        <rdar://problem/83903881>
     10        https://bugs.webkit.org/show_bug.cgi?id=231431
     11        <rdar://problem/84029425>
     12
     13        Unreviewed test gardening.
     14
     15        Depends on this fix: https://trac.webkit.org/changeset/284846/webkit
     16
     17        * NetworkProcess/NetworkSession.cpp:
     18        (WebKit::NetworkSession::setPrivateClickMeasurementAppBundleIDForTesting):
     19            Removed comment with Bugzilla reference.
     20            I decided to keep the logging since it was so useful in finding the root
     21            cause of the assertion crashes. Logging is only triggered when we will
     22            fail the assertion.
     23
    1242021-10-25  Wenson Hsieh  <wenson_hsieh@apple.com>
    225

  • trunk/Source/WebKit/NetworkProcess/NetworkSession.cpp

    r284649 r284848  
    456456{
    457457#if PLATFORM(COCOA)
    458     // FIXME: Remove this logging once https://bugs.webkit.org/show_bug.cgi?id=232048 has been resolved.
    459458    auto appBundleID = WebCore::applicationBundleIdentifier();
    460459    if (!isRunningTest(appBundleID))
Note: See TracChangeset for help on using the changeset viewer.