Changeset 284853 in webkit

Timestamp:

Oct 25, 2021, 6:44:38 PM (5 years ago)

Author:

commit-queue@webkit.org

Message:

Fix issue for transform-origin in SVG
​https://bugs.webkit.org/show_bug.cgi?id=232189

Patch by Nikolaos Mouchtaris <Nikos Mouchtaris> on 2021-10-25
Reviewed by Simon Fraser.

LayoutTests/imported/w3c:

• web-platform-tests/svg/styling/render/transform-origin-not-explicit-style-ref.svg: Added.
• web-platform-tests/svg/styling/render/transform-origin-not-explicit-style.svg: Added.

Source/WebCore:

Add temp fix to use previously ignored transform-origin in SVGGraphicsElement::animatedLocalTransform
if not explicitly set in style. Proper fix to come: ​https://bugs.webkit.org/show_bug.cgi?id=232128.

Tests: imported/w3c/web-platform-tests/svg/styling/render/transform-origin-not-explicit-style-ref.svg

imported/w3c/web-platform-tests/svg/styling/render/transform-origin-not-explicit-style.svg

• svg/SVGGraphicsElement.cpp:

(WebCore::SVGGraphicsElement::animatedLocalTransform const):

Location:

trunk

Files:

• LayoutTests/imported/w3c/ChangeLog (modified) (1 diff)
• LayoutTests/imported/w3c/web-platform-tests/svg/styling/render/transform-origin-not-explicit-style-visual-expected.svg (added)
• LayoutTests/imported/w3c/web-platform-tests/svg/styling/render/transform-origin-not-explicit-style-visual.svg (added)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/svg/SVGGraphicsElement.cpp (modified) (1 diff)

trunk/LayoutTests/imported/w3c/ChangeLog

@@ +1 @@
+2021-10-25  Nikolaos Mouchtaris  <nmouchtaris@apple.com>
+
+        Fix issue for transform-origin in SVG
+        https://bugs.webkit.org/show_bug.cgi?id=232189
+
+        Reviewed by Simon Fraser.
+
+        * web-platform-tests/svg/styling/render/transform-origin-not-explicit-style-ref.svg: Added.
+        * web-platform-tests/svg/styling/render/transform-origin-not-explicit-style.svg: Added.
+
 2021-10-25  Chris Dumez  <cdumez@apple.com>
 

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2021-10-25  Nikolaos Mouchtaris  <nmouchtaris@apple.com>
+
+        Fix issue for transform-origin in SVG
+        https://bugs.webkit.org/show_bug.cgi?id=232189
+
+        Reviewed by Simon Fraser.
+
+        Add temp fix to use previously ignored transform-origin in SVGGraphicsElement::animatedLocalTransform 
+        if not explicitly set in style. Proper fix to come: https://bugs.webkit.org/show_bug.cgi?id=232128.
+
+        Tests: imported/w3c/web-platform-tests/svg/styling/render/transform-origin-not-explicit-style-ref.svg
+               imported/w3c/web-platform-tests/svg/styling/render/transform-origin-not-explicit-style.svg
+
+        * svg/SVGGraphicsElement.cpp:
+        (WebCore::SVGGraphicsElement::animatedLocalTransform const):
+
 2021-10-25  Chris Fleizach  <cfleizach@apple.com>
 

trunk/Source/WebCore/svg/SVGGraphicsElement.cpp

@@ -100 +100 @@
 
     // If we didn't have the CSS "transform" property set, we must account for the "transform" attribute.
-    if (!hasSpecifiedTransform)
+    if (!hasSpecifiedTransform && style) {
+        auto boundingBox = SVGRenderSupport::transformReferenceBox(*renderer(), *this, *style);
+        auto t = floatPointForLengthPoint(style->transformOriginXY(), boundingBox.size());
+        matrix.translate(t);
         matrix *= transform().concatenate();
+        matrix.translate(-t.x(), -t.y());
+    }
 
     if (m_supplementalTransform)