⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Changeset 284855 in webkit


Ignore:
Timestamp:
Oct 25, 2021, 9:40:59 PM (5 years ago)
Author:
Ryan Haddad
Message:

Change default iOS simulator to one with a larger screen size
​https://bugs.webkit.org/show_bug.cgi?id=231844

Reviewed by Jonathan Bedard.

Tools:

  • Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:

(RunTest.test_device_type_specific_listing):

  • Scripts/webkitpy/port/ios_simulator.py:

(IOSSimulatorPort):
(IPhoneSimulatorPort):

LayoutTests:

  • platform/ios-wk2/TestExpectations:
  • platform/ios-wk2/imported/w3c/web-platform-tests/css/cssom/cssstyledeclaration-csstext-expected.txt: Removed.
  • platform/ios/compositing/backing/page-scale-overlap-in-iframe-expected.txt: Renamed from LayoutTests/platform/ios-wk2/compositing/backing/page-scale-overlap-in-iframe-expected.txt.
  • platform/ios/compositing/contents-format/deep-color-backing-store-expected.txt: Added.
  • platform/ios/fast/events/ios/keyboard-scrolling-distance-expected.txt: Added.
  • platform/ios/fast/events/ios/keyboard-should-not-trigger-resize-expected.txt: Added.
  • platform/ios/fast/events/ios/rotation/zz-no-rotation-expected.txt: Added.
  • platform/ios/fast/forms/ios/accessory-bar-navigation-expected.txt: Added.
  • platform/ios/fast/forms/ios/focus-input-in-fixed-expected.txt: Added.
  • platform/ios/fast/forms/ios/focus-input-in-iframe-expected.txt: Added.
  • platform/ios/fast/forms/ios/focus-input-via-button-expected.txt: Added.
  • platform/ios/fast/forms/ios/focus-input-via-button-no-scaling-expected.txt: Added.
  • platform/ios/fast/forms/ios/focus-long-textarea-expected.txt: Added.
  • platform/ios/fast/forms/ios/zoom-after-input-tap-expected.txt: Added.
  • platform/ios/fast/forms/ios/zoom-after-input-tap-wide-input-expected.txt: Added.
  • platform/ios/fast/scrolling/ios/clipping-ancestor-with-accelerated-scrolling-ancestor-expected.txt:
  • platform/ios/fast/scrolling/ios/overflow-scrolling-ancestor-clip-expected.txt:
  • platform/ios/fast/scrolling/ios/overflow-scrolling-ancestor-clip-size-expected.txt:
  • platform/ios/fast/scrolling/ios/scrolling-content-clip-to-viewport-expected.txt:
  • platform/ios/fast/scrolling/ios/subpixel-overflow-scrolling-with-ancestor-expected.txt: Copied from LayoutTests/platform/ios/fast/scrolling/ios/overflow-scrolling-ancestor-clip-expected.txt.
  • platform/ios/fast/scrolling/ios/touch-stacking-expected.txt:
  • platform/ios/fast/viewport/ios/device-width-viewport-after-changing-view-scale-expected.txt: Added.
  • platform/ios/fast/viewport/ios/non-responsive-viewport-after-changing-view-scale-expected.txt: Added.
  • platform/ios/fast/viewport/ios/responsive-viewport-with-minimum-width-after-changing-view-scale-expected.txt: Added.
  • platform/ios/fast/viewport/ios/shrink-to-fit-for-page-without-viewport-meta-expected.txt: Added.
  • platform/ios/fast/viewport/ios/use-minimum-device-width-for-page-without-viewport-meta-expected.txt: Added.
  • platform/ios/fast/viewport/ios/width-is-device-width-expected.txt: Added.
  • platform/ios/fast/viewport/ios/width-is-device-width-overflowing-body-overflow-hidden-expected.txt: Added.
  • platform/ios/fast/viewport/ios/width-is-device-width-overflowing-body-overflow-hidden-tall-expected.txt: Added.
  • platform/ios/fast/viewport/ios/width-is-device-width-overflowing-expected.txt: Added.
  • platform/ios/fast/viewport/ios/width-is-device-width-overflowing-no-shrink-to-fit-expected.txt: Added.
  • platform/ios/imported/w3c/web-platform-tests/css/cssom/cssstyledeclaration-csstext-expected.txt:
  • platform/ios/imported/w3c/web-platform-tests/css/cssom/getComputedStyle-detached-subtree-expected.txt: Renamed from LayoutTests/platform/ios-wk2/imported/w3c/web-platform-tests/css/cssom/getComputedStyle-detached-subtree-expected.txt.
  • platform/ios-wk2/imported/w3c/web-platform-tests/html/semantics/interactive-elements/the-dialog-element/dialog-form-submission-expected.txt:
  • platform/ios/scrollingcoordinator/ios/fixed-in-frame-layer-reconcile-layer-position-expected.txt: Added.
  • platform/ios/scrollingcoordinator/ios/fixed-in-overflow-scroll-scrolling-tree-expected.txt: Added.
  • platform/ios/scrollingcoordinator/ios/fixed-scrolling-with-keyboard-expected.txt: Added.
  • platform/ios/scrollingcoordinator/ios/ui-scrolling-tree-expected.txt: Added.
Location:
trunk
Files:
29 added
11 edited
1 copied
2 moved

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r284849 r284855  
     12021-10-25  Ryan Haddad  <ryanhaddad@apple.com>
     2
     3        Change default iOS simulator to one with a larger screen size
     4        https://bugs.webkit.org/show_bug.cgi?id=231844
     5
     6        Reviewed by Jonathan Bedard.
     7
     8        * platform/ios-wk2/TestExpectations:
     9        * platform/ios-wk2/imported/w3c/web-platform-tests/css/cssom/cssstyledeclaration-csstext-expected.txt: Removed.
     10        * platform/ios/compositing/backing/page-scale-overlap-in-iframe-expected.txt: Renamed from LayoutTests/platform/ios-wk2/compositing/backing/page-scale-overlap-in-iframe-expected.txt.
     11        * platform/ios/compositing/contents-format/deep-color-backing-store-expected.txt: Added.
     12        * platform/ios/fast/events/ios/keyboard-scrolling-distance-expected.txt: Added.
     13        * platform/ios/fast/events/ios/keyboard-should-not-trigger-resize-expected.txt: Added.
     14        * platform/ios/fast/events/ios/rotation/zz-no-rotation-expected.txt: Added.
     15        * platform/ios/fast/forms/ios/accessory-bar-navigation-expected.txt: Added.
     16        * platform/ios/fast/forms/ios/focus-input-in-fixed-expected.txt: Added.
     17        * platform/ios/fast/forms/ios/focus-input-in-iframe-expected.txt: Added.
     18        * platform/ios/fast/forms/ios/focus-input-via-button-expected.txt: Added.
     19        * platform/ios/fast/forms/ios/focus-input-via-button-no-scaling-expected.txt: Added.
     20        * platform/ios/fast/forms/ios/focus-long-textarea-expected.txt: Added.
     21        * platform/ios/fast/forms/ios/zoom-after-input-tap-expected.txt: Added.
     22        * platform/ios/fast/forms/ios/zoom-after-input-tap-wide-input-expected.txt: Added.
     23        * platform/ios/fast/scrolling/ios/clipping-ancestor-with-accelerated-scrolling-ancestor-expected.txt:
     24        * platform/ios/fast/scrolling/ios/overflow-scrolling-ancestor-clip-expected.txt:
     25        * platform/ios/fast/scrolling/ios/overflow-scrolling-ancestor-clip-size-expected.txt:
     26        * platform/ios/fast/scrolling/ios/scrolling-content-clip-to-viewport-expected.txt:
     27        * platform/ios/fast/scrolling/ios/subpixel-overflow-scrolling-with-ancestor-expected.txt: Copied from LayoutTests/platform/ios/fast/scrolling/ios/overflow-scrolling-ancestor-clip-expected.txt.
     28        * platform/ios/fast/scrolling/ios/touch-stacking-expected.txt:
     29        * platform/ios/fast/viewport/ios/device-width-viewport-after-changing-view-scale-expected.txt: Added.
     30        * platform/ios/fast/viewport/ios/non-responsive-viewport-after-changing-view-scale-expected.txt: Added.
     31        * platform/ios/fast/viewport/ios/responsive-viewport-with-minimum-width-after-changing-view-scale-expected.txt: Added.
     32        * platform/ios/fast/viewport/ios/shrink-to-fit-for-page-without-viewport-meta-expected.txt: Added.
     33        * platform/ios/fast/viewport/ios/use-minimum-device-width-for-page-without-viewport-meta-expected.txt: Added.
     34        * platform/ios/fast/viewport/ios/width-is-device-width-expected.txt: Added.
     35        * platform/ios/fast/viewport/ios/width-is-device-width-overflowing-body-overflow-hidden-expected.txt: Added.
     36        * platform/ios/fast/viewport/ios/width-is-device-width-overflowing-body-overflow-hidden-tall-expected.txt: Added.
     37        * platform/ios/fast/viewport/ios/width-is-device-width-overflowing-expected.txt: Added.
     38        * platform/ios/fast/viewport/ios/width-is-device-width-overflowing-no-shrink-to-fit-expected.txt: Added.
     39        * platform/ios/imported/w3c/web-platform-tests/css/cssom/cssstyledeclaration-csstext-expected.txt:
     40        * platform/ios/imported/w3c/web-platform-tests/css/cssom/getComputedStyle-detached-subtree-expected.txt: Renamed from LayoutTests/platform/ios-wk2/imported/w3c/web-platform-tests/css/cssom/getComputedStyle-detached-subtree-expected.txt.
     41        * platform/ios-wk2/imported/w3c/web-platform-tests/html/semantics/interactive-elements/the-dialog-element/dialog-form-submission-expected.txt:
     42        * platform/ios/scrollingcoordinator/ios/fixed-in-frame-layer-reconcile-layer-position-expected.txt: Added.
     43        * platform/ios/scrollingcoordinator/ios/fixed-in-overflow-scroll-scrolling-tree-expected.txt: Added.
     44        * platform/ios/scrollingcoordinator/ios/fixed-scrolling-with-keyboard-expected.txt: Added.
     45        * platform/ios/scrollingcoordinator/ios/ui-scrolling-tree-expected.txt: Added.
     46
    1472021-10-25  Kyle Piddington  <kpiddington@apple.com>
    248

  • trunk/LayoutTests/platform/ios-wk2/TestExpectations

    r284848 r284855  
    21602160editing/selection/ios/hide-selection-in-tiny-contenteditable.html [ Pass Failure ]
    21612161
     2162# These tests fail/timeout on iPhone 12 simulator
     2163fast/events/ios/viewport-no-width-value-allows-double-tap.html [ Skip ]
     2164fast/visual-viewport/ios/stable-update-with-keyboard.html [ Skip ]
     2165media/modern-media-controls/media-documents/media-document-audio-ios-sizing.html [ Skip ]
     2166media/modern-media-controls/media-documents/media-document-video-iphone-sizing.html [ Skip ]
     2167fast/forms/ios/scroll-to-reveal-focused-select.html [ Failure ]
     2168fast/scrolling/ios/body-overflow-hidden-height-100-percent-zoomed-1.html [ Failure ]
     2169fast/scrolling/ios/overflow-div-scrolling.html [ Failure ]
     2170media/vp9.html [ Failure ]
     2171webgl/pending/conformance2/glsl3/empty-shader-with-output.html [ Failure ]
     2172
     2173# This test "fails" on iPhone 12 simulator because it supports P3, may need to rebaseline this reftest
     2174fast/media/mq-color-gamut.html [ ImageOnlyFailure ]
     2175
    21622176webkit.org/b/230004 imported/w3c/web-platform-tests/css/css-pseudo/active-selection-011.html [ ImageOnlyFailure ]
    21632177webkit.org/b/230004 imported/w3c/web-platform-tests/css/css-pseudo/active-selection-016.html [ ImageOnlyFailure ]

  • trunk/LayoutTests/platform/ios-wk2/imported/w3c/web-platform-tests/html/semantics/interactive-elements/the-dialog-element/dialog-form-submission-expected.txt

    r279943 r284855  
    1 Confirm
    2 
    31
    42PASS click the form submission button should close the dialog
    53PASS form submission should return correct value
    64PASS no returnValue when there's no result.
    7 FAIL input image button should return the coordinates assert_false: dialog should be closed now expected false got true
    8 FAIL formmethod attribute should use dialog form submission promise_test: Unhandled rejection with value: object "InvalidStateError: The object is in an invalid state."
    9 FAIL closing the dialog while submitting should stop the submission promise_test: Unhandled rejection with value: object "InvalidStateError: The object is in an invalid state."
    10 FAIL calling form.submit() in click handler of submit button should start the submission synchronously promise_test: Unhandled rejection with value: object "InvalidStateError: The object is in an invalid state."
     5FAIL input image button should return the coordinates assert_equals: returnValue should be the offsets of the click expected "" but got "sushi"
     6PASS formmethod attribute should use dialog form submission
     7PASS closing the dialog while submitting should stop the submission
     8PASS calling form.submit() in click handler of submit button should start the submission synchronously
    119

  • trunk/LayoutTests/platform/ios/compositing/backing/page-scale-overlap-in-iframe-expected.txt

    r284854 r284855  
    22(GraphicsLayer
    33  (anchor 0.00 0.00)
    4   (bounds 800.00 1370.00)
     4  (bounds 800.00 1635.00)
    55  (backingStoreAttached 1)
    66  (children 1
    77    (GraphicsLayer
    8       (bounds 800.00 1370.00)
     8      (bounds 800.00 1635.00)
    99      (contentsOpaque 1)
    1010      (backingStoreAttached 1)

  • trunk/LayoutTests/platform/ios/fast/scrolling/ios/clipping-ancestor-with-accelerated-scrolling-ancestor-expected.txt

    r209967 r284855  
    1 layer at (0,0) size 320x548
    2   RenderView at (0,0) size 320x548
    3 layer at (0,0) size 320x316
    4   RenderBlock {HTML} at (0,0) size 320x316
    5     RenderBody {BODY} at (8,8) size 304x300
     1layer at (0,0) size 390x797
     2  RenderView at (0,0) size 390x797
     3layer at (0,0) size 390x316
     4  RenderBlock {HTML} at (0,0) size 390x316
     5    RenderBody {BODY} at (8,8) size 374x300
    66layer at (8,8) size 300x300
    77  RenderBlock {DIV} at (0,0) size 300x300

  • trunk/LayoutTests/platform/ios/fast/scrolling/ios/overflow-scrolling-ancestor-clip-expected.txt

    r240941 r284855  
    11(GraphicsLayer
    22  (anchor 0.00 0.00)
    3   (bounds 320.00 548.00)
     3  (bounds 390.00 797.00)
    44  (children 1
    55    (GraphicsLayer
    6       (bounds 320.00 548.00)
     6      (bounds 390.00 797.00)
    77      (contentsOpaque 1)
    88      (children 1

  • trunk/LayoutTests/platform/ios/fast/scrolling/ios/overflow-scrolling-ancestor-clip-size-expected.txt

    r240941 r284855  
    11(GraphicsLayer
    22  (anchor 0.00 0.00)
    3   (bounds 330.00 548.00)
     3  (bounds 390.00 797.00)
    44  (children 1
    55    (GraphicsLayer
    6       (bounds 330.00 548.00)
     6      (bounds 390.00 797.00)
    77      (contentsOpaque 1)
    88      (children 1

  • trunk/LayoutTests/platform/ios/fast/scrolling/ios/scrolling-content-clip-to-viewport-expected.txt

    r244628 r284855  
    11(GraphicsLayer
    22  (anchor 0.00 0.00)
    3   (bounds 320.00 548.00)
     3  (bounds 390.00 797.00)
    44  (children 1
    55    (GraphicsLayer
    6       (bounds 320.00 548.00)
     6      (bounds 390.00 797.00)
    77      (contentsOpaque 1)
    88      (children 1

  • trunk/LayoutTests/platform/ios/fast/scrolling/ios/subpixel-overflow-scrolling-with-ancestor-expected.txt

    r284854 r284855  
    11(GraphicsLayer
    22  (anchor 0.00 0.00)
    3   (bounds 320.00 548.00)
     3  (bounds 390.00 797.00)
    44  (children 1
    55    (GraphicsLayer
    6       (bounds 320.00 548.00)
     6      (bounds 390.00 797.00)
    77      (contentsOpaque 1)
    88      (children 1
    99        (GraphicsLayer
    1010          (position 8.00 8.00)
    11           (bounds 302.00 402.00)
    12           (drawsContent 1)
     11          (bounds 300.00 400.00)
    1312          (children 1
    1413            (GraphicsLayer
    15               (offsetFromRenderer width=1 height=1)
    16               (position 1.00 1.00)
    1714              (bounds origin 0.00 30.00)
    1815              (bounds 300.00 400.00)
    1916              (children 1
    2017                (GraphicsLayer
    21                   (offsetFromRenderer width=1 height=1)
    2218                  (scrollOffset (0,30))
    2319                  (anchor 0.00 0.00)

  • trunk/LayoutTests/platform/ios/fast/scrolling/ios/touch-stacking-expected.txt

    r209967 r284855  
    1 layer at (0,0) size 320x548
    2   RenderView at (0,0) size 320x548
    3 layer at (0,0) size 320x148 layerType: background only
     1layer at (0,0) size 390x797
     2  RenderView at (0,0) size 390x797
     3layer at (0,0) size 390x148 layerType: background only
    44layer at (0,0) size 100x100
    55  RenderBlock (positioned) zI: -1 {DIV} at (0,0) size 100x100 [bgcolor=#FF0000]
    6 layer at (0,0) size 320x148 layerType: foreground only
    7   RenderBlock {HTML} at (0,0) size 320x148
    8     RenderBody {BODY} at (8,120) size 304x20
    9       RenderBlock {DIV} at (0,0) size 304x0
    10       RenderBlock {DIV} at (0,0) size 304x20
     6layer at (0,0) size 390x148 layerType: foreground only
     7  RenderBlock {HTML} at (0,0) size 390x148
     8    RenderBody {BODY} at (8,120) size 374x20
     9      RenderBlock {DIV} at (0,0) size 374x0
     10      RenderBlock {DIV} at (0,0) size 374x20
    1111        RenderText {#text} at (0,0) size 217x19
    1212          text run at (0,0) width 217: "PASS: computed zIndex was auto"

  • trunk/Tools/ChangeLog

    r284854 r284855  
     12021-10-25  Ryan Haddad  <ryanhaddad@apple.com>
     2
     3        Change default iOS simulator to one with a larger screen size
     4        https://bugs.webkit.org/show_bug.cgi?id=231844
     5
     6        Reviewed by Jonathan Bedard.
     7
     8        * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
     9        (RunTest.test_device_type_specific_listing):
     10        * Scripts/webkitpy/port/ios_simulator.py:
     11        (IOSSimulatorPort):
     12        (IPhoneSimulatorPort):
     13
    1142021-10-25  Alexey Proskuryakov  <ap@apple.com>
    215

  • trunk/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py

    r284845 r284855  
    940940
    941941        self.assertEqual(3, len(by_type.keys()))
    942         self.assertEqual(2, len(by_type[DeviceType.from_string('iPhone SE')]))
     942        self.assertEqual(2, len(by_type[DeviceType.from_string('iPhone 12')]))
    943943        self.assertEqual(1, len(by_type[DeviceType.from_string('iPad (5th generation)')]))
    944944        self.assertEqual(0, len(by_type[DeviceType.from_string('iPhone 7')]))

  • trunk/Tools/Scripts/webkitpy/port/ios_simulator.py

    r284072 r284855  
    4545
    4646    DEFAULT_DEVICE_TYPES = [
    47         DeviceType(hardware_family='iPhone', hardware_type='SE'),
     47        DeviceType(hardware_family='iPhone', hardware_type='12'),
    4848        DeviceType(hardware_family='iPad', hardware_type='(5th generation)'),
    4949        DeviceType(hardware_family='iPhone', hardware_type='7'),
    … …  
    120120    DEVICE_TYPE = DeviceType(hardware_family='iPhone')
    121121    DEFAULT_DEVICE_TYPES = [
    122         DeviceType(hardware_family='iPhone', hardware_type='SE'),
     122        DeviceType(hardware_family='iPhone', hardware_type='12'),
    123123        DeviceType(hardware_family='iPhone', hardware_type='7'),
    124124    ]
Note: See TracChangeset for help on using the changeset viewer.