Changeset 284867 in webkit

Timestamp:

Oct 26, 2021, 8:23:12 AM (5 years ago)

Author:

commit-queue@webkit.org

Message:

REGRESSION(242280@main) fast/mediastream/captureStream/canvas3d.html is timing out
​https://bugs.webkit.org/show_bug.cgi?id=231061
<rdar://problem/84012523>

Patch by Philippe Normand <​pnormand@igalia.com> on 2021-10-26
Reviewed by Xabier Rodriguez-Calvar.

Source/WebCore:

Implement WebGL canvas sampling for GStreamer ports.

• platform/graphics/opengl/GraphicsContextGLOpenGL.cpp:

(WebCore::GraphicsContextGLOpenGL::paintCompositedResultsToMediaSample):

LayoutTests:

• platform/glib/TestExpectations: Test is passing now. Unflag.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/platform/glib/TestExpectations (modified) (1 diff)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/platform/graphics/opengl/GraphicsContextGLOpenGL.cpp (modified) (2 diffs)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2021-10-26  Philippe Normand  <pnormand@igalia.com>
+
+        REGRESSION(242280@main) fast/mediastream/captureStream/canvas3d.html is timing out
+        https://bugs.webkit.org/show_bug.cgi?id=231061
+        <rdar://problem/84012523>
+
+        Reviewed by Xabier Rodriguez-Calvar.
+
+        * platform/glib/TestExpectations: Test is passing now. Unflag.
+
 2021-10-26  Antti Koivisto  <antti@apple.com>
 

trunk/LayoutTests/platform/glib/TestExpectations

@@ -681 +681 @@
 webkit.org/b/187603 fast/mediastream/media-stream-track-source-failure.html [ Timeout Failure Pass ]
 webkit.org/b/231057 fast/mediastream/media-stream-video-track-interrupted.html [ Failure ]
-webkit.org/b/231061 fast/mediastream/captureStream/canvas3d.html [ Timeout ]
 
 webkit.org/b/223508 imported/w3c/web-platform-tests/mediacapture-streams/MediaStream-MediaElement-srcObject.https.html [ Failure Pass ]

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2021-10-26  Philippe Normand  <pnormand@igalia.com>
+
+        REGRESSION(242280@main) fast/mediastream/captureStream/canvas3d.html is timing out
+        https://bugs.webkit.org/show_bug.cgi?id=231061
+        <rdar://problem/84012523>
+
+        Reviewed by Xabier Rodriguez-Calvar.
+
+        Implement WebGL canvas sampling for GStreamer ports.
+
+        * platform/graphics/opengl/GraphicsContextGLOpenGL.cpp:
+        (WebCore::GraphicsContextGLOpenGL::paintCompositedResultsToMediaSample):
+
 2021-10-26  Antti Koivisto  <antti@apple.com>
 

trunk/Source/WebCore/platform/graphics/opengl/GraphicsContextGLOpenGL.cpp

@@ -46 +46 @@
 #endif
 
+#if USE(GSTREAMER) && ENABLE(MEDIA_STREAM)
+#include "MediaSampleGStreamer.h"
+#endif
+
 namespace WebCore {
 
@@ -187 +191 @@
 RefPtr<MediaSample> GraphicsContextGLOpenGL::paintCompositedResultsToMediaSample()
 {
+#if USE(GSTREAMER)
+    if (auto pixelBuffer = readCompositedResults())
+        return MediaSampleGStreamer::createImageSample(WTFMove(*pixelBuffer));
+#endif
     return nullptr;
 }