Changeset 284891 in webkit

Timestamp:

Oct 26, 2021, 12:51:18 PM (5 years ago)

Author:

Simon Fraser

Message:

The script should decide when an image diff cases, not ImageDiff
​https://bugs.webkit.org/show_bug.cgi?id=232225

Unreviewed; respond to review feedback.

• Scripts/webkitpy/port/image_diff.py:

(ImageDiffer._read):

Location:

trunk/Tools

Files:

• ChangeLog (modified) (1 diff)
• Scripts/webkitpy/port/image_diff.py (modified) (1 diff)

trunk/Tools/ChangeLog

@@ +1 @@
+2021-10-26  Simon Fraser  <simon.fraser@apple.com>
+
+        The script should decide when an image diff cases, not ImageDiff
+        https://bugs.webkit.org/show_bug.cgi?id=232225
+
+        Unreviewed; respond to review feedback.
+
+        * Scripts/webkitpy/port/image_diff.py:
+        (ImageDiffer._read):
+
 2021-10-26  Alex Christensen  <achristensen@webkit.org>
 

trunk/Tools/Scripts/webkitpy/port/image_diff.py

@@ -135 +135 @@
         m = re.match(b'diff: (.+)%', diff_output)
         if not m:
-            return ImageDiffResult(passed=False, diff_image=None, difference=0, tolerance=self._tolerance, error_string=err_str or "Failed to match ImageDiff output %s" % diff_output)
+            return ImageDiffResult(passed=False, diff_image=None, difference=0, tolerance=self._tolerance, error_string=err_str or 'Failed to match ImageDiff output {}'.format(diff_output))
 
         diff_percent = float(string_utils.decode(m.group(1), target_type=str))