Changeset 284894 in webkit

Timestamp:

Oct 26, 2021, 2:07:13 PM (5 years ago)

Author:

Chris Dumez

Message:

html/semantics/embedded-content/the-img-element/adoption.html is timing out
​https://bugs.webkit.org/show_bug.cgi?id=232320

Reviewed by Darin Adler.

LayoutTests/imported/w3c:

Rebaseline WPT test that is now passing.

• web-platform-tests/html/semantics/embedded-content/the-img-element/adoption-expected.txt:

Source/WebCore:

When an <img> moves to a new document, we're supposed to update the image's data.
In HTMLImageElement::didMoveToNewDocument(), we would call HTMLPictureElement::sourcesChanged()
if the <img> element has a parent <picture> element, which would update the image's data.
However, in the absence of a parent <picture> element, we would do nothing. This patch calls
selectImageSource() when the <img> element as a src / srcset attribute to make sure the
image data gets updated.

No new tests, rebaselined existing test.

• html/HTMLImageElement.cpp:

(WebCore::HTMLImageElement::didMoveToNewDocument):

Location:

trunk

Files:

• LayoutTests/imported/w3c/ChangeLog (modified) (1 diff)
• LayoutTests/imported/w3c/web-platform-tests/html/semantics/embedded-content/the-img-element/adoption-expected.txt (modified) (1 diff)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/html/HTMLImageElement.cpp (modified) (1 diff)

trunk/LayoutTests/imported/w3c/ChangeLog

@@ +1 @@
+2021-10-26  Chris Dumez  <cdumez@apple.com>
+
+        html/semantics/embedded-content/the-img-element/adoption.html is timing out
+        https://bugs.webkit.org/show_bug.cgi?id=232320
+
+        Reviewed by Darin Adler.
+
+        Rebaseline WPT test that is now passing.
+
+        * web-platform-tests/html/semantics/embedded-content/the-img-element/adoption-expected.txt:
+
 2021-10-26  Chris Dumez  <cdumez@apple.com>
 

trunk/LayoutTests/imported/w3c/web-platform-tests/html/semantics/embedded-content/the-img-element/adoption-expected.txt

@@ -1 +1 @@
 
-Harness Error (TIMEOUT), message = null
-
-TIMEOUT img (src only) Test timed out
+PASS img (src only)
 PASS img (src only), parent is picture
 PASS img (src only), previous sibling is source
-TIMEOUT img (srcset 1 cand) Test timed out
+PASS img (srcset 1 cand)
 PASS img (srcset 1 cand), parent is picture
 PASS img (srcset 1 cand), previous sibling is source
-FAIL adopt a cloned img in template assert_equals: expected "http://localhost:8800/images/green-1x1.png" but got "/images/green-1x1.png"
+PASS adopt a cloned img in template
 PASS adoption is from appendChild
 

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2021-10-26  Chris Dumez  <cdumez@apple.com>
+
+        html/semantics/embedded-content/the-img-element/adoption.html is timing out
+        https://bugs.webkit.org/show_bug.cgi?id=232320
+
+        Reviewed by Darin Adler.
+
+        When an <img> moves to a new document, we're supposed to update the image's data.
+        In HTMLImageElement::didMoveToNewDocument(), we would call HTMLPictureElement::sourcesChanged()
+        if the <img> element has a parent <picture> element, which would update the image's data.
+        However, in the absence of a parent <picture> element, we would do nothing. This patch calls
+        selectImageSource() when the <img> element as a src / srcset attribute to make sure the
+        image data gets updated.
+
+        No new tests, rebaselined existing test.
+
+        * html/HTMLImageElement.cpp:
+        (WebCore::HTMLImageElement::didMoveToNewDocument):
+
 2021-10-26  Tim Horton  <timothy_horton@apple.com>
 

trunk/Source/WebCore/html/HTMLImageElement.cpp

@@ -684 +684 @@
     if (RefPtr element = pictureElement())
         element->sourcesChanged();
+    else if (hasAttribute(srcAttr) || hasAttribute(srcsetAttr))
+        selectImageSource(RelevantMutation::Yes);
 }