Changeset 285163 in webkit

Timestamp:

Nov 2, 2021, 9:37:09 AM (5 years ago)

Author:

Kate Cheney

Message:

​https://bugs.webkit.org/show_bug.cgi?id=232593
Remove isAppInitiated from _WKSessionState

Reviewed by Brent Fulgham.

Source/WebKit:

After ​https://bugs.webkit.org/show_bug.cgi?id=232486 we no longer need
the isAppInitiated value on _WKSessionState. It will be set
automatically when session state is retrieved.

No new tests. Confirmed by existing RestoreFromSessionState* API
tests.

• UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView _restoreSessionState:andNavigate:]):

• UIProcess/API/Cocoa/_WKSessionState.h:
• UIProcess/API/Cocoa/_WKSessionState.mm:

(-[_WKSessionState _sessionStateWithAppInitiatedValue]): Deleted.

• UIProcess/API/Cocoa/_WKSessionStateInternal.h:

Tools:

• TestWebKitAPI/Tests/WebKitCocoa/AppPrivacyReport.mm:

Location:

trunk

Files:

• Source/WebKit/ChangeLog (modified) (1 diff)
• Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm (modified) (1 diff)
• Source/WebKit/UIProcess/API/Cocoa/_WKSessionState.h (modified) (1 diff)
• Source/WebKit/UIProcess/API/Cocoa/_WKSessionState.mm (modified) (1 diff)
• Source/WebKit/UIProcess/API/Cocoa/_WKSessionStateInternal.h (modified) (1 diff)
• Tools/ChangeLog (modified) (1 diff)
• Tools/TestWebKitAPI/Tests/WebKitCocoa/AppPrivacyReport.mm (modified) (1 diff)

trunk/Source/WebKit/ChangeLog

@@ +1 @@
+2021-11-02  Kate Cheney  <katherine_cheney@apple.com>
+
+        https://bugs.webkit.org/show_bug.cgi?id=232593
+        Remove isAppInitiated from _WKSessionState
+
+        Reviewed by Brent Fulgham.
+
+        After https://bugs.webkit.org/show_bug.cgi?id=232486 we no longer need
+        the isAppInitiated value on _WKSessionState. It will be set
+        automatically when session state is retrieved.
+
+        No new tests. Confirmed by existing RestoreFromSessionState* API
+        tests.
+
+        * UIProcess/API/Cocoa/WKWebView.mm:
+        (-[WKWebView _restoreSessionState:andNavigate:]):
+        * UIProcess/API/Cocoa/_WKSessionState.h:
+        * UIProcess/API/Cocoa/_WKSessionState.mm:
+        (-[_WKSessionState _sessionStateWithAppInitiatedValue]): Deleted.
+        * UIProcess/API/Cocoa/_WKSessionStateInternal.h:
+
 2021-11-02  Chris Dumez  <cdumez@apple.com>
 

trunk/Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm

@@ -2647 +2647 @@
 {
     THROW_IF_SUSPENDED;
-    return wrapper(_page->restoreFromSessionState(sessionState ? sessionState._sessionStateWithAppInitiatedValue : WebKit::SessionState { }, navigate));
+    return wrapper(_page->restoreFromSessionState(sessionState ? sessionState->_sessionState : WebKit::SessionState { }, navigate));
 }
 

trunk/Source/WebKit/UIProcess/API/Cocoa/_WKSessionState.h

@@ -34 +34 @@
 
 @property (nonatomic, readonly, copy) NSData *data;
-@property (nonatomic) BOOL isAppInitiated;
 
 @end

trunk/Source/WebKit/UIProcess/API/Cocoa/_WKSessionState.mm

@@ -59 +59 @@
 }
 
-- (WebKit::SessionState)_sessionStateWithAppInitiatedValue
-{
-    _sessionState.isAppInitiated = _isAppInitiated;
-    return _sessionState;
-}
-
 @end

trunk/Source/WebKit/UIProcess/API/Cocoa/_WKSessionStateInternal.h

@@ -33 +33 @@
 }
 
-- (WebKit::SessionState)_sessionStateWithAppInitiatedValue;
 - (instancetype)_initWithSessionState:(WebKit::SessionState)sessionState;
 

trunk/Tools/ChangeLog

@@ +1 @@
+2021-11-02  Kate Cheney  <katherine_cheney@apple.com>
+
+        https://bugs.webkit.org/show_bug.cgi?id=232593
+        Remove isAppInitiated from _WKSessionState
+
+        Reviewed by Brent Fulgham.
+
+        * TestWebKitAPI/Tests/WebKitCocoa/AppPrivacyReport.mm:
+
 2021-11-02  Jonathan Bedard  <jbedard@apple.com>
 

trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/AppPrivacyReport.mm

@@ -747 +747 @@
 
     RetainPtr<_WKSessionState> sessionState = [webView1 _sessionState];
-    sessionState.get().isAppInitiated = isAppInitiated == IsAppInitiated::Yes ? true : false;
     [webView1 _close];