Changeset 285185 in webkit

Timestamp:

Nov 2, 2021, 2:50:51 PM (5 years ago)

Author:

don.olmstead@sony.com

Message:

[MSVC] Remove unused friend class in filter code
​https://bugs.webkit.org/show_bug.cgi?id=232636

Reviewed by Yusuke Suzuki.

In r284857 the WTF prefix was removed from ParallelJobs in filter code. During a
non-unified build MSVC thinks that there is a WebCore::ParallelJobs due to a friend
declaration in filter code and fails to build. Remove the friend declaration as they are
not used.

• platform/graphics/filters/FEGaussianBlur.h:
• platform/graphics/filters/FETurbulence.h:

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• platform/graphics/filters/FEGaussianBlur.h (modified) (1 diff)
• platform/graphics/filters/FETurbulence.h (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2021-11-02  Don Olmstead  <don.olmstead@sony.com>
+
+        [MSVC] Remove unused friend class in filter code
+        https://bugs.webkit.org/show_bug.cgi?id=232636
+
+        Reviewed by Yusuke Suzuki.
+
+        In r284857 the WTF prefix was removed from ParallelJobs in filter code. During a
+        non-unified build MSVC thinks that there is a WebCore::ParallelJobs due to a friend
+        declaration in filter code and fails to build. Remove the friend declaration as they are
+        not used.
+
+        * platform/graphics/filters/FEGaussianBlur.h:
+        * platform/graphics/filters/FETurbulence.h:
+
 2021-11-02  Antti Koivisto  <antti@apple.com>
 

trunk/Source/WebCore/platform/graphics/filters/FEGaussianBlur.h

@@ -52 +52 @@
     static const int s_minimalRectDimension = 100 * 100; // Empirical data limit for parallel jobs
 
-    template<typename Type>
-    friend class ParallelJobs;
-
     struct PlatformApplyParameters {
         FEGaussianBlur* filter;

trunk/Source/WebCore/platform/graphics/filters/FETurbulence.h

@@ -93 +93 @@
     };
 
-    template<typename Type>
-    friend class ParallelJobs;
-
     struct FillRegionParameters {
         FETurbulence* filter;