Changeset 285187 in webkit

Timestamp:

Nov 2, 2021, 3:09:25 PM (5 years ago)

Author:

commit-queue@webkit.org

Message:

Fails to execute JavaScript when soft stack limit is unlimited
​https://bugs.webkit.org/show_bug.cgi?id=232328

Patch by Michael Catanzaro <Michael Catanzaro> on 2021-11-02
Reviewed by Yusuke Suzuki.

Fall back to assuming an 8 MB stack limit when the real limit is unlimited. JSC needs to
have some maximum stack size to work with, and this is as good as any.

• wtf/StackBounds.cpp:

(WTF::StackBounds::currentThreadStackBoundsInternal):

Location:

trunk/Source/WTF

Files:

• ChangeLog (modified) (1 diff)
• wtf/StackBounds.cpp (modified) (2 diffs)

trunk/Source/WTF/ChangeLog

@@ +1 @@
+2021-11-02  Michael Catanzaro  <mcatanzaro@gnome.org>
+
+        Fails to execute JavaScript when soft stack limit is unlimited
+        https://bugs.webkit.org/show_bug.cgi?id=232328
+
+        Reviewed by Yusuke Suzuki.
+
+        Fall back to assuming an 8 MB stack limit when the real limit is unlimited. JSC needs to
+        have some maximum stack size to work with, and this is as good as any.
+
+        * wtf/StackBounds.cpp:
+        (WTF::StackBounds::currentThreadStackBoundsInternal):
+
 2021-11-02  Philip Chimento  <pchimento@igalia.com>
 

trunk/Source/WTF/wtf/StackBounds.cpp

@@ -66 +66 @@
         getrlimit(RLIMIT_STACK, &limit);
         rlim_t size = limit.rlim_cur;
+        if (size == RLIM_INFINITY)
+            size = 8 * MB;
         void* bound = static_cast<char*>(origin) - size;
         return StackBounds { origin, bound };
@@ -126 +128 @@
         getrlimit(RLIMIT_STACK, &limit);
         rlim_t size = limit.rlim_cur;
+        if (size == RLIM_INFINITY)
+            size = 8 * MB;
         // account for a guard page
         size -= static_cast<rlim_t>(sysconf(_SC_PAGESIZE));