Changeset 285200 in webkit

Timestamp:

Nov 3, 2021, 1:23:50 AM (5 years ago)

Author:

commit-queue@webkit.org

Message:

REGRESSION(r284603) [GTK][WPE] test fast/frames/flattening/scrolling-in-object.html fails
​https://bugs.webkit.org/show_bug.cgi?id=232627

Use UIHelper.waitForTargetScrollAnimationToSettle rather than a timeout to make the test reliable.

Patch by Arcady Goldmints-Orlov <Arcady Goldmints-Orlov> on 2021-11-03
Reviewed by Martin Robinson.

• fast/frames/flattening/scrolling-in-object.html:

Location:

trunk/LayoutTests

Files:

• ChangeLog (modified) (1 diff)
• fast/frames/flattening/scrolling-in-object.html (modified) (3 diffs)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2021-11-03  Arcady Goldmints-Orlov  <agoldmints@igalia.com>
+
+        REGRESSION(r284603) [GTK][WPE] test fast/frames/flattening/scrolling-in-object.html fails
+        https://bugs.webkit.org/show_bug.cgi?id=232627
+
+        Use UIHelper.waitForTargetScrollAnimationToSettle rather than a timeout to make the test reliable.
+
+        Reviewed by Martin Robinson.
+
+        * fast/frames/flattening/scrolling-in-object.html:
+
 2021-11-02  Gabriel Nava Marino  <gnavamarino@apple.com>
 

trunk/LayoutTests/fast/frames/flattening/scrolling-in-object.html

@@ -1 +1 @@
 <html>
     <head>
+        <script src="../../../resources/ui-helper.js"></script>
         <script type="text/javascript">
+            window.jsTestIsAsync = true;
             if (window.testRunner && window.internals) {
                 testRunner.waitUntilDone();
@@ -7 +9 @@
             }
 
-            function runTest()
+            async function runTest()
             {
                 if (window.eventSender && window.testRunner) {
@@ -15 +17 @@
                     eventSender.mouseMoveTo(startX, startY);
                     eventSender.mouseScrollBy(0, -4);
-                    setTimeout(function() {
-                        testRunner.notifyDone();
-                    }, 100);
+                    await UIHelper.waitForTargetScrollAnimationToSettle(element);
+                    testRunner.notifyDone();
                 }
             }