Changeset 285431 in webkit

Timestamp:

Nov 8, 2021, 2:16:44 PM (5 years ago)

Author:

Wenson Hsieh

Message:

WKSyntheticTapGestureRecognizer's action targets should be weak pointers
​https://bugs.webkit.org/show_bug.cgi?id=232812

Reviewed by Tim Horton.

Make WKSyntheticTapGestureRecognizer robust against the case where it outlives its WKContentView, by making its
"reset", "gesture identified", and "gesture failed" targets weak pointers instead of raw pointers.

• UIProcess/ios/WKSyntheticTapGestureRecognizer.mm:

(-[WKSyntheticTapGestureRecognizer lastTouchedScrollView]):

Drive-by fix: we can also make _lastTouchedScrollView use the weak ivar attribute instead of WeakObjCPtr,
now that weak is enabled in WebKit2.

Location:

trunk/Source/WebKit

Files:

• ChangeLog (modified) (1 diff)
• UIProcess/ios/WKSyntheticTapGestureRecognizer.mm (modified) (2 diffs)

trunk/Source/WebKit/ChangeLog

@@ +1 @@
+2021-11-08  Wenson Hsieh  <wenson_hsieh@apple.com>
+
+        WKSyntheticTapGestureRecognizer's action targets should be weak pointers
+        https://bugs.webkit.org/show_bug.cgi?id=232812
+
+        Reviewed by Tim Horton.
+
+        Make WKSyntheticTapGestureRecognizer robust against the case where it outlives its WKContentView, by making its
+        "reset", "gesture identified", and "gesture failed" targets weak pointers instead of raw pointers.
+
+        * UIProcess/ios/WKSyntheticTapGestureRecognizer.mm:
+        (-[WKSyntheticTapGestureRecognizer lastTouchedScrollView]):
+
+        Drive-by fix: we can also make `_lastTouchedScrollView` use the __weak ivar attribute instead of WeakObjCPtr,
+        now that __weak is enabled in WebKit2.
+
 2021-11-08  Devin Rousso  <drousso@apple.com>
 

trunk/Source/WebKit/UIProcess/ios/WKSyntheticTapGestureRecognizer.mm

@@ -31 +31 @@
 #import <UIKit/UIGestureRecognizerSubclass.h>
 #import <wtf/RetainPtr.h>
-#import <wtf/WeakObjCPtr.h>
 
 @implementation WKSyntheticTapGestureRecognizer {
-    id _gestureIdentifiedTarget;
+    __weak id _gestureIdentifiedTarget;
     SEL _gestureIdentifiedAction;
-    id _gestureFailedTarget;
+    __weak id _gestureFailedTarget;
     SEL _gestureFailedAction;
-    id _resetTarget;
+    __weak id _resetTarget;
     SEL _resetAction;
     RetainPtr<NSNumber> _lastActiveTouchIdentifier;
-    WeakObjCPtr<UIScrollView> _lastTouchedScrollView;
+    __weak UIScrollView *_lastTouchedScrollView;
 }
 
@@ -109 +108 @@
 - (UIScrollView *)lastTouchedScrollView
 {
-    return _lastTouchedScrollView.get().get();
+    return _lastTouchedScrollView;
 }