⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Changeset 285710 in webkit


Ignore:
Timestamp:
Nov 12, 2021, 2:50:47 AM (5 years ago)
Author:
Antti Koivisto
Message:

REGRESSION(r285624) Using revert keyword with a css variable hits assert
​https://bugs.webkit.org/show_bug.cgi?id=233031
rdar://85332271

Reviewed by Tim Horton.

Source/WebCore:

Test: fast/selectors/variable-revert-crash.html

  • style/StyleBuilderState.h:

Default initialization set the variable to a value that is not in the enumeration.

LayoutTests:

  • fast/selectors/variable-revert-crash-expected.txt: Added.
  • fast/selectors/variable-revert-crash.html: Added.
Location:
trunk
Files:
2 added
3 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r285709 r285710  
     12021-11-12  Antti Koivisto  <antti@apple.com>
     2
     3        REGRESSION(r285624) Using revert keyword with a css variable hits assert
     4        https://bugs.webkit.org/show_bug.cgi?id=233031
     5        rdar://85332271
     6
     7        Reviewed by Tim Horton.
     8
     9        * fast/selectors/variable-revert-crash-expected.txt: Added.
     10        * fast/selectors/variable-revert-crash.html: Added.
     11
    1122021-11-11  Sergio Villar Senin  <svillar@igalia.com>
    213

  • trunk/Source/WebCore/ChangeLog

    r285709 r285710  
     12021-11-12  Antti Koivisto  <antti@apple.com>
     2
     3        REGRESSION(r285624) Using revert keyword with a css variable hits assert
     4        https://bugs.webkit.org/show_bug.cgi?id=233031
     5        rdar://85332271
     6
     7        Reviewed by Tim Horton.
     8
     9        Test: fast/selectors/variable-revert-crash.html
     10
     11        * style/StyleBuilderState.h:
     12
     13        Default initialization set the variable to a value that is not in the enumeration.
     14
    1152021-11-11  Sergio Villar Senin  <svillar@igalia.com>
    216

  • trunk/Source/WebCore/style/StyleBuilderState.h

    r285624 r285710  
    136136    HashSet<String> m_inProgressPropertiesCustom;
    137137
    138     CascadeLevel m_cascadeLevel { };
     138    CascadeLevel m_cascadeLevel { CascadeLevel::Author };
    139139    ScopeOrdinal m_styleScopeOrdinal { };
    140140    CascadeLayerPriority m_cascadeLayerPriority { };
Note: See TracChangeset for help on using the changeset viewer.