Changeset 285742 in webkit

Timestamp:

Nov 12, 2021, 2:20:11 PM (5 years ago)

Author:

timothy@apple.com

Message:

Remove non-completionHandler version of -[WKWebView _loadServiceWorker:]
​https://bugs.webkit.org/show_bug.cgi?id=233069
rdar://problem/85355540

Reviewed by Chris Dumez.

• UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView _loadServiceWorker:]): Deleted.

• UIProcess/API/Cocoa/WKWebViewPrivate.h: Removed _loadServiceWorker:.

Location:

trunk/Source/WebKit

Files:

• ChangeLog (modified) (1 diff)
• UIProcess/API/Cocoa/WKWebView.mm (modified) (1 diff)
• UIProcess/API/Cocoa/WKWebViewPrivate.h (modified) (1 diff)

trunk/Source/WebKit/ChangeLog

@@ +1 @@
+2021-11-12  Timothy Hatcher  <timothy@apple.com>
+
+        Remove non-completionHandler version of -[WKWebView _loadServiceWorker:]
+        https://bugs.webkit.org/show_bug.cgi?id=233069
+        rdar://problem/85355540
+
+        Reviewed by Chris Dumez.
+
+        * UIProcess/API/Cocoa/WKWebView.mm:
+        (-[WKWebView _loadServiceWorker:]): Deleted.
+        * UIProcess/API/Cocoa/WKWebViewPrivate.h: Removed _loadServiceWorker:.
+
 2021-11-12  Peng Liu  <peng.liu6@apple.com>
 

trunk/Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm

@@ -2443 +2443 @@
 }
 
-- (void)_loadServiceWorker:(NSURL *)url
-{
-    [self _loadServiceWorker:url completionHandler:^(BOOL) { }];
-}
-
 - (void)_grantAccessToAssetServices
 {

trunk/Source/WebKit/UIProcess/API/Cocoa/WKWebViewPrivate.h

@@ -410 +410 @@
 - (void)_didLoadNonAppInitiatedRequest:(void (^)(BOOL result))completionHandler;
 
-- (void)_loadServiceWorker:(NSURL *)url WK_API_AVAILABLE(macos(WK_MAC_TBA), ios(WK_IOS_TBA)); // FIXME: Remove this once clients have adopted the version with a completion handler.
 - (void)_loadServiceWorker:(NSURL *)url completionHandler:(void (^)(BOOL success))completionHandler WK_API_AVAILABLE(macos(WK_MAC_TBA), ios(WK_IOS_TBA));