Changeset 285798 in webkit

Timestamp:

Nov 14, 2021, 8:22:34 PM (5 years ago)

Author:

Fujii Hironori

Message:

[GraphicsLayerWC] Incorrect compositing debug border color
​https://bugs.webkit.org/show_bug.cgi?id=233107

Reviewed by Don Olmstead.

GraphicsLayer::updateDebugIndicators() should be called after
changing some layer properties.

• WebProcess/WebPage/wc/GraphicsLayerWC.cpp:

(WebKit::GraphicsLayerWC::setMasksToBounds):
(WebKit::GraphicsLayerWC::setDrawsContent):
(WebKit::GraphicsLayerWC::setContentsToPlatformLayer):
(WebKit::GraphicsLayerWC::setBackdropFilters):
Call updateDebugIndicators.

Location:

trunk/Source/WebKit

Files:

• ChangeLog (modified) (1 diff)
• WebProcess/WebPage/wc/GraphicsLayerWC.cpp (modified) (4 diffs)

trunk/Source/WebKit/ChangeLog

@@ +1 @@
+2021-11-14  Fujii Hironori  <Hironori.Fujii@sony.com>
+
+        [GraphicsLayerWC] Incorrect compositing debug border color
+        https://bugs.webkit.org/show_bug.cgi?id=233107
+
+        Reviewed by Don Olmstead.
+
+        GraphicsLayer::updateDebugIndicators() should be called after
+        changing some layer properties.
+
+        * WebProcess/WebPage/wc/GraphicsLayerWC.cpp:
+        (WebKit::GraphicsLayerWC::setMasksToBounds):
+        (WebKit::GraphicsLayerWC::setDrawsContent):
+        (WebKit::GraphicsLayerWC::setContentsToPlatformLayer):
+        (WebKit::GraphicsLayerWC::setBackdropFilters):
+        Call updateDebugIndicators.
+
 2021-11-14  Simon Fraser  <simon.fraser@apple.com>
 

trunk/Source/WebKit/WebProcess/WebPage/wc/GraphicsLayerWC.cpp

@@ -214 +214 @@
     GraphicsLayer::setMasksToBounds(value);
     noteLayerPropertyChanged(WCLayerChange::MasksToBounds);
+    updateDebugIndicators();
 }
 
@@ -246 +247 @@
     GraphicsLayer::setDrawsContent(value);
     noteLayerPropertyChanged(WCLayerChange::BackingStore);
+    updateDebugIndicators();
 }
 
@@ -278 +280 @@
     m_platformLayer = platformLayer;
     noteLayerPropertyChanged(WCLayerChange::PlatformLayer);
+    updateDebugIndicators();
 }
 
@@ -346 +349 @@
         clearBackdropFilters();
     noteLayerPropertyChanged(WCLayerChange::BackdropFilters);
+    updateDebugIndicators();
     return canCompositeFilters;
 }