Changeset 285854 in webkit

Timestamp:

Nov 16, 2021, 1:46:49 AM (5 years ago)

Author:

cathiechen

Message:

[CSS contain] The size should be updated if layout containment is inside a fit-content parent
​https://bugs.webkit.org/show_bug.cgi?id=233046

Reviewed by Rob Buis.

Source/WebCore:

When the object is a layout containment, we also need to add size containment as the constraint of
being a relayout boundary. Otherwise when the layout size depends on the content, the layout size
might not be updated correctly.

Test: imported/w3c/web-platform-tests/css/css-contain/contain-layout-019.html

• rendering/RenderObject.cpp:

(WebCore::objectIsRelayoutBoundary):

LayoutTests:

• TestExpectations:

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/TestExpectations (modified) (1 diff)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/rendering/RenderObject.cpp (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2021-11-16  Cathie Chen  <cathiechen@igalia.com>
+
+        [CSS contain] The size should be updated if layout containment is inside a fit-content parent
+        https://bugs.webkit.org/show_bug.cgi?id=233046
+
+        Reviewed by Rob Buis.
+
+        * TestExpectations:
+
 2021-11-15  Tim Nguyen  <ntim@apple.com>
 

trunk/LayoutTests/TestExpectations

@@ -4843 +4843 @@
 imported/w3c/web-platform-tests/css/css-contain/contain-html-w-m-003.html [ ImageOnlyFailure ]
 imported/w3c/web-platform-tests/css/css-contain/contain-html-w-m-004.html [ ImageOnlyFailure ]
-imported/w3c/web-platform-tests/css/css-contain/contain-layout-019.html [ ImageOnlyFailure ]
 imported/w3c/web-platform-tests/css/css-contain/contain-paint-026.html [ ImageOnlyFailure ]
 

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2021-11-16  Cathie Chen  <cathiechen@igalia.com>
+
+        [CSS contain] The size should be updated if layout containment is inside a fit-content parent
+        https://bugs.webkit.org/show_bug.cgi?id=233046
+
+        Reviewed by Rob Buis.
+
+        When the object is a layout containment, we also need to add size containment as the constraint of
+        being a relayout boundary. Otherwise when the layout size depends on the content, the layout size
+        might not be updated correctly.
+
+        Test: imported/w3c/web-platform-tests/css/css-contain/contain-layout-019.html
+
+        * rendering/RenderObject.cpp:
+        (WebCore::objectIsRelayoutBoundary):
+
 2021-11-15  Sam Weinig  <weinig@apple.com>
 

trunk/Source/WebCore/rendering/RenderObject.cpp

@@ -506 +506 @@
         return true;
 
-    if (shouldApplyLayoutContainment(*object))
+    if (shouldApplyLayoutContainment(*object) && shouldApplySizeContainment(*object))
         return true;