Changeset 285932 in webkit

Timestamp:

Nov 17, 2021, 9:27:34 AM (5 years ago)

Author:

commit-queue@webkit.org

Message:

Fix formatting and string literals in FileInputType.cpp
​https://bugs.webkit.org/show_bug.cgi?id=233229

Patch by Andreu Botella <​andreu@andreubotella.com> on 2021-11-17
Reviewed by Darin Adler.

This change uses the emptyString() and defaultMIMEType() functions rather than using string
literals, fixes the coding style, and reverts an unnecessary change in the comments.

This fixes code review suggestions from ​https://bugs.webkit.org/show_bug.cgi?id=185416 and
​https://bugs.webkit.org/show_bug.cgi?id=221549

• html/FileInputType.cpp:

(WebCore::FileInputType::appendFormData const):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• html/FileInputType.cpp (modified) (2 diffs)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2021-11-17  Andreu Botella  <andreu@andreubotella.com>
+
+        Fix formatting and string literals in FileInputType.cpp
+        https://bugs.webkit.org/show_bug.cgi?id=233229
+
+        Reviewed by Darin Adler.
+
+        This change uses the emptyString() and defaultMIMEType() functions rather than using string
+        literals, fixes the coding style, and reverts an unnecessary change in the comments.
+
+        This fixes code review suggestions from https://bugs.webkit.org/show_bug.cgi?id=185416 and
+        https://bugs.webkit.org/show_bug.cgi?id=221549
+
+        * html/FileInputType.cpp:
+        (WebCore::FileInputType::appendFormData const):
+
 2021-11-17  Alan Bujtas  <zalan@apple.com>
 

trunk/Source/WebCore/html/FileInputType.cpp

@@ -172 +172 @@
 
         if (fileList->isEmpty())
-            formData.append(name, "");
+            formData.append(name, emptyString());
 
         for (auto& file : fileList->files())
@@ -179 +179 @@
     }
 
-    // If no filename at all is entered, return successful but empty, with
-    // application/octet-stream content type. Null would be more logical, but
-    // Netscape posts an empty file. Argh.
+    // If no filename at all is entered, return successful but empty.
+    // Null would be more logical, but Netscape posts an empty file. Argh.
     if (fileList->isEmpty()) {
         auto* document = element() ? &element()->document() : nullptr;
-        auto file = File::create(
-            document,
-            Blob::create(document, { }, "application/octet-stream"),
-            emptyString());
+        auto file = File::create(document, Blob::create(document, { }, defaultMIMEType()), emptyString());
         formData.append(name, file);
         return true;