Changeset 285952 in webkit

Timestamp:

Nov 17, 2021, 1:35:01 PM (5 years ago)

Author:

dino@apple.com

Message:

ANGLE build failure - sprintf is deprecated
​https://bugs.webkit.org/show_bug.cgi?id=233279

Reviewed by Wenson Hsieh.

Replace sprintf with snprintf.

• src/compiler/translator/TranslatorMetalDirect/IdGen.cpp:

(IdGen::createNewName):

• src/compiler/translator/TranslatorMetalDirect/ModifyStruct.cpp:
• src/compiler/translator/TranslatorMetalDirect/SymbolEnv.cpp:

(SymbolEnv::TemplateName::fullName const):

Location:

trunk/Source/ThirdParty/ANGLE

Files:

• ChangeLog (modified) (1 diff)
• src/compiler/translator/TranslatorMetalDirect/IdGen.cpp (modified) (1 diff)
• src/compiler/translator/TranslatorMetalDirect/ModifyStruct.cpp (modified) (1 diff)
• src/compiler/translator/TranslatorMetalDirect/SymbolEnv.cpp (modified) (2 diffs)

trunk/Source/ThirdParty/ANGLE/ChangeLog

@@ +1 @@
+2021-11-17  Dean Jackson  <dino@apple.com>
+
+        ANGLE build failure - sprintf is deprecated
+        https://bugs.webkit.org/show_bug.cgi?id=233279
+
+        Reviewed by Wenson Hsieh.
+
+        Replace sprintf with snprintf.
+
+        * src/compiler/translator/TranslatorMetalDirect/IdGen.cpp:
+        (IdGen::createNewName):
+        * src/compiler/translator/TranslatorMetalDirect/ModifyStruct.cpp:
+        * src/compiler/translator/TranslatorMetalDirect/SymbolEnv.cpp:
+        (SymbolEnv::TemplateName::fullName const):
+
 2021-11-06  David Kilzer  <ddkilzer@apple.com>
 

trunk/Source/ThirdParty/ANGLE/src/compiler/translator/TranslatorMetalDirect/IdGen.cpp

@@ -24 +24 @@
     const unsigned id = mNext++;
     char idBuffer[std::numeric_limits<unsigned>::digits10 + 1];
-    sprintf(idBuffer, "%u", id);
+    snprintf(idBuffer, sizeof(idBuffer), "%u", id);
 
     mNewNameBuffer.clear();

trunk/Source/ThirdParty/ANGLE/src/compiler/translator/TranslatorMetalDirect/ModifyStruct.cpp

@@ -598 +598 @@
     {
         char buffer[std::numeric_limits<unsigned>::digits10 + 1];
-        sprintf(buffer, "%u", extra);
+        snprintf(buffer, sizeof(buffer), "%u", extra);
         pushNamePath(buffer);
     }

trunk/Source/ThirdParty/ANGLE/src/compiler/translator/TranslatorMetalDirect/SymbolEnv.cpp

@@ -220 +220 @@
 
                 case TemplateArg::Kind::Int:
-                    sprintf(argBuffer, "%i", value.i);
+                    snprintf(argBuffer, sizeof(argBuffer), "%i", value.i);
                     buffer += argBuffer;
                     break;
 
                 case TemplateArg::Kind::UInt:
-                    sprintf(argBuffer, "%u", value.u);
+                    snprintf(argBuffer, sizeof(argBuffer), "%u", value.u);
                     buffer += argBuffer;
                     break;
@@ -242 +242 @@
                         if (type.isVector())
                         {
-                            sprintf(argBuffer, "%i", type.getNominalSize());
+                            snprintf(argBuffer, sizeof(argBuffer), "%i", type.getNominalSize());
                             buffer += argBuffer;
                         }
                         else if (type.isMatrix())
                         {
-                            sprintf(argBuffer, "%i", type.getCols());
+                            snprintf(argBuffer, sizeof(argBuffer), "%i", type.getCols());
                             buffer += argBuffer;
                             buffer += "x";
-                            sprintf(argBuffer, "%i", type.getRows());
+                            snprintf(argBuffer, sizeof(argBuffer), "%i", type.getRows());
                             buffer += argBuffer;
                         }