Changeset 285982 in webkit

Timestamp:

Nov 17, 2021, 10:26:50 PM (5 years ago)

Author:

commit-queue@webkit.org

Message:

When an "autofilled and viewable" field becomes empty, turn "autofilled and viewable" off
​https://bugs.webkit.org/show_bug.cgi?id=233239

Patch by Ricky Mondello <Ricky Mondello> on 2021-11-17
Reviewed by Darin Adler.

Source/WebCore:

Test: fast/forms/input-autofilled-and-viewable.html

• html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::setValueFromRenderer): Implement the fix.

• testing/Internals.cpp:

(WebCore::Internals::setValueFromRenderer): Added.

• testing/Internals.h: Declare a member function.

LayoutTests:

• fast/forms/input-autofilled-and-viewable-expected.txt: Added.
• fast/forms/input-autofilled-and-viewable.html: Added.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/fast/forms/input-autofilled-and-viewable-expected.txt (added)
• LayoutTests/fast/forms/input-autofilled-and-viewable.html (added)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/html/HTMLInputElement.cpp (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2021-11-17  Ricky Mondello  <rmondello@apple.com>
+
+        When an "autofilled and viewable" field becomes empty, turn "autofilled and viewable" off
+        https://bugs.webkit.org/show_bug.cgi?id=233239
+
+        Reviewed by Darin Adler.
+
+        * fast/forms/input-autofilled-and-viewable-expected.txt: Added.
+        * fast/forms/input-autofilled-and-viewable.html: Added.
+
 2021-11-17  John Wilander  <wilander@apple.com>
 

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2021-11-17  Ricky Mondello  <rmondello@apple.com>
+
+        When an "autofilled and viewable" field becomes empty, turn "autofilled and viewable" off
+        https://bugs.webkit.org/show_bug.cgi?id=233239
+
+        Reviewed by Darin Adler.
+
+        Test: fast/forms/input-autofilled-and-viewable.html
+
+        * html/HTMLInputElement.cpp:
+        (WebCore::HTMLInputElement::setValueFromRenderer): Implement the fix.
+        * testing/Internals.cpp:
+        (WebCore::Internals::setValueFromRenderer): Added.
+        * testing/Internals.h: Declare a member function.
+
 2021-11-17  Alex Christensen  <achristensen@webkit.org>
 

trunk/Source/WebCore/html/HTMLInputElement.cpp

@@ -1160 +1160 @@
     updateValidity();
 
-    // Clear auto fill flag (and yellow background) on user edit.
+    // We clear certain AutoFill flags here because this catches user edits.
     setAutoFilled(false);
+    if (m_isAutoFilledAndViewable && value.isEmpty())
+        setAutoFilledAndViewable(false);
 }