⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Changeset 285989 in webkit


Ignore:
Timestamp:
Nov 18, 2021, 1:41:56 AM (5 years ago)
Author:
svillar@igalia.com
Message:

[css-flexbox] Import WPT tests. November 2021 edition.
​https://bugs.webkit.org/show_bug.cgi?id=233197

Reviewed by Martin Robinson.

LayoutTests/imported/w3c:

  • web-platform-tests/css/css-flexbox/baseline-synthesis-001-expected.xht: Added.
  • web-platform-tests/css/css-flexbox/baseline-synthesis-001.html: Added.
  • web-platform-tests/css/css-flexbox/baseline-synthesis-002-expected.xht: Added.
  • web-platform-tests/css/css-flexbox/baseline-synthesis-002.html: Added.
  • web-platform-tests/css/css-flexbox/column-intrinsic-size-aspect-ratio-crash.html: Added.
  • web-platform-tests/css/css-flexbox/column-intrinsic-size-aspect-ratio-crash-expected.txt: Added.
  • web-platform-tests/css/css-flexbox/flex-aspect-ratio-img-column-011-expected.txt:
  • web-platform-tests/css/css-flexbox/flex-aspect-ratio-img-column-011.html:
  • web-platform-tests/css/css-flexbox/flex-aspect-ratio-img-row-016-expected.xht: Added.
  • web-platform-tests/css/css-flexbox/flex-aspect-ratio-img-row-016.html: Added.
  • web-platform-tests/css/css-flexbox/flex-minimum-height-flex-items-023.html:
  • web-platform-tests/css/css-flexbox/flex-minimum-width-flex-items-013.html:
  • web-platform-tests/css/css-flexbox/flexbox-align-self-vert-001-expected.xhtml:
  • web-platform-tests/css/css-flexbox/flexbox-align-self-vert-001.xhtml:
  • web-platform-tests/css/css-flexbox/flexbox-align-self-vert-rtl-001-expected.xhtml:
  • web-platform-tests/css/css-flexbox/flexbox-align-self-vert-rtl-001.xhtml:
  • web-platform-tests/css/css-flexbox/percentage-heights-016-expected.xht: Added.
  • web-platform-tests/css/css-flexbox/percentage-heights-016.html: Added.
  • web-platform-tests/css/css-flexbox/percentage-heights-017-expected.xht: Added.
  • web-platform-tests/css/css-flexbox/percentage-heights-017.html: Added.
  • web-platform-tests/css/css-flexbox/percentage-heights-018-expected.xht: Added.
  • web-platform-tests/css/css-flexbox/percentage-heights-018.html: Added.
  • web-platform-tests/css/css-flexbox/percentage-heights-019-expected.xht: Added.
  • web-platform-tests/css/css-flexbox/percentage-heights-019.html: Added.
  • web-platform-tests/css/css-flexbox/table-as-item-large-intrinsic-size-expected.xht: Added.
  • web-platform-tests/css/css-flexbox/table-as-item-large-intrinsic-size.html: Added.
  • web-platform-tests/css/css-flexbox/w3c-import.log:

LayoutTests:

Location:
trunk/LayoutTests
Files:
20 added
12 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r285987 r285989  
     12021-11-18  Sergio Villar Senin  <svillar@igalia.com>
     2
     3        [css-flexbox] Import WPT tests. November 2021 edition.
     4        https://bugs.webkit.org/show_bug.cgi?id=233197
     5
     6        Reviewed by Martin Robinson.
     7
     8        * TestExpectations: Added tests that fail since the import.
     9
    1102021-11-18  Ziran Sun  <zsun@igalia.com>
    211

  • trunk/LayoutTests/TestExpectations

    r285987 r285989  
    42364236webkit.org/b/212046 imported/w3c/web-platform-tests/css/css-flexbox/scrollbars.html [ ImageOnlyFailure ]
    42374237
     4238# Used flex-basis should be used to compute definiteness instead of specified.
     4239webkit.org/b/233196 imported/w3c/web-platform-tests/css/css-flexbox/percentage-heights-016.html [ ImageOnlyFailure ]
     4240webkit.org/b/233196 imported/w3c/web-platform-tests/css/css-flexbox/percentage-heights-017.html [ ImageOnlyFailure ]
     4241webkit.org/b/233196 imported/w3c/web-platform-tests/css/css-flexbox/percentage-heights-018.html [ ImageOnlyFailure ]
     4242
    42384243# Static position alignment in Flexbox.
    42394244webkit.org/b/221472 imported/w3c/web-platform-tests/css/css-flexbox/abspos/flex-abspos-staticpos-align-self-safe-001.html [ ImageOnlyFailure ]
    … …  
    42564261
    42574262# align baseline in flexbox.
     4263webkit.org/b/221478 imported/w3c/web-platform-tests/css/css-flexbox/baseline-synthesis-001.html [ ImageOnlyFailure ]
    42584264webkit.org/b/221478 imported/w3c/web-platform-tests/css/css-flexbox/flexbox-align-self-baseline-horiz-001a.xhtml [ ImageOnlyFailure ]
    42594265webkit.org/b/221478 imported/w3c/web-platform-tests/css/css-flexbox/flexbox-align-self-baseline-horiz-001b.xhtml [ ImageOnlyFailure ]
    … …  
    42784284
    42794285# min-size:auto in flexbox.
     4286webkit.org/b/221481 imported/w3c/web-platform-tests/css/css-flexbox/flex-minimum-height-flex-items-023.html [ ImageOnlyFailure ]
    42804287webkit.org/b/221481 imported/w3c/web-platform-tests/css/css-flexbox/flex-minimum-height-flex-items-029.html [ ImageOnlyFailure ]
     4288webkit.org/b/221481 imported/w3c/web-platform-tests/css/css-flexbox/flex-minimum-width-flex-items-013.html [ ImageOnlyFailure ]
    42814289webkit.org/b/221481 imported/w3c/web-platform-tests/css/css-flexbox/flex-minimum-width-flex-items-015.html [ ImageOnlyFailure ]
    42824290

  • trunk/LayoutTests/imported/w3c/ChangeLog

    r285984 r285989  
     12021-11-18  Sergio Villar Senin  <svillar@igalia.com>
     2
     3        [css-flexbox] Import WPT tests. November 2021 edition.
     4        https://bugs.webkit.org/show_bug.cgi?id=233197
     5
     6        Reviewed by Martin Robinson.
     7
     8        * web-platform-tests/css/css-flexbox/baseline-synthesis-001-expected.xht: Added.
     9        * web-platform-tests/css/css-flexbox/baseline-synthesis-001.html: Added.
     10        * web-platform-tests/css/css-flexbox/baseline-synthesis-002-expected.xht: Added.
     11        * web-platform-tests/css/css-flexbox/baseline-synthesis-002.html: Added.
     12        * web-platform-tests/css/css-flexbox/column-intrinsic-size-aspect-ratio-crash.html: Added.
     13        * web-platform-tests/css/css-flexbox/column-intrinsic-size-aspect-ratio-crash-expected.txt: Added.
     14        * web-platform-tests/css/css-flexbox/flex-aspect-ratio-img-column-011-expected.txt:
     15        * web-platform-tests/css/css-flexbox/flex-aspect-ratio-img-column-011.html:
     16        * web-platform-tests/css/css-flexbox/flex-aspect-ratio-img-row-016-expected.xht: Added.
     17        * web-platform-tests/css/css-flexbox/flex-aspect-ratio-img-row-016.html: Added.
     18        * web-platform-tests/css/css-flexbox/flex-minimum-height-flex-items-023.html:
     19        * web-platform-tests/css/css-flexbox/flex-minimum-width-flex-items-013.html:
     20        * web-platform-tests/css/css-flexbox/flexbox-align-self-vert-001-expected.xhtml:
     21        * web-platform-tests/css/css-flexbox/flexbox-align-self-vert-001.xhtml:
     22        * web-platform-tests/css/css-flexbox/flexbox-align-self-vert-rtl-001-expected.xhtml:
     23        * web-platform-tests/css/css-flexbox/flexbox-align-self-vert-rtl-001.xhtml:
     24        * web-platform-tests/css/css-flexbox/percentage-heights-016-expected.xht: Added.
     25        * web-platform-tests/css/css-flexbox/percentage-heights-016.html: Added.
     26        * web-platform-tests/css/css-flexbox/percentage-heights-017-expected.xht: Added.
     27        * web-platform-tests/css/css-flexbox/percentage-heights-017.html: Added.
     28        * web-platform-tests/css/css-flexbox/percentage-heights-018-expected.xht: Added.
     29        * web-platform-tests/css/css-flexbox/percentage-heights-018.html: Added.
     30        * web-platform-tests/css/css-flexbox/percentage-heights-019-expected.xht: Added.
     31        * web-platform-tests/css/css-flexbox/percentage-heights-019.html: Added.
     32        * web-platform-tests/css/css-flexbox/table-as-item-large-intrinsic-size-expected.xht: Added.
     33        * web-platform-tests/css/css-flexbox/table-as-item-large-intrinsic-size.html: Added.
     34        * web-platform-tests/css/css-flexbox/w3c-import.log:
     35
    1362021-11-17  Youenn Fablet  <youenn@apple.com>
    237

  • trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-flexbox/flex-aspect-ratio-img-column-011-expected.txt

    r273072 r285989  
    66PASS .flexbox 5
    77PASS .flexbox 6
    8 PASS .flexbox 7
     8FAIL .flexbox 7 assert_equals:
     9<div class="flexbox column" style="height: 10px; width: 50px;" data-expected-height="10">
     10    <!-- should use min(specified=100, content height=50) = 50px as minimum height,
     11         which the image will shrink to due to default flex-shrink. -->
     12    <img src="support/10x10-green.png" style="height: 100px;" data-expected-height="50">
     13</div>
     14height expected 50 but got 10
    915PASS .flexbox 8
    1016PASS .flexbox 9

  • trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-flexbox/flex-aspect-ratio-img-column-011.html

    r270237 r285989  
    5353</div>
    5454
    55 <div class="flexbox column" style="height: 10px;" data-expected-height="10">
    56     <!-- should use min(specified, content height) = 10px as minimum height,
     55<div class="flexbox column" style="height: 10px; width: 50px;" data-expected-height="10">
     56    <!-- should use min(specified=100, content height=50) = 50px as minimum height,
    5757         which the image will shrink to due to default flex-shrink. -->
    58     <img src="support/10x10-green.png" style="height: 100px;" data-expected-height="10">
     58    <img src="support/10x10-green.png" style="height: 100px;" data-expected-height="50">
    5959</div>
    6060

  • trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-flexbox/flex-minimum-height-flex-items-023.html

    r264335 r285989  
    2828   this item has a specified size.
    2929
    30 5. content size suggestion = 150, because 150 is the min-content size in the
    31    main axis.
     305. content size suggestion = 50px because the stretched width of 100px is sent
     31   through the 2:1 aspect ratio to determine the image's min-content size in the
     32   block axis.
     33
     34   5a. This flex container qualifies for 9.8.3:
     35
     36     If a single-line flex container has a definite cross size, the automatic
     37     preferred outer cross size of any stretched flex items is the flex
     38     container's inner cross size (clamped to the flex item's min and max cross
     39     size) and is considered definite.
     40
     41     So the preferred width of the image is 100px.
     42   5b. The float specified by the min-content calculation from css-sizing 5.1 is
     43     <img src="support/300x150-green.png" style="width: 100px; float: left;" />
     44     This element gets height 50px.
    3245
    33466. specified size suggestion = 100px because that's what's specified.
    3447
    35 7. So content-based min size = min(150, 100) = 100px. That becomes its flexed
     487. So content-based min size = min(50, 100) = 50px. That becomes its flexed
    3649   height (see #1).
    3750
    … …  
    4053   https://drafts.csswg.org/css-flexbox/#algo-stretch, which says "Note that
    4154   this step does not affect the main size of the flex item, even if it has an
    42    intrinsic aspect ratio." The height remains 100px.
     55   intrinsic aspect ratio." The height remains 50px.
     56-->
    4357
    44 FF 77 gives the item height of 50px. It's probably due to a disagreement in #8;
    45 I think FF applies the aspect ratio of the new stretched width to get a height.
    46 But it might be a disagreement in #4.
    47 
    48 Chrome <= 83 gives the item height 150 because it doesn't treat
    49 min-height:min-content as min-height:auto. That makes the used min-height be
    50 150px. That might change in Chrome 84 or 85 when FlexNG launches.
    51 
    52 -->
     58<div style="height: 50px; width: 100px; background: green;"></div>
    5359<div style="display: flex; flex-direction: column; width:100px; height: 0px;">
    54   <img src="support/300x150-green.png" style="display: flex; min-height: min-content; height: 100px;" />
     60  <img src="support/300x150-green.png" style="min-height: min-content; height: 100px;" />
    5561</div>

  • trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-flexbox/flex-minimum-width-flex-items-013.html

    r272644 r285989  
    55<link rel="help" href="https://github.com/w3c/csswg-drafts/issues/5663" />
    66<link rel="match" href="../reference/ref-filled-green-100px-square.xht" />
    7 <meta name="assert" content="min-width: auto ignores transferred size suggestion when item has a definite specified main size">
     7<meta name="assert" content="content size suggestion of a replaced aspect-ratio item accounts for definition stretched cross size">
    88
    99<style>
    … …  
    2020
    2121<div id="reference-overlapped-red"></div>
    22 <div style="width:100px; height: 75px; background: green;"></div>
    23 <div style="display: flex; width: 0px; height: 25px;">
     22<div style="width:100px; height: 50px; background: green;"></div> <!-- This just completes the green square. -->
     23<div style="display: flex; width: 0px; height: 50px;">
    2424  <!--
    25     content size suggestion is 300px
    26     specified size suggestion is 100px
     25    content size suggestion is 100px because the image has a stretched height of 50px. So min-content size of the image is 300x150/50 = 100.
     26    specified size suggestion is 150px
     27    transferred size suggestion is 100px
    2728
    28     Chrome 87 and Firefox 84a1 disagree about transferred size suggestion here
    29     (Chrome says undefined. Firefox says 300/150 * 25 = 50. See spec issue
    30     above.) but it doesn't matter: this test asserts that the transferred size
    31     suggestion is ignored, because of this from the spec (capitalization
    32     added):
     29    transferred size suggestion is ignored because there is a specified size.
    3330
    34     In general, the content-based minimum size of a flex item is the smaller of
    35     its content size suggestion and its specified size suggestion. However, if
    36     the box has an aspect ratio AND NO specified size, its content-based
    37     minimum size is the smaller of its content size suggestion and its
    38     transferred size suggestion.
    39 
    40     So here the content-based minimum size is min(300, 100) = 100.
     31    So here the content-based minimum size is min(100px, 150px) = 100px
    4132  -->
    42   <img src="support/300x150-green.png" style="width: 100px;">
     33  <img src="support/300x150-green.png" style="width: 999px;">
    4334</div>

  • trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-flexbox/flexbox-align-self-vert-001-expected.xhtml

    r272644 r285989  
    1313    <style>
    1414      .flexbox {
    15         border: 1px dashed blue;
     15        border: 1px solid blue;
    1616        width: 200px;
    1717        font-size: 10px;

  • trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-flexbox/flexbox-align-self-vert-001.xhtml

    r272644 r285989  
    1414    <style>
    1515      .flexbox {
    16         border: 1px dashed blue;
     16        border: 1px solid blue;
    1717        width: 200px;
    1818        display: flex;

  • trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-flexbox/flexbox-align-self-vert-rtl-001-expected.xhtml

    r272644 r285989  
    1414    <style>
    1515      .flexbox {
    16         border: 1px dashed blue;
     16        border: 1px solid blue;
    1717        width: 200px;
    1818        direction: rtl;

  • trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-flexbox/flexbox-align-self-vert-rtl-001.xhtml

    r272644 r285989  
    1515    <style>
    1616      .flexbox {
    17         border: 1px dashed blue;
     17        border: 1px solid blue;
    1818        width: 200px;
    1919        display: flex;

  • trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-flexbox/w3c-import.log

    r283494 r285989  
    138138/LayoutTests/imported/w3c/web-platform-tests/css/css-flexbox/auto-margins-003-expected.html
    139139/LayoutTests/imported/w3c/web-platform-tests/css/css-flexbox/auto-margins-003.html
     140/LayoutTests/imported/w3c/web-platform-tests/css/css-flexbox/baseline-synthesis-001-expected.xht
     141/LayoutTests/imported/w3c/web-platform-tests/css/css-flexbox/baseline-synthesis-001.html
     142/LayoutTests/imported/w3c/web-platform-tests/css/css-flexbox/baseline-synthesis-002-expected.xht
     143/LayoutTests/imported/w3c/web-platform-tests/css/css-flexbox/baseline-synthesis-002.html
    140144/LayoutTests/imported/w3c/web-platform-tests/css/css-flexbox/box-sizing-001.html
    141145/LayoutTests/imported/w3c/web-platform-tests/css/css-flexbox/box-sizing-min-max-sizes-001.html
    … …  
    292296/LayoutTests/imported/w3c/web-platform-tests/css/css-flexbox/flex-aspect-ratio-img-row-015-expected.html
    293297/LayoutTests/imported/w3c/web-platform-tests/css/css-flexbox/flex-aspect-ratio-img-row-015.html
     298/LayoutTests/imported/w3c/web-platform-tests/css/css-flexbox/flex-aspect-ratio-img-row-016-expected.xht
     299/LayoutTests/imported/w3c/web-platform-tests/css/css-flexbox/flex-aspect-ratio-img-row-016.html
    294300/LayoutTests/imported/w3c/web-platform-tests/css/css-flexbox/flex-basis-001-expected.xht
    295301/LayoutTests/imported/w3c/web-platform-tests/css/css-flexbox/flex-basis-001.html
    … …  
    16001606/LayoutTests/imported/w3c/web-platform-tests/css/css-flexbox/percentage-heights-015-expected.html
    16011607/LayoutTests/imported/w3c/web-platform-tests/css/css-flexbox/percentage-heights-015.html
     1608/LayoutTests/imported/w3c/web-platform-tests/css/css-flexbox/percentage-heights-016-expected.xht
     1609/LayoutTests/imported/w3c/web-platform-tests/css/css-flexbox/percentage-heights-016.html
     1610/LayoutTests/imported/w3c/web-platform-tests/css/css-flexbox/percentage-heights-017-expected.xht
     1611/LayoutTests/imported/w3c/web-platform-tests/css/css-flexbox/percentage-heights-017.html
     1612/LayoutTests/imported/w3c/web-platform-tests/css/css-flexbox/percentage-heights-018-expected.xht
     1613/LayoutTests/imported/w3c/web-platform-tests/css/css-flexbox/percentage-heights-018.html
     1614/LayoutTests/imported/w3c/web-platform-tests/css/css-flexbox/percentage-heights-019-expected.xht
     1615/LayoutTests/imported/w3c/web-platform-tests/css/css-flexbox/percentage-heights-019.html
    16021616/LayoutTests/imported/w3c/web-platform-tests/css/css-flexbox/percentage-margins-001.html
    16031617/LayoutTests/imported/w3c/web-platform-tests/css/css-flexbox/percentage-max-height-001-expected.xht
    … …  
    16961710/LayoutTests/imported/w3c/web-platform-tests/css/css-flexbox/table-as-item-inflexible-in-row-2-expected.html
    16971711/LayoutTests/imported/w3c/web-platform-tests/css/css-flexbox/table-as-item-inflexible-in-row-2.html
     1712/LayoutTests/imported/w3c/web-platform-tests/css/css-flexbox/table-as-item-large-intrinsic-size-expected.xht
     1713/LayoutTests/imported/w3c/web-platform-tests/css/css-flexbox/table-as-item-large-intrinsic-size.html
    16981714/LayoutTests/imported/w3c/web-platform-tests/css/css-flexbox/table-as-item-min-content-height-1.tentative-expected.xht
    16991715/LayoutTests/imported/w3c/web-platform-tests/css/css-flexbox/table-as-item-min-content-height-1.tentative.html
Note: See TracChangeset for help on using the changeset viewer.