Changeset 286024 in webkit

Timestamp:

Nov 18, 2021, 1:14:07 PM (5 years ago)

Author:

Alan Bujtas

Message:

[IFC][Integration] Switching line layout path should invalidate preferred width
​https://bugs.webkit.org/show_bug.cgi?id=233324

Reviewed by Antti Koivisto.

Since we don't propagate intrinsic width values between the line layout codepaths, switching
should invalidate these dirty bits.

• rendering/RenderBlockFlow.cpp:

(WebCore::RenderBlockFlow::invalidateLineLayoutPath):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• rendering/RenderBlockFlow.cpp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2021-11-18  Alan Bujtas  <zalan@apple.com>
+
+        [IFC][Integration] Switching line layout path should invalidate preferred width
+        https://bugs.webkit.org/show_bug.cgi?id=233324
+
+        Reviewed by Antti Koivisto.
+
+        Since we don't propagate intrinsic width values between the line layout codepaths, switching
+        should invalidate these dirty bits.
+
+        * rendering/RenderBlockFlow.cpp:
+        (WebCore::RenderBlockFlow::invalidateLineLayoutPath):
+
 2021-11-18  Wenson Hsieh  <wenson_hsieh@apple.com>
 

trunk/Source/WebCore/rendering/RenderBlockFlow.cpp

@@ -3683 +3683 @@
             path = ForcedLegacyPath;
 #endif
+#if ENABLE_MODERN_PREFERRED_WIDTH_COMPUTATION
+        for (auto walker = InlineWalker(*this); !walker.atEnd(); walker.advance())
+            walker.current()->setPreferredLogicalWidthsDirty(true);
+#endif
         m_lineLayout = std::monostate();
         setLineLayoutPath(path);