⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Changeset 286060 in webkit


Ignore:
Timestamp:
Nov 19, 2021, 7:01:50 AM (5 years ago)
Author:
Angelos Oikonomopoulos
Message:

[JSC] Workaround for failing mips tests
​https://bugs.webkit.org/show_bug.cgi?id=233359

Reviewed by Adrian Perez de Castro.

.:

Add a compiler flag on GCC+mips to work around a code generation bug
resulting in SIGBUS. This only manifests when running 32-bit mips code
on mips64 hardware (which the buildbots do).

  • Source/cmake/WebKitCompilerFlags.cmake:

JSTests:

Re-enable tests skipped on mips after adding workaround.

  • stress/call-varargs-double-new-array-buffer.js:
  • stress/callee-save-fpr.js:
  • stress/forward-varargs-double-new-array-buffer.js:
  • stress/new-array-with-spread-cow-double.js:
  • stress/new-array-with-spread-double-new-array-buffer.js:
  • stress/spread-escapes-but-new-array-buffer-does-not-double.js:

PerformanceTests:

Re-enable tests skipped on mips after adding workaround.

  • ARES-6/Basic/basic-tests.yaml:
Location:
trunk
Files:
11 edited

Legend:

Unmodified
Added
Removed

  • trunk/ChangeLog

    r286011 r286060  
     12021-11-19  Angelos Oikonomopoulos  <angelos@igalia.com>
     2
     3        [JSC] Workaround for failing mips tests
     4        https://bugs.webkit.org/show_bug.cgi?id=233359
     5
     6        Reviewed by Adrian Perez de Castro.
     7
     8        Add a compiler flag on GCC+mips to work around a code generation bug
     9        resulting in SIGBUS. This only manifests when running 32-bit mips code
     10        on mips64 hardware (which the buildbots do).
     11
     12        * Source/cmake/WebKitCompilerFlags.cmake:
     13
    1142021-11-18  Yoshiaki Jitsukawa  <yoshiaki.jitsukawa@sony.com>
    215

  • trunk/JSTests/ChangeLog

    r285978 r286060  
     12021-11-19  Angelos Oikonomopoulos  <angelos@igalia.com>
     2
     3        [JSC] Workaround for failing mips tests
     4        https://bugs.webkit.org/show_bug.cgi?id=233359
     5
     6        Reviewed by Adrian Perez de Castro.
     7
     8        Re-enable tests skipped on mips after adding workaround.
     9
     10        * stress/call-varargs-double-new-array-buffer.js:
     11        * stress/callee-save-fpr.js:
     12        * stress/forward-varargs-double-new-array-buffer.js:
     13        * stress/new-array-with-spread-cow-double.js:
     14        * stress/new-array-with-spread-double-new-array-buffer.js:
     15        * stress/spread-escapes-but-new-array-buffer-does-not-double.js:
     16
    1172021-11-17  Yusuke Suzuki  <ysuzuki@apple.com>
    218

  • trunk/JSTests/stress/call-varargs-double-new-array-buffer.js

    r285817 r286060  
    1 //@ skip if ["mips"].include?($architecture)
    21function assert(b, m = "") {
    32    if (!b)

  • trunk/JSTests/stress/callee-save-fpr.js

    r285817 r286060  
    1 //@ skip if ["mips"].include?($architecture)
    21'use strict';
    32

  • trunk/JSTests/stress/forward-varargs-double-new-array-buffer.js

    r285817 r286060  
    1 //@ skip if ["mips"].include?($architecture)
    21"use strict";
    32

  • trunk/JSTests/stress/new-array-with-spread-cow-double.js

    r285817 r286060  
    1 //@ skip if ["mips"].include?($architecture)
    21function shouldBe(actual, expected) {
    32    if (actual !== expected)

  • trunk/JSTests/stress/new-array-with-spread-double-new-array-buffer.js

    r285817 r286060  
    1 //@ skip if ["mips"].include?($architecture)
    21function shouldBe(actual, expected)
    32{

  • trunk/JSTests/stress/spread-escapes-but-new-array-buffer-does-not-double.js

    r285817 r286060  
    1 //@ skip if ["mips"].include?($architecture)
    21function assert(b) {
    32    if (!b)

  • trunk/PerformanceTests/ARES-6/Basic/basic-tests.yaml

    r285817 r286060  
    2525  tests:
    2626    - stress-test.js
    27   cmd: |
    28     if ["mips"].include?($architecture)
    29         skip
    30     else
    31         defaultRunNoisyTest unless parseRunCommands
    32     end
     27  cmd: defaultRunNoisyTest unless parseRunCommands
    3328

  • trunk/PerformanceTests/ChangeLog

    r285817 r286060  
     12021-11-19  Angelos Oikonomopoulos  <angelos@igalia.com>
     2
     3        [JSC] Workaround for failing mips tests
     4        https://bugs.webkit.org/show_bug.cgi?id=233359
     5
     6        Reviewed by Adrian Perez de Castro.
     7
     8        Re-enable tests skipped on mips after adding workaround.
     9
     10        * ARES-6/Basic/basic-tests.yaml:
     11
    1122021-11-15  Angelos Oikonomopoulos  <angelos@igalia.com>
    213

  • trunk/Source/cmake/WebKitCompilerFlags.cmake

    r285652 r286060  
    327327    unset(CMAKE_REQUIRED_FLAGS)
    328328endif ()
     329
     330if (CMAKE_CXX_COMPILER_ID MATCHES "GNU" AND WTF_CPU_MIPS)
     331    # Work around https://gcc.gnu.org/bugzilla/show_bug.cgi?id=78176.
     332    # This only manifests when executing 32-bit code on a 64-bit
     333    # processor. This is a workaround and does not cover all cases
     334    # (see comment #28 in the link above).
     335    WEBKIT_PREPEND_GLOBAL_COMPILER_FLAGS(-mno-lxc1-sxc1)
     336endif ()
Note: See TracChangeset for help on using the changeset viewer.