Changeset 286070 in webkit

Timestamp:

Nov 19, 2021, 11:36:35 AM (5 years ago)

Author:

sbarati@apple.com

Message:

Fix assertion added in r285592
​https://bugs.webkit.org/show_bug.cgi?id=233373
JSTests:

Reviewed by Keith Miller.

• stress/validate-assert-uid-is-not-index-or-it-is-symbol.js: Added.

(main.v11):
(main.v29):
(main):

Source/JavaScriptCore:

rdar://85451012

Reviewed by Keith Miller.

The assertion added in r285592 should not apply to Symbols. This patch
fixes that error. We don't care if a Symbol can be parsed as an index
since the string value in a Symbol is just its description, not the
actual property.

• dfg/DFGValidate.cpp:

Location:

trunk

Files:

• JSTests/ChangeLog (modified) (1 diff)
• JSTests/stress/validate-assert-uid-is-not-index-or-it-is-symbol.js (added)
• Source/JavaScriptCore/ChangeLog (modified) (1 diff)
• Source/JavaScriptCore/dfg/DFGValidate.cpp (modified) (1 diff)

trunk/JSTests/ChangeLog

@@ +1 @@
+2021-11-19  Saam Barati  <sbarati@apple.com>
+
+        Fix assertion added in r285592
+        https://bugs.webkit.org/show_bug.cgi?id=233373
+
+        Reviewed by Keith Miller.
+
+        * stress/validate-assert-uid-is-not-index-or-it-is-symbol.js: Added.
+        (main.v11):
+        (main.v29):
+        (main):
+
 2021-11-19  Joseph Griego  <jgriego@igalia.com>
 

trunk/Source/JavaScriptCore/ChangeLog

@@ +1 @@
+2021-11-19  Saam Barati  <sbarati@apple.com>
+
+        Fix assertion added in r285592
+        https://bugs.webkit.org/show_bug.cgi?id=233373
+        rdar://85451012
+
+        Reviewed by Keith Miller.
+
+        The assertion added in r285592 should not apply to Symbols. This patch
+        fixes that error. We don't care if a Symbol can be parsed as an index
+        since the string value in a Symbol is just its description, not the 
+        actual property.
+
+        * dfg/DFGValidate.cpp:
+
 2021-11-19  Joseph Griego  <jgriego@igalia.com>
 

trunk/Source/JavaScriptCore/dfg/DFGValidate.cpp

@@ -239 +239 @@
                 if (node->hasCacheableIdentifier()) {
                     auto* uid = node->cacheableIdentifier().uid();
-                    VALIDATE((node), !parseIndex(*uid));
+                    VALIDATE((node), uid->isSymbol() || !parseIndex(*uid));
                 }