Changeset 286071 in webkit

Timestamp:

Nov 19, 2021, 11:47:37 AM (5 years ago)

Author:

pvollan@apple.com

Message:

[macOS] Enable message filtering for all WebKit processes
​https://bugs.webkit.org/show_bug.cgi?id=233334
<rdar://problem/85568306>

Reviewed by Brent Fulgham.

The sandbox parameter enabling message filtering should be set in all WebKit processes.

• Shared/mac/AuxiliaryProcessMac.mm:

(WebKit::AuxiliaryProcess::initializeSandbox):

• WebProcess/cocoa/WebProcessCocoa.mm:

(WebKit::WebProcess::initializeSandbox):

Location:

trunk/Source/WebKit

Files:

• ChangeLog (modified) (1 diff)
• Shared/mac/AuxiliaryProcessMac.mm (modified) (2 diffs)
• WebProcess/cocoa/WebProcessCocoa.mm (modified) (2 diffs)

trunk/Source/WebKit/ChangeLog

@@ +1 @@
+2021-11-19  Per Arne  <pvollan@apple.com>
+
+        [macOS] Enable message filtering for all WebKit processes
+        https://bugs.webkit.org/show_bug.cgi?id=233334
+        <rdar://problem/85568306>
+
+        Reviewed by Brent Fulgham.
+
+        The sandbox parameter enabling message filtering should be set in all WebKit processes.
+
+        * Shared/mac/AuxiliaryProcessMac.mm:
+        (WebKit::AuxiliaryProcess::initializeSandbox):
+        * WebProcess/cocoa/WebProcessCocoa.mm:
+        (WebKit::WebProcess::initializeSandbox):
+
 2021-11-19  Antoine Quint  <graouts@webkit.org>
 

trunk/Source/WebKit/Shared/mac/AuxiliaryProcessMac.mm

@@ -57 +57 @@
 #import <wtf/SystemTracing.h>
 #import <wtf/WallTime.h>
+#import <wtf/cocoa/Entitlements.h>
 #import <wtf/spi/darwin/SandboxSPI.h>
 #import <wtf/text/Base64.h>
@@ -721 +722 @@
 #endif
 
+    bool enableMessageFilter = false;
+#if HAVE(SANDBOX_MESSAGE_FILTERING)
+    enableMessageFilter = WTF::processHasEntitlement("com.apple.private.security.message-filter");
+#endif
+    sandboxParameters.addParameter("ENABLE_SANDBOX_MESSAGE_FILTER", enableMessageFilter ? "YES" : "NO");
+
     initializeSandboxParameters(parameters, sandboxParameters);
 

trunk/Source/WebKit/WebProcess/cocoa/WebProcessCocoa.mm

@@ -103 +103 @@
 #import <wtf/ProcessPrivilege.h>
 #import <wtf/SoftLinking.h>
-#import <wtf/cocoa/Entitlements.h>
 #import <wtf/cocoa/NSURLExtras.h>
 #import <wtf/cocoa/RuntimeApplicationChecksCocoa.h>
@@ -697 +696 @@
     sandboxParameters.setOverrideSandboxProfilePath(makeString(String([webKitBundle resourcePath]), "/com.apple.WebProcess.sb"));
 
-    bool enableMessageFilter = false;
-#if HAVE(SANDBOX_MESSAGE_FILTERING)
-    enableMessageFilter = WTF::processHasEntitlement("com.apple.private.security.message-filter");
-#endif
-    sandboxParameters.addParameter("ENABLE_SANDBOX_MESSAGE_FILTER", enableMessageFilter ? "YES" : "NO");
-
     AuxiliaryProcess::initializeSandbox(parameters, sandboxParameters);
 #endif