Changeset 286105 in webkit

Timestamp:

Nov 21, 2021, 1:28:06 PM (5 years ago)

Author:

Jean-Yves Avenard

Message:

Remove unused HTMLModelElement::modelData() method.
​https://bugs.webkit.org/show_bug.cgi?id=233406
rdar://85640503

Reviewed by Sam Weinig.

No change in observable behaviour.

• Modules/model-element/HTMLModelElement.cpp:

(WebCore::HTMLModelElement::notifyFinished):

• Modules/model-element/HTMLModelElement.h:

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• Modules/model-element/HTMLModelElement.cpp (modified) (2 diffs)
• Modules/model-element/HTMLModelElement.h (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2021-11-21  Jean-Yves Avenard  <jya@apple.com>
+
+        Remove unused HTMLModelElement::modelData() method.
+        https://bugs.webkit.org/show_bug.cgi?id=233406
+        rdar://85640503
+
+        Reviewed by Sam Weinig.
+
+        No change in observable behaviour.
+
+        * Modules/model-element/HTMLModelElement.cpp:
+        (WebCore::HTMLModelElement::notifyFinished):
+        * Modules/model-element/HTMLModelElement.h:
+
 2021-11-21  Alan Bujtas  <zalan@apple.com>
 

trunk/Source/WebCore/Modules/model-element/HTMLModelElement.cpp

@@ -83 +83 @@
 }
 
-RefPtr<SharedBuffer> HTMLModelElement::modelData() const
-{
-    if (!m_dataComplete)
-        return nullptr;
-
-    return m_data;
-}
-
 RefPtr<Model> HTMLModelElement::model() const
 {
@@ -213 +205 @@
 
     m_dataComplete = true;
-    m_model = Model::create(*m_data, resource.mimeType(), resource.url());
+    m_model = Model::create(m_data.releaseNonNull().get(), resource.mimeType(), resource.url());
 
     invalidateResourceHandleAndUpdateRenderer();

trunk/Source/WebCore/Modules/model-element/HTMLModelElement.h

@@ -64 +64 @@
     ReadyPromise& ready() { return m_readyPromise.get(); }
 
-    RefPtr<SharedBuffer> modelData() const;
     RefPtr<Model> model() const;