⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Changeset 286125 in webkit


Ignore:
Timestamp:
Nov 22, 2021, 6:24:59 PM (5 years ago)
Author:
Wenson Hsieh
Message:

Remove old concurrent display list logic that's no longer necessary
​https://bugs.webkit.org/show_bug.cgi?id=233433

Reviewed by Sam Weinig.

Source/WebCore:

Now that concurrent display lists (i.e. for 2D canvas and DOM rendering in the GPU process) uses the same shared
IPC streaming mechanism as WebGL, we can remove the old concurrent display list processing logic around display
lists and the remote rendering backend in WebKit2.

No change in behavior, since this code is now all (effectively) unused.

  • platform/graphics/displaylists/DisplayList.cpp:

(WebCore::DisplayList::DisplayList::append):

  • platform/graphics/displaylists/DisplayListItemBuffer.cpp:

(WebCore::DisplayList::ItemHandle::apply):
(WebCore::DisplayList::ItemHandle::destroy):
(WebCore::DisplayList::ItemHandle::safeCopy const):
(WebCore::DisplayList::ItemBuffer::swapWritableBufferIfNeeded):

Additionally remove a couple of display list items that were only used for concurrent display list processing.
In a followup, we should remove more logic around this area pertaining to display list reader and writer
clients, and the display list replayer delegate.

  • platform/graphics/displaylists/DisplayListItemType.cpp:

(WebCore::DisplayList::sizeOfItemInBytes):
(WebCore::DisplayList::isDrawingItem):
(WebCore::DisplayList::isInlineItem):

  • platform/graphics/displaylists/DisplayListItemType.h:
  • platform/graphics/displaylists/DisplayListItems.cpp:

(WebCore::DisplayList::operator<<):

  • platform/graphics/displaylists/DisplayListItems.h:

(WebCore::DisplayList::MetaCommandChangeItemBuffer::MetaCommandChangeItemBuffer): Deleted.
(WebCore::DisplayList::MetaCommandChangeItemBuffer::identifier const): Deleted.
(WebCore::DisplayList::MetaCommandChangeItemBuffer::isValid const): Deleted.
(WebCore::DisplayList::MetaCommandChangeDestinationImageBuffer::MetaCommandChangeDestinationImageBuffer): Deleted.
(WebCore::DisplayList::MetaCommandChangeDestinationImageBuffer::identifier const): Deleted.
(WebCore::DisplayList::MetaCommandChangeDestinationImageBuffer::isValid const): Deleted.

  • platform/graphics/displaylists/DisplayListReplayer.cpp:

(WebCore::DisplayList::Replayer::replay):

Source/WebKit:

See WebCore ChangeLog for more details.

  • GPUProcess/graphics/DisplayListReaderHandle.cpp: Removed.
  • GPUProcess/graphics/DisplayListReaderHandle.h: Removed.
  • GPUProcess/graphics/RemoteRenderingBackend.h:
  • GPUProcess/graphics/RemoteRenderingBackendState.h: Removed.
  • GPUProcess/graphics/WebGPU/RemoteRenderBundleEncoder.cpp:

Add missing include to fix the build with unified sources.

  • Shared/GPUProcessWakeupMessageArguments.h: Removed.
  • Shared/SharedDisplayListHandle.h: Removed.
  • Sources.txt:
  • WebKit.xcodeproj/project.pbxproj:
  • WebProcess/GPU/graphics/DisplayListWriterHandle.cpp: Removed.
  • WebProcess/GPU/graphics/DisplayListWriterHandle.h: Removed.
  • WebProcess/GPU/graphics/RemoteRenderingBackendProxy.h:
  • WebProcess/Network/webrtc/LibWebRTCNetworkManager.h:

Add another missing include to fix the build with unified sources.

Tools:

See WebCore ChangeLog for more details.

  • TestWebKitAPI/Tests/WebCore/DisplayListTests.cpp:

(TestWebKitAPI::TEST):

Location:
trunk
Files:
7 deleted
17 edited

Legend:

Unmodified
Added
Removed

  • trunk/Source/WebCore/ChangeLog

    r286124 r286125  
     12021-11-22  Wenson Hsieh  <wenson_hsieh@apple.com>
     2
     3        Remove old concurrent display list logic that's no longer necessary
     4        https://bugs.webkit.org/show_bug.cgi?id=233433
     5
     6        Reviewed by Sam Weinig.
     7
     8        Now that concurrent display lists (i.e. for 2D canvas and DOM rendering in the GPU process) uses the same shared
     9        IPC streaming mechanism as WebGL, we can remove the old concurrent display list processing logic around display
     10        lists and the remote rendering backend in WebKit2.
     11
     12        No change in behavior, since this code is now all (effectively) unused.
     13
     14        * platform/graphics/displaylists/DisplayList.cpp:
     15        (WebCore::DisplayList::DisplayList::append):
     16        * platform/graphics/displaylists/DisplayListItemBuffer.cpp:
     17        (WebCore::DisplayList::ItemHandle::apply):
     18        (WebCore::DisplayList::ItemHandle::destroy):
     19        (WebCore::DisplayList::ItemHandle::safeCopy const):
     20        (WebCore::DisplayList::ItemBuffer::swapWritableBufferIfNeeded):
     21
     22        Additionally remove a couple of display list items that were only used for concurrent display list processing.
     23        In a followup, we should remove more logic around this area pertaining to display list reader and writer
     24        clients, and the display list replayer delegate.
     25
     26        * platform/graphics/displaylists/DisplayListItemType.cpp:
     27        (WebCore::DisplayList::sizeOfItemInBytes):
     28        (WebCore::DisplayList::isDrawingItem):
     29        (WebCore::DisplayList::isInlineItem):
     30        * platform/graphics/displaylists/DisplayListItemType.h:
     31        * platform/graphics/displaylists/DisplayListItems.cpp:
     32        (WebCore::DisplayList::operator<<):
     33        * platform/graphics/displaylists/DisplayListItems.h:
     34        (WebCore::DisplayList::MetaCommandChangeItemBuffer::MetaCommandChangeItemBuffer): Deleted.
     35        (WebCore::DisplayList::MetaCommandChangeItemBuffer::identifier const): Deleted.
     36        (WebCore::DisplayList::MetaCommandChangeItemBuffer::isValid const): Deleted.
     37        (WebCore::DisplayList::MetaCommandChangeDestinationImageBuffer::MetaCommandChangeDestinationImageBuffer): Deleted.
     38        (WebCore::DisplayList::MetaCommandChangeDestinationImageBuffer::identifier const): Deleted.
     39        (WebCore::DisplayList::MetaCommandChangeDestinationImageBuffer::isValid const): Deleted.
     40        * platform/graphics/displaylists/DisplayListReplayer.cpp:
     41        (WebCore::DisplayList::Replayer::replay):
     42
    1432021-11-22  Myles C. Maxfield  <mmaxfield@apple.com>
    244

  • trunk/Source/WebCore/platform/graphics/displaylists/DisplayList.cpp

    r284857 r286125  
    296296    case ItemType::FlushContext:
    297297        return append<FlushContext>(item.get<FlushContext>());
    298     case ItemType::MetaCommandChangeDestinationImageBuffer:
    299         return append<MetaCommandChangeDestinationImageBuffer>(item.get<MetaCommandChangeDestinationImageBuffer>());
    300     case ItemType::MetaCommandChangeItemBuffer:
    301         return append<MetaCommandChangeItemBuffer>(item.get<MetaCommandChangeItemBuffer>());
    302298    case ItemType::GetPixelBuffer:
    303299        return append<GetPixelBuffer>(item.get<GetPixelBuffer>());

  • trunk/Source/WebCore/platform/graphics/displaylists/DisplayListItemBuffer.cpp

    r284016 r286125  
    192192        get<FlushContext>().apply(context);
    193193        return;
    194     case ItemType::MetaCommandChangeDestinationImageBuffer:
    195     case ItemType::MetaCommandChangeItemBuffer:
    196         return;
    197194    case ItemType::GetPixelBuffer:
    198195    case ItemType::PutPixelBuffer:
    … …  
    392389    case ItemType::FlushContext:
    393390        static_assert(std::is_trivially_destructible<FlushContext>::value);
    394         return;
    395     case ItemType::MetaCommandChangeDestinationImageBuffer:
    396         static_assert(std::is_trivially_destructible<MetaCommandChangeDestinationImageBuffer>::value);
    397         return;
    398     case ItemType::MetaCommandChangeItemBuffer:
    399         static_assert(std::is_trivially_destructible<MetaCommandChangeItemBuffer>::value);
    400391        return;
    401392#if ENABLE(VIDEO)
    … …  
    591582    case ItemType::FlushContext:
    592583        return copyInto<FlushContext>(itemOffset, *this);
    593     case ItemType::MetaCommandChangeDestinationImageBuffer:
    594         return copyInto<MetaCommandChangeDestinationImageBuffer>(itemOffset, *this);
    595     case ItemType::MetaCommandChangeItemBuffer:
    596         return copyInto<MetaCommandChangeItemBuffer>(itemOffset, *this);
    597584#if ENABLE(VIDEO)
    598585    case ItemType::PaintFrameForMedia:
    … …  
    726713DidChangeItemBuffer ItemBuffer::swapWritableBufferIfNeeded(size_t numberOfBytes)
    727714{
    728     auto sizeForBufferSwitchItem = paddedSizeOfTypeAndItemInBytes(ItemType::MetaCommandChangeItemBuffer);
    729     if (m_writtenNumberOfBytes + numberOfBytes + sizeForBufferSwitchItem <= m_writableBuffer.capacity)
     715    if (m_writtenNumberOfBytes + numberOfBytes <= m_writableBuffer.capacity)
    730716        return DidChangeItemBuffer::No;
    731717
    732     auto nextBuffer = createItemBuffer(numberOfBytes + sizeForBufferSwitchItem);
     718    auto nextBuffer = createItemBuffer(numberOfBytes);
    733719    bool hadPreviousBuffer = m_writableBuffer && m_writableBuffer.identifier != nextBuffer.identifier;
    734720    if (hadPreviousBuffer) {
    735         uncheckedAppend<MetaCommandChangeItemBuffer>(DidChangeItemBuffer::No, nextBuffer.identifier);
    736721        m_writableBuffer.capacity = m_writtenNumberOfBytes;
    737722        m_readOnlyBuffers.append(m_writableBuffer);

  • trunk/Source/WebCore/platform/graphics/displaylists/DisplayListItemType.cpp

    r284016 r286125  
    133133    case ItemType::FlushContext:
    134134        return sizeof(FlushContext);
    135     case ItemType::MetaCommandChangeDestinationImageBuffer:
    136         return sizeof(MetaCommandChangeDestinationImageBuffer);
    137     case ItemType::MetaCommandChangeItemBuffer:
    138         return sizeof(MetaCommandChangeItemBuffer);
    139135    case ItemType::GetPixelBuffer:
    140136        return sizeof(GetPixelBuffer);
    … …  
    201197    case ItemType::ConcatenateCTM:
    202198    case ItemType::FlushContext:
    203     case ItemType::MetaCommandChangeDestinationImageBuffer:
    204     case ItemType::MetaCommandChangeItemBuffer:
    205199    case ItemType::Restore:
    206200    case ItemType::Rotate:
    … …  
    344338    case ItemType::FillRect:
    345339    case ItemType::FlushContext:
    346     case ItemType::MetaCommandChangeDestinationImageBuffer:
    347     case ItemType::MetaCommandChangeItemBuffer:
    348340#if ENABLE(VIDEO)
    349341    case ItemType::PaintFrameForMedia:

  • trunk/Source/WebCore/platform/graphics/displaylists/DisplayListItemType.h

    r283697 r286125  
    8080    FillEllipse,
    8181    FlushContext,
    82     MetaCommandChangeDestinationImageBuffer,
    83     MetaCommandChangeItemBuffer,
    8482    GetPixelBuffer,
    8583    PutPixelBuffer,

  • trunk/Source/WebCore/platform/graphics/displaylists/DisplayListItems.cpp

    r283697 r286125  
    10301030
    10311031static TextStream& operator<<(TextStream& ts, const FlushContext& item)
    1032 {
    1033     ts.dumpProperty("identifier", item.identifier());
    1034     return ts;
    1035 }
    1036 
    1037 static TextStream& operator<<(TextStream& ts, const MetaCommandChangeItemBuffer& item)
    1038 {
    1039     ts.dumpProperty("identifier", item.identifier());
    1040     return ts;
    1041 }
    1042 
    1043 static TextStream& operator<<(TextStream& ts, const MetaCommandChangeDestinationImageBuffer& item)
    10441032{
    10451033    ts.dumpProperty("identifier", item.identifier());
    … …  
    10991087    case ItemType::FillEllipse: ts << "fill-ellipse"; break;
    11001088    case ItemType::FlushContext: ts << "flush-context"; break;
    1101     case ItemType::MetaCommandChangeDestinationImageBuffer: ts << "meta-command-change-destination-image-buffer"; break;
    1102     case ItemType::MetaCommandChangeItemBuffer: ts << "meta-command-change-item-buffer"; break;
    11031089    case ItemType::GetPixelBuffer: ts << "get-pixel-buffer"; break;
    11041090    case ItemType::PutPixelBuffer: ts << "put-pixel-buffer"; break;
    … …  
    12701256        ts << item.get<FlushContext>();
    12711257        break;
    1272     case ItemType::MetaCommandChangeDestinationImageBuffer:
    1273         ts << item.get<MetaCommandChangeDestinationImageBuffer>();
    1274         break;
    1275     case ItemType::MetaCommandChangeItemBuffer:
    1276         ts << item.get<MetaCommandChangeItemBuffer>();
    1277         break;
    12781258    case ItemType::GetPixelBuffer:
    12791259        ts << item.get<GetPixelBuffer>();

  • trunk/Source/WebCore/platform/graphics/displaylists/DisplayListItems.h

    r284213 r286125  
    23902390private:
    23912391    GraphicsContextFlushIdentifier m_identifier;
    2392 };
    2393 
    2394 // FIXME: This should be refactored so that the command to "switch to the next item buffer"
    2395 // is not itself a display list item.
    2396 class MetaCommandChangeItemBuffer {
    2397 public:
    2398     static constexpr ItemType itemType = ItemType::MetaCommandChangeItemBuffer;
    2399     static constexpr bool isInlineItem = true;
    2400     static constexpr bool isDrawingItem = false;
    2401 
    2402     explicit MetaCommandChangeItemBuffer(ItemBufferIdentifier identifier)
    2403         : m_identifier(identifier)
    2404     {
    2405     }
    2406 
    2407     ItemBufferIdentifier identifier() const { return m_identifier; }
    2408     bool isValid() const { return m_identifier.isValid(); }
    2409 
    2410 private:
    2411     ItemBufferIdentifier m_identifier;
    2412 };
    2413 
    2414 class MetaCommandChangeDestinationImageBuffer {
    2415 public:
    2416     static constexpr ItemType itemType = ItemType::MetaCommandChangeDestinationImageBuffer;
    2417     static constexpr bool isInlineItem = true;
    2418     static constexpr bool isDrawingItem = false;
    2419 
    2420     explicit MetaCommandChangeDestinationImageBuffer(RenderingResourceIdentifier identifier)
    2421         : m_identifier(identifier)
    2422     {
    2423     }
    2424 
    2425     RenderingResourceIdentifier identifier() const { return m_identifier; }
    2426     bool isValid() const { return m_identifier.isValid(); }
    2427 
    2428 private:
    2429     RenderingResourceIdentifier m_identifier;
    24302392};
    24312393
    … …  
    24662428    , FlushContext
    24672429    , GetPixelBuffer
    2468     , MetaCommandChangeDestinationImageBuffer
    2469     , MetaCommandChangeItemBuffer
    24702430    , PutPixelBuffer
    24712431    , Restore
    … …  
    25712531    WebCore::DisplayList::ItemType::FillEllipse,
    25722532    WebCore::DisplayList::ItemType::FlushContext,
    2573     WebCore::DisplayList::ItemType::MetaCommandChangeDestinationImageBuffer,
    2574     WebCore::DisplayList::ItemType::MetaCommandChangeItemBuffer,
    25752533    WebCore::DisplayList::ItemType::GetPixelBuffer,
    25762534    WebCore::DisplayList::ItemType::PutPixelBuffer,

  • trunk/Source/WebCore/platform/graphics/displaylists/DisplayListReplayer.cpp

    r283971 r286125  
    226226        LOG_WITH_STREAM(DisplayLists, stream << "applying " << i++ << " " << item);
    227227
    228         if (item.is<MetaCommandChangeDestinationImageBuffer>()) {
    229             result.numberOfBytesRead += itemSizeInBuffer;
    230             result.reasonForStopping = StopReplayReason::ChangeDestinationImageBuffer;
    231             result.nextDestinationImageBuffer = item.get<MetaCommandChangeDestinationImageBuffer>().identifier();
    232             break;
    233         }
    234 
    235228        if (auto [reasonForStopping, missingCachedResourceIdentifier] = applyItem(item); reasonForStopping) {
    236229            result.reasonForStopping = *reasonForStopping;

  • trunk/Source/WebKit/ChangeLog

    r286120 r286125  
     12021-11-22  Wenson Hsieh  <wenson_hsieh@apple.com>
     2
     3        Remove old concurrent display list logic that's no longer necessary
     4        https://bugs.webkit.org/show_bug.cgi?id=233433
     5
     6        Reviewed by Sam Weinig.
     7
     8        See WebCore ChangeLog for more details.
     9
     10        * GPUProcess/graphics/DisplayListReaderHandle.cpp: Removed.
     11        * GPUProcess/graphics/DisplayListReaderHandle.h: Removed.
     12        * GPUProcess/graphics/RemoteRenderingBackend.h:
     13        * GPUProcess/graphics/RemoteRenderingBackendState.h: Removed.
     14        * GPUProcess/graphics/WebGPU/RemoteRenderBundleEncoder.cpp:
     15
     16        Add missing include to fix the build with unified sources.
     17
     18        * Shared/GPUProcessWakeupMessageArguments.h: Removed.
     19        * Shared/SharedDisplayListHandle.h: Removed.
     20        * Sources.txt:
     21        * WebKit.xcodeproj/project.pbxproj:
     22        * WebProcess/GPU/graphics/DisplayListWriterHandle.cpp: Removed.
     23        * WebProcess/GPU/graphics/DisplayListWriterHandle.h: Removed.
     24        * WebProcess/GPU/graphics/RemoteRenderingBackendProxy.h:
     25        * WebProcess/Network/webrtc/LibWebRTCNetworkManager.h:
     26
     27        Add another missing include to fix the build with unified sources.
     28
    1292021-11-22  Fujii Hironori  <Hironori.Fujii@sony.com>
    230

  • trunk/Source/WebKit/GPUProcess/graphics/RemoteRenderingBackend.h

    r284768 r286125  
    3535#include "QualifiedRenderingResourceIdentifier.h"
    3636#include "RemoteDisplayListRecorder.h"
    37 #include "RemoteRenderingBackendState.h"
    3837#include "RemoteResourceCache.h"
    3938#include "RenderingBackendIdentifier.h"

  • trunk/Source/WebKit/GPUProcess/graphics/WebGPU/RemoteRenderBundleEncoder.cpp

    r286087 r286125  
    3232#include "WebGPUObjectHeap.h"
    3333#include "WebGPUObjectRegistry.h"
     34#include <pal/graphics/WebGPU/WebGPURenderBundle.h>
    3435#include <pal/graphics/WebGPU/WebGPURenderBundleEncoder.h>
    3536

  • trunk/Source/WebKit/Sources.txt

    r286087 r286125  
    2525GPUProcess/GPUConnectionToWebProcess.cpp
    2626GPUProcess/GPUProcessCreationParameters.cpp
    27 GPUProcess/graphics/DisplayListReaderHandle.cpp
    2827GPUProcess/graphics/RemoteDisplayListRecorder.cpp
    2928GPUProcess/graphics/RemoteRenderingBackend.cpp
    … …  
    707706WebProcess/GPU/graphics/WebGPU/RemoteTextureViewProxy.cpp
    708707WebProcess/GPU/graphics/WebGPU/WebGPUDowncastConvertToBackingContext.cpp
    709 WebProcess/GPU/graphics/DisplayListWriterHandle.cpp
    710708WebProcess/GPU/graphics/ImageBufferShareableBitmapBackend.cpp
    711709WebProcess/GPU/graphics/RemoteGraphicsContextGLProxyFunctionsGenerated.cpp

  • trunk/Source/WebKit/WebKit.xcodeproj/project.pbxproj

    r286087 r286125  
    19841984                E5DEFA6826F8F42600AB68DB /* PhotosUISPI.h in Headers */ = {isa = PBXBuildFile; fileRef = E5DEFA6726F8F42600AB68DB /* PhotosUISPI.h */; };
    19851985                ED82A7F2128C6FAF004477B3 /* WKBundlePageOverlay.h in Headers */ = {isa = PBXBuildFile; fileRef = 1A22F0FF1289FCD90085E74F /* WKBundlePageOverlay.h */; settings = {ATTRIBUTES = (Private, ); }; };
    1986                 F4094CBD2553053D003D73E3 /* DisplayListReaderHandle.h in Headers */ = {isa = PBXBuildFile; fileRef = F4094CBB255304AF003D73E3 /* DisplayListReaderHandle.h */; };
    1987                 F4094CBE25530540003D73E3 /* DisplayListWriterHandle.h in Headers */ = {isa = PBXBuildFile; fileRef = F4094CB92553047E003D73E3 /* DisplayListWriterHandle.h */; };
    19881986                F409BA181E6E64BC009DA28E /* WKDragDestinationAction.h in Headers */ = {isa = PBXBuildFile; fileRef = F409BA171E6E64B3009DA28E /* WKDragDestinationAction.h */; settings = {ATTRIBUTES = (Private, ); }; };
    1989                 F40BBB41257FF46E0067463A /* GPUProcessWakeupMessageArguments.h in Headers */ = {isa = PBXBuildFile; fileRef = F40BBB40257FF46E0067463A /* GPUProcessWakeupMessageArguments.h */; };
    1990                 F414CE2D269DE6EA00BD216A /* RemoteRenderingBackendState.h in Headers */ = {isa = PBXBuildFile; fileRef = F414CE2C269DE6EA00BD216A /* RemoteRenderingBackendState.h */; };
    19911987                F4299507270E234D0032298B /* StreamMessageReceiver.h in Headers */ = {isa = PBXBuildFile; fileRef = F4299506270E234C0032298B /* StreamMessageReceiver.h */; };
    19921988                F42D634122A0EFDF00D2FB3A /* WebAutocorrectionData.h in Headers */ = {isa = PBXBuildFile; fileRef = F42D633F22A0EFD300D2FB3A /* WebAutocorrectionData.h */; };
    … …  
    20112007                F4974E76265ECBBC00B49B8C /* WKRevealItemPresenter.h in Headers */ = {isa = PBXBuildFile; fileRef = F446EDEF265EB2B00031DA8F /* WKRevealItemPresenter.h */; };
    20122008                F4975CF22624B80A003C626E /* WKQuickLookPreviewController.h in Headers */ = {isa = PBXBuildFile; fileRef = F4975CF12624B80A003C626E /* WKQuickLookPreviewController.h */; };
    2013                 F4A6D6BC254CA3E900B65FAA /* SharedDisplayListHandle.h in Headers */ = {isa = PBXBuildFile; fileRef = F4A6D6BB254CA3E900B65FAA /* SharedDisplayListHandle.h */; };
    20142009                F4BA33F225757E89000A3CE8 /* WKImageAnalysisGestureRecognizer.h in Headers */ = {isa = PBXBuildFile; fileRef = F4BA33F025757E89000A3CE8 /* WKImageAnalysisGestureRecognizer.h */; };
    20152010                F4CB09E5225D5A0900891487 /* WebsiteMediaSourcePolicy.h in Headers */ = {isa = PBXBuildFile; fileRef = F4CB09E4225D5A0300891487 /* WebsiteMediaSourcePolicy.h */; };
    … …  
    62056200                ECBFC1DB1E6A4D66000300C7 /* ExtraPublicSymbolsForTAPI.h */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.c.h; path = ExtraPublicSymbolsForTAPI.h; sourceTree = "<group>"; };
    62066201                F036978715F4BF0500C3A80E /* WebColorPicker.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = WebColorPicker.cpp; sourceTree = "<group>"; };
    6207                 F4094CB92553047E003D73E3 /* DisplayListWriterHandle.h */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.c.h; path = DisplayListWriterHandle.h; sourceTree = "<group>"; };
    6208                 F4094CBA2553047E003D73E3 /* DisplayListWriterHandle.cpp */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.cpp.cpp; path = DisplayListWriterHandle.cpp; sourceTree = "<group>"; };
    6209                 F4094CBB255304AF003D73E3 /* DisplayListReaderHandle.h */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.c.h; path = DisplayListReaderHandle.h; sourceTree = "<group>"; };
    6210                 F4094CBC255304AF003D73E3 /* DisplayListReaderHandle.cpp */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.cpp.cpp; path = DisplayListReaderHandle.cpp; sourceTree = "<group>"; };
    62116202                F409BA171E6E64B3009DA28E /* WKDragDestinationAction.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = WKDragDestinationAction.h; sourceTree = "<group>"; };
    6212                 F40BBB40257FF46E0067463A /* GPUProcessWakeupMessageArguments.h */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.c.h; path = GPUProcessWakeupMessageArguments.h; sourceTree = "<group>"; };
    62136203                F40D1B68220BDC0F00B49A01 /* WebAutocorrectionContext.h */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.c.h; name = WebAutocorrectionContext.h; path = ios/WebAutocorrectionContext.h; sourceTree = "<group>"; };
    62146204                F41056612130699A0092281D /* APIAttachmentCocoa.mm */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.cpp.objcpp; path = APIAttachmentCocoa.mm; sourceTree = "<group>"; };
    6215                 F414CE2C269DE6EA00BD216A /* RemoteRenderingBackendState.h */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.c.h; path = RemoteRenderingBackendState.h; sourceTree = "<group>"; };
    62166205                F4299506270E234C0032298B /* StreamMessageReceiver.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = StreamMessageReceiver.h; sourceTree = "<group>"; };
    62176206                F42D633F22A0EFD300D2FB3A /* WebAutocorrectionData.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; name = WebAutocorrectionData.h; path = ios/WebAutocorrectionData.h; sourceTree = "<group>"; };
    … …  
    62526241                F4975CF12624B80A003C626E /* WKQuickLookPreviewController.h */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.c.h; path = WKQuickLookPreviewController.h; sourceTree = "<group>"; };
    62536242                F4975CF32624B918003C626E /* WKQuickLookPreviewController.mm */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.cpp.objcpp; path = WKQuickLookPreviewController.mm; sourceTree = "<group>"; };
    6254                 F4A6D6BB254CA3E900B65FAA /* SharedDisplayListHandle.h */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.c.h; path = SharedDisplayListHandle.h; sourceTree = "<group>"; };
    62556243                F4A7CE842667EB4E00228685 /* TextRecognitionUpdateResult.h */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.c.h; path = TextRecognitionUpdateResult.h; sourceTree = "<group>"; };
    62566244                F4AC655E22A3140E00A05607 /* WebPreferencesDefaultValuesIOS.mm */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.objcpp; name = WebPreferencesDefaultValuesIOS.mm; path = ios/WebPreferencesDefaultValuesIOS.mm; sourceTree = "<group>"; };
    … …  
    69186906                                410F0D4B2701EFEA00F96DFC /* GPUProcessConnectionInitializationParameters.h */,
    69196907                                46AC532425DED81E003B57EC /* GPUProcessConnectionParameters.h */,
    6920                                 F40BBB40257FF46E0067463A /* GPUProcessWakeupMessageArguments.h */,
    69216908                                1AC75A1A1B3368270056745B /* HangDetectionDisabler.h */,
    69226909                                0FD2CB2526CDD7A30008B11C /* IdentifierTypes.h */,
    … …  
    69676954                                5121745E164C20E30037A5C1 /* ShareableResource.cpp */,
    69686955                                5121745F164C20E30037A5C1 /* ShareableResource.h */,
    6969                                 F4A6D6BB254CA3E900B65FAA /* SharedDisplayListHandle.h */,
    69706956                                8313F7EA1F7DAE0400B944EB /* SharedStringHashStore.cpp */,
    69716957                                8313F7E91F7DAE0300B944EB /* SharedStringHashStore.h */,
    … …  
    93589344                                727A7F3324078527004D2931 /* cocoa */,
    93599345                                1CB7461927436DE300F19874 /* WebGPU */,
    9360                                 F4094CBA2553047E003D73E3 /* DisplayListWriterHandle.cpp */,
    9361                                 F4094CB92553047E003D73E3 /* DisplayListWriterHandle.h */,
    93629346                                7B64C0B6254C5C250006B4AF /* GraphicsContextGLIdentifier.h */,
    93639347                                727A7F39240788F1004D2931 /* ImageBufferBackendHandle.h */,
    … …  
    93879371                        children = (
    93889372                                1C98C01C27446926002CCB78 /* WebGPU */,
    9389                                 F4094CBC255304AF003D73E3 /* DisplayListReaderHandle.cpp */,
    9390                                 F4094CBB255304AF003D73E3 /* DisplayListReaderHandle.h */,
    93919373                                7B1619132719AE7600C40EAC /* GPUProcessGraphicsContextGL.h */,
    93929374                                55AD09432408A0E600DE4D2F /* PlatformRemoteImageBuffer.h */,
    … …  
    94069388                                550640A424071C2100AAE045 /* RemoteRenderingBackend.messages.in */,
    94079389                                460889FF261FA8A900E2500D /* RemoteRenderingBackendCreationParameters.h */,
    9408                                 F414CE2C269DE6EA00BD216A /* RemoteRenderingBackendState.h */,
    94099390                                726D56DD253A64810002EF90 /* RemoteResourceCache.cpp */,
    94109391                                726D56DE253A64810002EF90 /* RemoteResourceCache.h */,
    … …  
    1254712528                                C18173612058424700DFDA65 /* DisplayLink.h in Headers */,
    1254812529                                0F189CAC24749F2F00E58D81 /* DisplayLinkObserverID.h in Headers */,
    12549                                 F4094CBD2553053D003D73E3 /* DisplayListReaderHandle.h in Headers */,
    12550                                 F4094CBE25530540003D73E3 /* DisplayListWriterHandle.h in Headers */,
    1255112530                                5C1427021C23F84C00D41183 /* Download.h in Headers */,
    1255212531                                5C1427051C23F84C00D41183 /* DownloadID.h in Headers */,
    … …  
    1259812577                                410F0D4C2701EFF900F96DFC /* GPUProcessConnectionInitializationParameters.h in Headers */,
    1259912578                                4614F13225DED875007006E7 /* GPUProcessConnectionParameters.h in Headers */,
    12600                                 F40BBB41257FF46E0067463A /* GPUProcessWakeupMessageArguments.h in Headers */,
    1260112579                                2DA049B8180CCD0A00AAFA9E /* GraphicsLayerCARemote.h in Headers */,
    1260212580                                C0CE72AD1247E78D00BC0EC4 /* HandleMessage.h in Headers */,
    … …  
    1285912837                                F4517D7C26FBCD39004C8475 /* RemoteRenderingBackendMessages.h in Headers */,
    1286012838                                F4517D7B26FBCD39004C8475 /* RemoteRenderingBackendMessagesReplies.h in Headers */,
    12861                                 F414CE2D269DE6EA00BD216A /* RemoteRenderingBackendState.h in Headers */,
    1286212839                                0F594790187B3B3A00437857 /* RemoteScrollingCoordinator.h in Headers */,
    1286312840                                0F5947A8187B517600437857 /* RemoteScrollingCoordinatorMessages.h in Headers */,
    … …  
    1290012877                                A183494224EF467800BDC9A8 /* SharedBufferCopy.h in Headers */,
    1290112878                                2DC18FF6EF2A3130C1301767 /* SharedBufferDataReference.h in Headers */,
    12902                                 F4A6D6BC254CA3E900B65FAA /* SharedDisplayListHandle.h in Headers */,
    1290312879                                93122C862710CCDF001D819F /* SharedFileHandle.h in Headers */,
    1290412880                                1A24BED5120894D100FBB059 /* SharedMemory.h in Headers */,

  • trunk/Source/WebKit/WebProcess/GPU/graphics/RemoteRenderingBackendProxy.h

    r285233 r286125  
    2929
    3030#include "GPUProcessConnection.h"
    31 #include "GPUProcessWakeupMessageArguments.h"
    3231#include "IPCSemaphore.h"
    3332#include "ImageBufferBackendHandle.h"

  • trunk/Source/WebKit/WebProcess/Network/webrtc/LibWebRTCNetworkManager.h

    r286012 r286125  
    3030#include "WebRTCMonitor.h"
    3131#include <WebCore/LibWebRTCProvider.h>
     32#include <WebCore/ProcessQualified.h>
    3233#include <WebCore/RTCNetworkManager.h>
    3334#include <WebCore/ScriptExecutionContextIdentifier.h>

  • trunk/Tools/ChangeLog

    r286111 r286125  
     12021-11-22  Wenson Hsieh  <wenson_hsieh@apple.com>
     2
     3        Remove old concurrent display list logic that's no longer necessary
     4        https://bugs.webkit.org/show_bug.cgi?id=233433
     5
     6        Reviewed by Sam Weinig.
     7
     8        See WebCore ChangeLog for more details.
     9
     10        * TestWebKitAPI/Tests/WebCore/DisplayListTests.cpp:
     11        (TestWebKitAPI::TEST):
     12
    1132021-11-22  Geza Lore  <glore@igalia.com>
    214

  • trunk/Tools/TestWebKitAPI/Tests/WebCore/DisplayListTests.cpp

    r284095 r286125  
    123123        }
    124124#endif
    125         case ItemType::MetaCommandChangeItemBuffer:
    126             break;
    127125        default: {
    128126            observedUnexpectedItem = true;
Note: See TracChangeset for help on using the changeset viewer.