Changeset 286165 in webkit

Timestamp:

Nov 25, 2021, 4:02:28 AM (5 years ago)

Author:

eocanha@igalia.com

Message:

[GTK] Layout Test http/tests/media/video-play-waiting.html is timing out
​https://bugs.webkit.org/show_bug.cgi?id=142489

Reviewed by Philippe Normand.

The test was failing with a timeout even after properly calling TestRunner.notifyDone()
internally because there was still an injectedBundle.topLoadingFrame() in InjectedBundlePage,
which means that the web page hadn't completely finished to be downloaded. This was caused
by the stalled video download that the test wants to exercise.

The solution is to set the video src to empty in order to convince TestRunner that the page
has finished downloading.

• http/tests/media/video-play-waiting.html: Set the video src to empty.
• platform/mac/TestExpectations: The test now just fails (for reasons unrelated to this fix) on mac instead of timing out.
• platform/glib/TestExpectations: Unskipped test.
• platform/win/TestExpectations: Unskipped test.

Location:

trunk/LayoutTests

Files:

• ChangeLog (modified) (1 diff)
• http/tests/media/video-play-waiting.html (modified) (1 diff)
• platform/glib/TestExpectations (modified) (1 diff)
• platform/mac/TestExpectations (modified) (1 diff)
• platform/win/TestExpectations (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2021-11-25  Enrique Ocaña González  <eocanha@igalia.com>
+
+        [GTK] Layout Test http/tests/media/video-play-waiting.html is timing out
+        https://bugs.webkit.org/show_bug.cgi?id=142489
+
+        Reviewed by Philippe Normand.
+
+        The test was failing with a timeout even after properly calling TestRunner.notifyDone()
+        internally because there was still an injectedBundle.topLoadingFrame() in InjectedBundlePage,
+        which means that the web page hadn't completely finished to be downloaded. This was caused
+        by the stalled video download that the test wants to exercise.
+
+        The solution is to set the video src to empty in order to convince TestRunner that the page
+        has finished downloading.
+
+        * http/tests/media/video-play-waiting.html: Set the video src to empty.
+        * platform/mac/TestExpectations: The test now just fails (for reasons unrelated to this fix) on mac instead of timing out.
+        * platform/glib/TestExpectations: Unskipped test.
+        * platform/win/TestExpectations: Unskipped test.
+
 2021-11-24  Ziran Sun  <zsun@igalia.com>
 

trunk/LayoutTests/http/tests/media/video-play-waiting.html

@@ -10 +10 @@
     waitForEvent('loadedmetadata');
     waitForEvent('loadeddata');
-    waitForEventAndEnd('waiting');
+    waitForEventAndEnd('waiting', function() {
+        // TestRunner waits for the complete frame download before finishing, so having the video load stalled
+        // prevents TestRunner from finishing. Changing the src will abort the download and let the test finish.
+        video.src = "";
+    });
 
     waitForEvent('canplay', function () {

trunk/LayoutTests/platform/glib/TestExpectations

@@ -2357 +2357 @@
 webkit.org/b/137698 media/video-controls-drag.html [ Timeout ]
 webkit.org/b/141959 http/tests/media/clearkey/clear-key-hls-aes128.html [ Crash Timeout ]
-webkit.org/b/142489 http/tests/media/video-play-waiting.html [ Timeout ]
 webkit.org/b/130971 media/track/track-remove-track.html [ Timeout ]
 webkit.org/b/113127 media/track/track-prefer-captions.html [ Timeout ]

trunk/LayoutTests/platform/mac/TestExpectations

@@ -746 +746 @@
 webkit.org/b/136708 media/media-fullscreen-not-in-document.html
 
-webkit.org/b/140639 http/tests/media/video-play-waiting.html [ Pass Timeout ]
-
+webkit.org/b/140639 http/tests/media/video-play-waiting.html [ Failure ]
 # This test requires generation of progress events during loading
 webkit.org/b/100984 media/progress-events-generated-correctly.html [ Failure ]

trunk/LayoutTests/platform/win/TestExpectations

@@ -1098 +1098 @@
 http/tests/media/hls/video-cookie.html [ Skip ] # Timeout
 http/tests/media/video-buffered-range-contains-currentTime.html [ Skip ] # Timeout
-http/tests/media/video-play-waiting.html [ Skip ] # Timeout
 
 # Extra whitespace in the output