Changeset 286537 in webkit

Timestamp:

Dec 5, 2021, 8:40:19 PM (5 years ago)

Author:

Simon Fraser

Message:

Add trace points for generated momentum events
​https://bugs.webkit.org/show_bug.cgi?id=233857

Reviewed by Tim Horton.

Source/WebKit:

Add start/end points for synthetic momentum, and a trace point for each generated event.

• WebProcess/WebPage/MomentumEventDispatcher.cpp:

(WebKit::MomentumEventDispatcher::dispatchSyntheticMomentumEvent):
(WebKit::MomentumEventDispatcher::didStartMomentumPhase):
(WebKit::MomentumEventDispatcher::didEndMomentumPhase):

Source/WTF:

• wtf/SystemTracing.h:

Tools:

Add start/end points for synthetic momentum, and a trace point for each generated event.

• Tracing/SystemTracePoints.plist:

Location:

trunk

Files:

• Source/WTF/ChangeLog (modified) (1 diff)
• Source/WTF/wtf/SystemTracing.h (modified) (1 diff)
• Source/WebKit/ChangeLog (modified) (1 diff)
• Source/WebKit/WebProcess/WebPage/MomentumEventDispatcher.cpp (modified) (4 diffs)
• Tools/ChangeLog (modified) (1 diff)
• Tools/Tracing/SystemTracePoints.plist (modified) (1 diff)

trunk/Source/WTF/ChangeLog

@@ +1 @@
+2021-12-05  Simon Fraser  <simon.fraser@apple.com>
+
+        Add trace points for generated momentum events
+        https://bugs.webkit.org/show_bug.cgi?id=233857
+
+        Reviewed by Tim Horton.
+
+        * wtf/SystemTracing.h:
+
 2021-12-03  Chris Dumez  <cdumez@apple.com>
 

trunk/Source/WTF/wtf/SystemTracing.h

@@ -128 +128 @@
     TakeSnapshotStart,
     TakeSnapshotEnd,
+    SyntheticMomentumStart,
+    SyntheticMomentumEnd,
+    SyntheticMomentumEvent,
 
     UIProcessRange = 14000,

trunk/Source/WebKit/ChangeLog

@@ +1 @@
+2021-12-05  Simon Fraser  <simon.fraser@apple.com>
+
+        Add trace points for generated momentum events
+        https://bugs.webkit.org/show_bug.cgi?id=233857
+
+        Reviewed by Tim Horton.
+
+        Add start/end points for synthetic momentum, and a trace point for each generated event.
+
+        * WebProcess/WebPage/MomentumEventDispatcher.cpp:
+        (WebKit::MomentumEventDispatcher::dispatchSyntheticMomentumEvent):
+        (WebKit::MomentumEventDispatcher::didStartMomentumPhase):
+        (WebKit::MomentumEventDispatcher::didEndMomentumPhase):
+
 2021-12-04  Myles C. Maxfield  <mmaxfield@apple.com>
 

trunk/Source/WebKit/WebProcess/WebPage/MomentumEventDispatcher.cpp

@@ -35 +35 @@
 #include <WebCore/DisplayRefreshMonitor.h>
 #include <WebCore/Scrollbar.h>
+#include <wtf/SystemTracing.h>
 
 namespace WebKit {
@@ -145 +146 @@
 void MomentumEventDispatcher::dispatchSyntheticMomentumEvent(WebWheelEvent::Phase phase, WebCore::FloatSize delta)
 {
+    tracePoint(SyntheticMomentumEvent, static_cast<uint64_t>(phase), std::abs(delta.width()), std::abs(delta.height()));
+
     ASSERT(m_currentGesture.active);
     ASSERT(m_currentGesture.initiatingEvent);
@@ -183 +186 @@
 void MomentumEventDispatcher::didStartMomentumPhase(WebCore::PageIdentifier pageIdentifier, const WebWheelEvent& event)
 {
+    tracePoint(SyntheticMomentumStart);
+
     auto momentumStartInterval = event.ioHIDEventTimestamp() - m_lastEndedEventTimestamp;
 
@@ -224 +229 @@
 
     m_currentGesture = { };
+    tracePoint(SyntheticMomentumEnd);
 }
 

trunk/Tools/ChangeLog

@@ +1 @@
+2021-12-05  Simon Fraser  <simon.fraser@apple.com>
+
+        Add trace points for generated momentum events
+        https://bugs.webkit.org/show_bug.cgi?id=233857
+
+        Reviewed by Tim Horton.
+
+        Add start/end points for synthetic momentum, and a trace point for each generated event.
+
+        * Tracing/SystemTracePoints.plist:
+
 2021-12-04  Andres Gonzalez  <andresg_22@apple.com>
 

trunk/Tools/Tracing/SystemTracePoints.plist

@@ -597 +597 @@
              <dict>
                  <key>Name</key>
+                 <string>Synthetic momentum</string>
+                 <key>Type</key>
+                 <string>Interval</string>
+                 <key>Component</key>
+                 <string>47</string>
+                 <key>CodeBegin</key>
+                 <string>12025</string>
+                 <key>CodeEnd</key>
+                 <string>12026</string>
+                 <key>ArgNamesEnd</key>
+                 <dict>
+                     <key>Arg1</key>
+                     <string>Initial Velocity X</string>
+                     <key>Arg2</key>
+                     <string>Initial Velocity Y</string>
+                 </dict>
+             </dict>
+             <dict>
+                 <key>Name</key>
+                 <string>Synthetic momentum event</string>
+                 <key>Type</key>
+                 <string>Level</string>
+                 <key>Component</key>
+                 <string>47</string>
+                 <key>Code</key>
+                 <string>12027</string>
+                 <key>ArgNames</key>
+                 <dict>
+                     <key>Arg1</key>
+                     <string>Phase</string>
+                     <key>Arg2</key>
+                     <string>Delta X</string>
+                     <key>Arg3</key>
+                     <string>Delta Y</string>
+                 </dict>
+                 <key>LevelArg</key>
+                 <string>Arg3</string>
+                 <key>LevelDataType</key>
+                 <string>UInt64</string>
+             </dict>
+             <dict>
+                 <key>Name</key>
                  <string>Commit RemoteLayerTree transaction</string>
                  <key>Type</key>